Page MenuHomePhabricator
Create Task
Maniphest T338803

Create the reporting dialog footers
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

The report dialog should have two different footers, depending on which page is currently loaded.

Acceptance criteria:

  • The footers are displayed using codex dialog's footer slot
  • When viewing the information component, the footer has two codex buttons:
    • Proceed to file a report - primary progressive. On clicking, the data collection component and corresponding footer should be loaded.
    • I don't want to file a report - primary default. On clicking, the dialog should close.
  • When viewing the data collection component, the footer has two codex buttons:
    • Submit - On clicking, the dialog should close.
    • Back - primary default. On clicking, the dialog should close.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
three QA fixes to the dialog component: 1. Add the apostrophe to 'don't' in 'I don't want to file a report' message 2. in mobile, add spacing between buttons 3. in mobile, make the width of buttons equalmediawiki/extensions/ReportIncidentmaster+41 -17
Set up a codex dialog that toggles between two screensmediawiki/extensions/ReportIncidentmaster+1 K -22
Customize query in gerrit

Related Objects
Search...

Event Timeline

• JKieserman created this task.Jun 12 2023, 3:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2023, 3:00 PM
• JKieserman added a parent task: T338799: Create a multi-step dialog using the codex dialog component.Jun 12 2023, 3:01 PM
• JKieserman mentioned this in T338800: Create the reporting dialog information component.Jun 12 2023, 3:04 PM
• JKieserman added a subtask: T338804: [S] Inform the user about the success or failure of submitting a report.
• JKieserman mentioned this in T338815: Create the reporting dialog data collection component.Jun 12 2023, 4:06 PM
Aklapper added a project: Incident-Reporting-System.Jun 13 2023, 2:49 PM

Assuming this task is about the Incident-Reporting-System code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching per codebase. Please set appropriate project tags when possible. Thanks! :)

Madalina moved this task from Needs triage to Ready for estimation on the Trust and Safety Tools Team Backlog board.Jun 19 2023, 2:58 PM
MShilova_WMF set the point value for this task to 3.Jun 21 2023, 2:57 PM
MShilova_WMF moved this task from Ready for estimation to Ready for development on the Trust and Safety Tools Team Backlog board.
• JKieserman moved this task from Ready for development to Kanban on the Trust and Safety Tools Team Backlog board.Jul 10 2023, 3:18 PM
• JKieserman edited projects, added Trust and Safety Tools Team Backlog (Kanban); removed Trust and Safety Tools Team Backlog.
• JKieserman claimed this task.Jul 13 2023, 3:00 PM
• JKieserman moved this task from 🎬 Ready to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.
gerritbot added a comment.Jul 13 2023, 3:01 PM

Change 936030 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/ReportIncident@master] Set up a codex dialog that toggles between two screens

https://gerrit.wikimedia.org/r/936030

gerritbot added a project: Patch-For-Review.Jul 13 2023, 3:01 PM
gerritbot added a comment.Jul 13 2023, 5:23 PM

Change 936030 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] Set up a codex dialog that toggles between two screens

https://gerrit.wikimedia.org/r/936030

• JKieserman mentioned this in rEREIc392cab149e7: Set up a codex dialog that toggles between two screens.Jul 13 2023, 5:23 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 13 2023, 5:30 PM
• JKieserman moved this task from 🔍 Review/Feedback to 🤘 Done on the Trust and Safety Tools Team Backlog (Kanban) board.Jul 17 2023, 2:51 PM
• JKieserman moved this task from 🤘 Done to 🐛 QA on the Trust and Safety Tools Team Backlog (Kanban) board.Jul 17 2023, 2:58 PM
Djackson-ctr subscribed.Jul 17 2023, 7:32 PM

Hi @JKieserman;
I discovered 3 minor issues while testing the two dialog pages at https://patchdemo.wmflabs.org/wikis/0a6ae76a64/wiki/User_talk:Patch_Demo.

1st Issue:
When using Mobile View the bottom border line of the I don't want to file a report button is blending into the top border line of the Proceed to File a Report button and need to have more white-space between the 2 buttons.

2nd Issue:
The widths of the buttons are not equal to each other (For example: the button-width for I don't want to file a report is longer than the button-width for Proceed to File a Report).

3rd Issue:
Need to add an apostrophe to the word dont for the dialog page that has the codex button I don't want to file a report.

image.png (945×1 px, 191 KB)
image.png (908×472 px, 162 KB)

Djackson-ctr moved this task from 🐛 QA to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.Jul 17 2023, 7:35 PM
Djackson-ctr updated the task description. (Show Details)Jul 17 2023, 8:21 PM
• JKieserman added a comment.Jul 21 2023, 2:16 PM

Thanks Derek! I've put up a patch that addresses this feedback. One small thing- from what I can tell on the figma, the buttons need to be equal width in mobile but not in desktop, which is what I've done in this patch.

gerritbot added a comment.Jul 24 2023, 3:28 PM

Change 940360 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/ReportIncident@master] three QA fixes to the dialog component: 1. Add the apostrophe to 'don't' in 'I don't want to file a report' message 2. in mobile, add spacing between buttons 3. in mobile, make the width of buttons equal

https://gerrit.wikimedia.org/r/940360

gerritbot added a project: Patch-For-Review.Jul 24 2023, 3:28 PM
gerritbot added a comment.Aug 1 2023, 12:05 AM

Change 940360 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] three QA fixes to the dialog component: 1. Add the apostrophe to 'don't' in 'I don't want to file a report' message 2. in mobile, add spacing between buttons 3. in mobile, make the width of buttons equal

https://gerrit.wikimedia.org/r/940360

Maintenance_bot removed a project: Patch-For-Review.Aug 1 2023, 12:10 AM
• JKieserman mentioned this in rEREIb60400b3c3ea: three QA fixes to the dialog component:.Aug 1 2023, 12:30 AM
• JKieserman moved this task from 🔍 Review/Feedback to 🐛 QA on the Trust and Safety Tools Team Backlog (Kanban) board.Aug 2 2023, 8:41 PM
Djackson-ctr added a comment.Aug 4 2023, 12:18 AM

QA verification has been executed per the Acceptance Criteria, and the 3 issues have been resolved.

Djackson-ctr moved this task from 🐛 QA to 🤘 Done on the Trust and Safety Tools Team Backlog (Kanban) board.Aug 4 2023, 12:19 AM
Madalina closed this task as Resolved.Aug 22 2023, 3:23 PM
Madalina subscribed.

Looks like this is done.

Dreamy_Jazz closed subtask T338804: [S] Inform the user about the success or failure of submitting a report as Resolved.Nov 2 2023, 11:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits