Page MenuHomePhabricator
Create Task
Maniphest T338824

Bitu is not responsive
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Navigate to idm.wikimedia.org on a mobile device

What happens?:

image.png (1×708 px, 52 KB)

What should have happened instead?:

  • All of the page contents are visible
  • Clicking the hamburger menu button on the top right corner does something

Software version (skip for WMF-hosted wikis like Wikipedia): n/a

Other information (browser name/version, screenshots, etc.): Screenshot taken using Firefox 102.11.0esr developer tools, but I can also reproduce using Safari on iOS 16.5.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Implement Codex design, from design team.operations/software/bitumaster+528 -141
Customize query in gerrit

Related Objects
Search...

Event Timeline

taavi created this task.Jun 12 2023, 5:00 PM
Restricted Application added a project: Infrastructure-Foundations. · View Herald TranscriptJun 12 2023, 5:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TheresNoTime renamed this task from Bitu is not responsible to Bitu is not responsive.Jun 12 2023, 10:09 PM
SLyngshede-WMF added a parent task: T320802: Create a mockup and involve designers.Jun 29 2023, 10:05 AM
SLyngshede-WMF changed the task status from Open to In Progress.Sep 29 2023, 11:09 AM
SLyngshede-WMF claimed this task.
SLyngshede-WMF triaged this task as Medium priority.
gerritbot added a comment.Sep 29 2023, 11:09 AM

Change 962003 had a related patch set uploaded (by Slyngshede; author: Slyngshede):

[operations/software/bitu@master] Implement Codex design, from design team.

https://gerrit.wikimedia.org/r/962003

gerritbot added a project: Patch-For-Review.Sep 29 2023, 11:09 AM
gerritbot added a comment.Oct 4 2023, 1:47 PM

Change 962003 merged by Slyngshede:

[operations/software/bitu@master] Implement Codex design, from design team.

https://gerrit.wikimedia.org/r/962003

Maintenance_bot removed a project: Patch-For-Review.Oct 4 2023, 2:11 PM
SLyngshede-WMF added a subscriber: Ladsgroup.Oct 6 2023, 10:14 AM

@taavi / @Ladsgroup Responsive design based on Codex is now live at https://idm-test.wikimedia.org

Feedback is much appreciated :-)

Ladsgroup added a comment.Oct 6 2023, 12:38 PM

Slightly unrelated, the padding in the button is wrong in desktop

image.png (48×323 px, 4 KB)

Otherwise looks good.

SLyngshede-WMF added a comment.Oct 6 2023, 12:40 PM

Wonky... Which browser?

Ladsgroup added a comment.Oct 6 2023, 12:49 PM

firefox

taavi added a comment.Oct 6 2023, 1:07 PM

Why is it loading the styles from and leaking user IPs to a third party CDN?

SLyngshede-WMF added a comment.Oct 9 2023, 7:22 AM

@taavi That is a really good point. Technically that is how the design team suggests using Codex, if you can't use/won't use VueJS. It won't work when we build the Debian package anyway, so I'll just pull in the styling and serve it locally.

I've also raised the CDN issue with the design team and asked that they distribute the CSS version for Codex as a download from our own website for future releases.

The test installation have been updated and now serves the Codex style sheet locally.

SLyngshede-WMF closed this task as Resolved.Nov 6 2023, 9:22 AM

We still have a little feedback from the design team to integrate, but overall Bitu is not responsive.

CSS has been pulled in and is served locally, rather than via a third-party CDN.

SLyngshede-WMF moved this task from Backlog to Resolved on the Bitu board.Apr 11 2024, 10:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits