Page MenuHomePhabricator

Android app doesn't always show all search results
Closed, ResolvedPublic

Description

A search for charlie sava on the app shows one search result while a search on the mobile or desktop show multiple.


Version: 1.0.0 (Android)
Severity: normal

Details

Reference
bz31890

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:50 PM
bzimport set Reference to bz31890.

In the app currently I see two suggestion results:

  • Charlie Savage
  • Charlie Savory

^ that second one goes away if i hit 'space' and then 'backspace'; it doesn't seem to quite update correctly during every typed char.

The equivalent typeahead search on desktop site also gives me one result:

  • Charlie Savage

Of course the desktop site allows you to actually submit the term as a fulltext search, which gives you more results... the Android app doesn't yet support actual search (just search suggestions) so it never gets that far.

philinje wrote:

If this is about adding full-text search, then Yuvi already implemented it. But it also has to be clear that the search mode has changed. Could be for v 1.1 or 1.2.

We have the code for implementing search results (vs suggestions, which is all we do now). Need to figure out a way to properly implement it. I favor just replacing suggestions with actual search results. We'll hash this out soon enough :)

philinje wrote:

As discsussed in the meeting yesterday, the approach will be to use full-text search when the user presses the search icon. In other words, the search suggestions either go away or are not useful, so the user presses search with the search term in the search field. This is equivalent to user interaction on the main site and mobile site.

philinje wrote:

And I think Yuvi implemented this before but it was never used.

Search is now implemented - tapping the 'search' icon actually searches (f295c70fc37077f5cd4d74e53168a04bac0c72c3).

Please open another bug for enhanced search UI if needed :)