Page MenuHomePhabricator
Create Task
Maniphest T338921

Remove VirtualRESTService
Closed, ResolvedPublic
Actions

Description

Introduced in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/110129, see RfC: https://www.mediawiki.org/wiki/Requests_for_comment/PHP_Virtual_REST_Service to address some issues with how to bind with our REST-like service at the time.

It has served its purpose and it's time to phase it out. There has been work replacing this in various extensions. See sub-tasks to follow along.

Acceptance Criteria

  • Hard deprecate in 1.41
  • Remove in 1.42

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
lib/virtualrest: Drop the virtualrest librarymediawiki/coremaster+2 -1 K
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 StalledNoneT324931 Clean up open RESTBase related tickets
 OpenNoneT262315 <CORE TECHNOLOGY> API Migration & RESTBase Sunset
 ResolvedMSantosT264669 Move VE API from RESTBase into core.
 ResolvedJgiannelosT344944 Move Parsoid endpoints out of RESTBase
 ResolvedMSantosT328559 Replace usage of RESTbase parsoid endpoints
 ResolvedDAlangi_WMFT338921 Remove VirtualRESTService
 ResolvedDAlangi_WMFT179680 Hard deprecate VirtualRESTService
 OpenNoneT334842 Replace usage of VirtualRESTServiceClient in Math extension
 Resolved• R_RanaT335347 Introduce a new private method `getMultiHttpClient()` to replace `getServiceClient()`
 Resolved• R_RanaT335348 Investigate callers of `getServiceClient()` and replace them carefully with `getMultiHttpClient()`
 Resolved• R_RanaT335436 Remove the private method `getServiceClient()`
 OpenNoneT349582 Set $wgMathInternalRestbaseURL explictly in production
 Resolved• R_RanaT336735 Replace usage of VirtualRESTServiceClient in Collection extension
 Resolved• R_RanaT337223 Replace usage of VirtualRESTServiceClient in Flow extension
 Resolved• R_RanaT338641 Soft deprecate the VirtualRESTService class
 ResolvedDAlangi_WMFT338643 Replace usage of VirtualRESTService in non-WMF deployed extensions (case: MathSearch)
 ResolvedDAlangi_WMFT339227 Remove VRS code from VisualEditor
 ResolvedDAlangi_WMFT339228 Remove VRS code from ContentTranslation
 Resolved• R_RanaT338922 Introduce maintenance script for warming cache with Parsoid Outputs
 ResolvedYaron_KorenT341131 Replace usage of VRS in non-WMF deployed extensions (case: VEForAll)

Event Timeline

DAlangi_WMF created this task.Jun 13 2023, 8:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 13 2023, 8:11 AM
DAlangi_WMF added a subtask: T179680: Hard deprecate VirtualRESTService.Jun 13 2023, 8:12 AM
DAlangi_WMF updated the task description. (Show Details)
DAlangi_WMF updated the task description. (Show Details)Jun 13 2023, 10:45 AM
DAlangi_WMF changed the status of subtask T338922: Introduce maintenance script for warming cache with Parsoid Outputs from Open to In Progress.Jun 17 2023, 7:19 PM
DAlangi_WMF closed subtask T338922: Introduce maintenance script for warming cache with Parsoid Outputs as Resolved.Jun 28 2023, 12:48 PM
gerritbot added a comment.Jul 12 2023, 8:37 AM

Change 937437 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] [DNM] lib/virtualrest: Drop the virtualrest library (for MW 1.42)

https://gerrit.wikimedia.org/r/937437

gerritbot added a project: Patch-For-Review.Jul 12 2023, 8:37 AM
DAlangi_WMF updated the task description. (Show Details)Jul 12 2023, 10:01 AM
DAlangi_WMF closed subtask T179680: Hard deprecate VirtualRESTService as Resolved.Aug 8 2023, 5:15 PM
DAlangi_WMF updated the task description. (Show Details)
MSantos triaged this task as Low priority.Sep 13 2023, 12:38 PM
• larissagaulia assigned this task to DAlangi_WMF.Oct 4 2023, 12:51 PM
• larissagaulia added a project: MediaWiki-Platform-Team.
• larissagaulia moved this task from Inbox, needs triage to Waiting on the MediaWiki-Platform-Team board.
• larissagaulia moved this task from Waiting to Needs refinement on the MediaWiki-Platform-Team board.Oct 9 2023, 1:40 PM
DAlangi_WMF moved this task from Needs refinement to In progress (DO NOT USE) on the MediaWiki-Platform-Team board.Oct 23 2023, 8:45 AM
gerritbot added a comment.Oct 23 2023, 3:28 PM

Change 937437 merged by jenkins-bot:

[mediawiki/core@master] lib/virtualrest: Drop the virtualrest library

https://gerrit.wikimedia.org/r/937437

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2023, 3:30 PM
DAlangi_WMF closed this task as Resolved.Oct 23 2023, 3:43 PM
DAlangi_WMF updated the task description. (Show Details)

Finally 🎉

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 23 2023, 4:00 PM
hnowlan subscribed.Nov 1 2023, 9:48 AM
Jgiannelos mentioned this in T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.Nov 1 2023, 11:25 AM
Jgiannelos mentioned this in T350219: Page html output on testwiki returns 404.Nov 1 2023, 11:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits