Page MenuHomePhabricator
Create Task
Maniphest T339106

Add overflow control to CPopover component
Closed, ResolvedPublic
Actions

Description

Derived from the QA revision of T335005, the CPopover component used in the new impact module and mentorship lacks overflow control.

Screen Shot 2023-04-18 at 5.26.02 PM.png (1×604 px, 139 KB)

Acceptance criteria

  • Popover content should not overflow viewport in the x-axis
  • ...

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Vue components: avoid viewport overflowmediawiki/extensions/GrowthExperimentsmaster+73 -35
Customize query in gerrit

Related Objects

Event Timeline

Sgs created this task.Jun 14 2023, 11:00 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 14 2023, 11:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sgs attached a referenced file: F36955953: Screen Shot 2023-04-18 at 5.26.02 PM.png. (Show Details)Jun 14 2023, 11:00 AM
Sgs updated the task description. (Show Details)
Sgs mentioned this in T335005: New Impact module empty state - minor improvements.
Sgs claimed this task.Jun 21 2023, 4:43 PM
Sgs moved this task from Inbox to Triaged on the Growth-Team board.
Sgs changed the task status from Open to In Progress.Jun 23 2023, 3:55 PM
Sgs moved this task from Triaged to Sprint 0 (Growth Team) on the Growth-Team board.
Sgs edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Sgs moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jun 23 2023, 3:57 PM

Change 932429 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Vue components: avoid viewport overflow

https://gerrit.wikimedia.org/r/932429

gerritbot added a project: Patch-For-Review.Jun 23 2023, 3:57 PM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 23 2023, 3:57 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 6 2023, 11:42 AM
gerritbot added a comment.Jul 6 2023, 12:08 PM

Change 932429 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Vue components: avoid viewport overflow

https://gerrit.wikimedia.org/r/932429

Maintenance_bot removed a project: Patch-For-Review.Jul 6 2023, 12:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 6 2023, 1:00 PM
Sgs mentioned this in T344483: [wmf.22] mobile - New impact module info tooltips display duplicate titles.Aug 18 2023, 3:34 PM
Sgs moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 21 2023, 2:43 PM

Moving to Test in production since the fix was released long ago.

Sgs added a subscriber: Etonkovidova.Oct 10 2023, 2:01 PM

@Etonkovidova I wrongly skipped your approval on the QA phase but the fix is in production. Can we resolve this task?

Etonkovidova updated the task description. (Show Details)Oct 16 2023, 11:54 PM
Etonkovidova closed this task as Resolved.Oct 17 2023, 4:09 AM
Etonkovidova mentioned this in T349052: [wmf.30] wrapping issue in CPopover component.
In T339106#9238947, @Sgs wrote:

@Etonkovidova I wrongly skipped your approval on the QA phase but the fix is in production. Can we resolve this task?

No problem! Checked on cswiki and eswiki wmf.30 - the issue is fixed:

Screen Shot 2023-10-16 at 4.42.48 PM.png (1×862 px, 196 KB)

The text in some languages (e.g. Spanish, Greek) will overflow the width of the popover - filed as T349052: [wmf.30] wrapping issue in CPopover component

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits