Page MenuHomePhabricator
Create Task
Maniphest T339136

🐐 Make `ItemStatementRetriever` subject agnostic
Closed, ResolvedPublic
Actions

Description

  • Rename the interface from ItemStatementRetriever to StatementRetriever
  • Create a EntityRevisionLookupStatementRetriever class that implements the newly renamed StatementRetriever
    • Move the getStatement() method over from EntityRevisionLookupItemDataRetriever
    • Note: EntityRevisionLookup works for all statement subjects (inc. Items and Properties)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
REST: Make `ItemStatementRetriever` subject agnosticmediawiki/extensions/Wikibasemaster+269 -96
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ollie.Shotton_WMDE created this task.Jun 14 2023, 2:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2023, 2:31 PM
Ollie.Shotton_WMDE removed a project: Story.Jun 14 2023, 2:32 PM
Ollie.Shotton_WMDE claimed this task.Jun 14 2023, 5:30 PM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 31) board.
gerritbot added a comment.Jun 15 2023, 11:23 AM

Change 930566 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Make `ItemStatementRetriever` subject agnostic

https://gerrit.wikimedia.org/r/930566

gerritbot added a project: Patch-For-Review.Jun 15 2023, 11:23 AM
Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 31) board.Jun 15 2023, 11:54 AM
gerritbot added a comment.Jun 16 2023, 12:54 PM

Change 930566 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make `ItemStatementRetriever` subject agnostic

https://gerrit.wikimedia.org/r/930566

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 16 2023, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 16 2023, 1:10 PM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 31) board.Jun 16 2023, 2:09 PM
WMDE-leszek closed this task as Resolved.Jul 11 2023, 7:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits