Page MenuHomePhabricator
Create Task
Maniphest T339140

🐐 Implement the "GET Property Statement" long route
Closed, ResolvedPublic
Actions

Description

  • Add the long route for GETing a property specific statement
    • Create the GetPropertyStatementRouteHandler class with the usual middlewares and error handling,
    • Make sure to handle the new STATEMENT_SUBJECT_NOT_FOUND and INVALID_STATEMENT_SUBJECT_ID use case errors inside the new route handler.
    • Find a smart way to make e2e tests on statements work (short/long routes on item/property statements),

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
REST: Separate GetStatement e2e testsmediawiki/extensions/Wikibasemaster+478 -281
REST: GetPropertyStatementRouteHandler related e2e testsmediawiki/extensions/Wikibasemaster+161 -114
REST: Create GetPropertyStatementRouteHandlermediawiki/extensions/Wikibasemaster+248 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ollie.Shotton_WMDE created this task.Jun 14 2023, 2:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2023, 2:37 PM
• Muhammad_Yasser_Jazirahly_WMDE updated the task description. (Show Details)Jun 20 2023, 3:02 PM
Silvan_WMDE claimed this task.Jun 22 2023, 11:42 AM
Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 31) board.
Silvan_WMDE removed Silvan_WMDE as the assignee of this task.Jun 23 2023, 9:22 AM
Silvan_WMDE moved this task from Doing to To Do on the Wikibase Product Platform (v1) (Sprint 31) board.
Silvan_WMDE subscribed.
• Muhammad_Yasser_Jazirahly_WMDE claimed this task.Jun 23 2023, 9:23 AM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 31) board.
• Muhammad_Yasser_Jazirahly_WMDE removed a subscriber: Ollie.Shotton_WMDE.
• Muhammad_Yasser_Jazirahly_WMDE updated the task description. (Show Details)Jun 23 2023, 2:26 PM
gerritbot added a comment.Jun 23 2023, 2:42 PM

Change 932423 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Create GetPropertyStatementRouteHandler

https://gerrit.wikimedia.org/r/932423

gerritbot added a project: Patch-For-Review.Jun 23 2023, 2:42 PM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 32); removed Wikibase Product Platform (v1) (Sprint 31).Jun 28 2023, 7:55 AM
WMDE-leszek moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 32) board.
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 32) board.Jun 28 2023, 8:12 AM
Silvan_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform (v1) (Sprint 32) board.Jun 30 2023, 9:02 AM
• Muhammad_Yasser_Jazirahly_WMDE added a comment.Jun 30 2023, 2:15 PM

Blocked by T339114

• Muhammad_Yasser_Jazirahly_WMDE changed the task status from Open to Stalled.Jun 30 2023, 2:15 PM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to To Do on the Wikibase Product Platform (v1) (Sprint 32) board.
• Muhammad_Yasser_Jazirahly_WMDE changed the task status from Stalled to Open.Jul 7 2023, 4:13 PM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 32) board.
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 32) board.Jul 7 2023, 4:20 PM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 33); removed Wikibase Product Platform (v1) (Sprint 32).Jul 11 2023, 7:34 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 33) board.
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform (v1) (Sprint 33) board.Jul 12 2023, 9:29 AM
gerritbot added a comment.Jul 12 2023, 12:53 PM

Change 937460 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: GetPropertyStatementRouteHandler related e2e tests

https://gerrit.wikimedia.org/r/937460

• Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 33) board.Jul 12 2023, 3:54 PM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform (v1) (Sprint 33) board.Jul 13 2023, 3:12 PM
gerritbot added a comment.Jul 14 2023, 5:00 PM

Change 938282 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Seperate GetStatement e2e tests

https://gerrit.wikimedia.org/r/938282

• Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 33) board.Jul 14 2023, 5:15 PM
gerritbot added a comment.Jul 17 2023, 2:29 PM

Change 932423 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Create GetPropertyStatementRouteHandler

https://gerrit.wikimedia.org/r/932423

gerritbot added a comment.Jul 17 2023, 2:29 PM

Change 937460 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: GetPropertyStatementRouteHandler related e2e tests

https://gerrit.wikimedia.org/r/937460

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 17 2023, 3:00 PM
Ollie.Shotton_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 33) board.Jul 18 2023, 9:02 AM
gerritbot added a comment.Jul 18 2023, 9:06 AM

Change 938282 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Separate GetStatement e2e tests

https://gerrit.wikimedia.org/r/938282

Maintenance_bot removed a project: Patch-For-Review.Jul 18 2023, 9:10 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 18 2023, 10:00 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Jul 27 2023, 9:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits