Page MenuHomePhabricator
Create Task
Maniphest T339268

[anon prefs] Implement inline script
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

Part of the anonymous preference specification involves creating an inline script that will load values from a storage mechanism and append class names to the HTML element.
Although this has largely been implemented as part of T331681, this task captures the work needed to update that implementation to reflect the decisions made via the TDMP process.

TBD: *link to finalized design & decision record*

TODO

  • Update inline script
  • Update Vector to use new saving mechanism

developer notes

Please consider cached HTML - best for us to read the cookie and transfer to cookie and remove old cookie

QA

Can skip QA. QA will be performed as part of T341641.

Sign off

  • Update docs
  • Mark as risky change in the next deploy

Details

Other Assignee
Jdlrobson
SubjectRepoBranchLines +/-
core - client side preferences inline scriptmediawiki/coremaster+248 -10
ResourceLoader: Simplify clientpref storagemediawiki/coremaster+79 -79
core - client side preferences inline script -- using cookiesmediawiki/coremaster+164 -9
Run a synthetic test for client side preferencesperformance/synthetic-monitoring-testsmaster+38 -1
Revert "Revert "Run a synthetic test for client side preferences""operations/mediawiki-configmaster+6 K -0
Run a synthetic test for client side preferencesoperations/mediawiki-configmaster+6 K -0
Run a synthetic test for client side preferencesoperations/mediawiki-configmaster+7 K -0
Run a synthetic test for client side preferencesperformance/synthetic-monitoring-testsmaster+72 -1
[playground] Run a synthetic test for client side preferencesmediawiki/coremaster+57 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson mentioned this in T316060: [anon prefs] TOC pinned / unpinned status should persist across page views for anonymous users.Jun 15 2023, 5:25 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6).Jun 20 2023, 4:29 PM
Jdlrobson assigned this task to • Mabualruz.Jun 26 2023, 6:19 PM
Jdlrobson subscribed.

I've asked Mo to push a new patch for this, that describes the new approach for storing/reading client side preferences (this should replace the existing proposal in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/883243)

Jdlrobson mentioned this in T339303: TDMP Phase 6 - Submit Decision Record.Jun 26 2023, 6:26 PM
gerritbot added a comment.Jun 27 2023, 4:18 PM

Change 932819 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] [POC] - core - client side preferences

https://gerrit.wikimedia.org/r/932819

gerritbot added a project: Patch-For-Review.Jun 27 2023, 4:18 PM
gerritbot added a comment.Jun 27 2023, 5:01 PM

Change 933499 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] [POC] - Vector - client side preferences

https://gerrit.wikimedia.org/r/933499

LGoto moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jun 29 2023, 5:44 PM
• Mabualruz moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jun 30 2023, 4:17 PM
• Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 4 2023, 1:28 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 5 2023, 4:58 PM
• Mabualruz moved this task from Needs More Work to Blocked on Others on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 7 2023, 12:35 PM
• Mabualruz added a comment.Jul 7 2023, 12:38 PM

blocked by https://phabricator.wikimedia.org/T336527, we need to know if Json.parse and 1 hit on local storage is faster than 10 hits on local storage

gerritbot added a comment.Jul 7 2023, 1:23 PM

Change 935873 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] [playground] Run a synthetic test for client side preferences

https://gerrit.wikimedia.org/r/935873

Jdlrobson moved this task from Blocked on Others to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 10 2023, 6:03 PM
Jdlrobson mentioned this in T336527: Run a synthetic test for client side preferences.Jul 10 2023, 11:58 PM
gerritbot added a comment.Jul 11 2023, 11:53 AM

Change 935873 abandoned by Mabualruz:

[mediawiki/core@master] [playground] Run a synthetic test for client side preferences

Reason:

https://gerrit.wikimedia.org/r/935873

• Mabualruz moved this task from Needs More Work to Blocked on Others on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 11 2023, 11:59 AM
gerritbot added a comment.Jul 11 2023, 1:33 PM

Change 937092 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[operations/mediawiki-config@master] Run a synthetic test for client side preferences

https://gerrit.wikimedia.org/r/937092

gerritbot added a comment.Jul 11 2023, 2:33 PM

Change 936818 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[performance/synthetic-monitoring-tests@master] Run a synthetic test for client side preferences

https://gerrit.wikimedia.org/r/936818

• Mabualruz moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 11 2023, 2:37 PM
Jdlrobson updated Other Assignee, added: Jdlrobson.Jul 11 2023, 4:35 PM
ovasileva added a subtask: T336527: Run a synthetic test for client side preferences.Jul 11 2023, 4:39 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 11 2023, 11:13 PM
Jdlrobson mentioned this in T341641: Migrate Vector's limited width to new client preference API.Jul 11 2023, 11:20 PM
• Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 12 2023, 11:15 AM
Jdlrobson mentioned this in T341720: Create API for client side preference manipulation.Jul 12 2023, 7:33 PM
Jdlrobson claimed this task.Jul 12 2023, 10:02 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.
Jdlrobson added a subscriber: • Mabualruz.

I'll sign off.

Jdlrobson changed the task status from Open to Stalled.Jul 13 2023, 8:23 PM

Blocked on T341641. I've added a note to that ticket to make sure this gets resolved.

tstarling mentioned this in T336713: Diff-type preference: save diff-type user selection as a preference.Jul 14 2023, 6:20 AM
Aklapper added a subtask: T341641: Migrate Vector's limited width to new client preference API.Jul 14 2023, 9:44 AM
gerritbot added a comment.Jul 18 2023, 2:10 PM

Change 936818 abandoned by Mabualruz:

[performance/synthetic-monitoring-tests@master] Run a synthetic test for client side preferences

Reason:

https://gerrit.wikimedia.org/r/936818

gerritbot added a comment.Jul 18 2023, 2:10 PM

Change 937092 abandoned by Mabualruz:

[operations/mediawiki-config@master] Run a synthetic test for client side preferences

Reason:

https://gerrit.wikimedia.org/r/937092

gerritbot added a comment.Jul 18 2023, 2:57 PM

Change 939312 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[operations/mediawiki-config@master] Run a synthetic test for client side preferences

https://gerrit.wikimedia.org/r/939312

gerritbot added a comment.Jul 18 2023, 4:07 PM

Change 939323 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[performance/synthetic-monitoring-tests@master] Run a synthetic test for client side preferences

https://gerrit.wikimedia.org/r/939323

Jdlrobson mentioned this in T342277: Minerva font size setting should use new client side preferences.Jul 19 2023, 4:47 PM
gerritbot added a comment.Jul 24 2023, 1:32 PM

Change 939312 merged by jenkins-bot:

[operations/mediawiki-config@master] Run a synthetic test for client side preferences

https://gerrit.wikimedia.org/r/939312

Stashbot added a comment.Jul 24 2023, 1:33 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-24T13:33:09Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:939312|Run a synthetic test for client side preferences (T336527 T339268)]]

Stashbot added a comment.Jul 24 2023, 1:34 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-24T13:34:36Z] <samtar@deploy1002> samtar and mabualruz: Backport for [[gerrit:939312|Run a synthetic test for client side preferences (T336527 T339268)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Stashbot added a comment.Jul 24 2023, 1:49 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-24T13:49:39Z] <TheresNoTime> [[gerrit:939312]] not synced. T336527 T339268

gerritbot added a comment.Jul 24 2023, 2:06 PM

Change 940912 had a related patch set uploaded (by Samtar; author: Samtar):

[operations/mediawiki-config@master] Revert "Revert "Run a synthetic test for client side preferences""

https://gerrit.wikimedia.org/r/940912

gerritbot added a comment.Jul 24 2023, 2:09 PM

Change 940912 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "Revert "Run a synthetic test for client side preferences""

https://gerrit.wikimedia.org/r/940912

Stashbot added a comment.Jul 24 2023, 2:09 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-24T14:09:24Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:940912|Revert "Revert "Run a synthetic test for client side preferences"" (T336527 T339268)]]

Stashbot added a comment.Jul 24 2023, 2:11 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-24T14:11:03Z] <samtar@deploy1002> samtar: Backport for [[gerrit:940912|Revert "Revert "Run a synthetic test for client side preferences"" (T336527 T339268)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Stashbot added a comment.Jul 24 2023, 2:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-24T14:23:30Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:940912|Revert "Revert "Run a synthetic test for client side preferences"" (T336527 T339268)]] (duration: 14m 05s)

gerritbot added a comment.Jul 25 2023, 3:55 AM

Change 939323 merged by jenkins-bot:

[performance/synthetic-monitoring-tests@master] Run a synthetic test for client side preferences

https://gerrit.wikimedia.org/r/939323

Aklapper added a comment.Jul 31 2023, 8:26 AM

@Jdlrobson: The associated project tag got archived but this task is still open and now has no active project tags. Should this task get resolved? Thanks.

Jdlrobson added a project: MediaWiki-Core-Skin-Architecture.EditedJul 31 2023, 3:45 PM

No. The task is stalled (see T339268#9014119). Added a new tag.

ovasileva changed the task status from Stalled to Open.Jul 31 2023, 5:29 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1).
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Jul 31 2023, 5:36 PM
Jdlrobson moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Jul 31 2023, 5:40 PM
Jdlrobson moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.
alistair3149 subscribed.Jul 31 2023, 5:43 PM
Jdlrobson moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Jul 31 2023, 5:58 PM
gerritbot added a comment.Aug 1 2023, 8:46 AM

Change 942802 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] core - client side preferences inline script -- using cookies

https://gerrit.wikimedia.org/r/942802

gerritbot added a comment.Aug 2 2023, 11:29 AM

Change 942802 abandoned by Mabualruz:

[mediawiki/core@master] core - client side preferences inline script -- using cookies

Reason:

POC migrated changes to 932819

https://gerrit.wikimedia.org/r/942802

• Mabualruz moved this task from Blocked on Others to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 2 2023, 12:04 PM
• Mabualruz claimed this task.Aug 2 2023, 12:07 PM
• Mabualruz updated the task description. (Show Details)
• Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 2 2023, 12:24 PM
• Mabualruz moved this task from Code Review to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 2 2023, 1:48 PM
• Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 3 2023, 11:58 AM
Jdrewniak closed subtask T336527: Run a synthetic test for client side preferences as Resolved.Aug 3 2023, 12:38 PM
Jdlrobson claimed this task.Aug 3 2023, 8:22 PM
Jdlrobson reassigned this task from Jdlrobson to Catrope.Aug 4 2023, 12:12 AM
Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.
Jdlrobson added subscribers: Catrope, Krinkle.

With Mo out I'm taking on finishing up this patch. I met with @Catrope today and agreed on some changes which I've now made (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/932819).

Roan is out on Monday so this is likely to sit here until at least Tuesday.
@Krinkle is also involved in the review process.

gerritbot added a comment.Aug 8 2023, 1:16 AM

Change 932819 merged by jenkins-bot:

[mediawiki/core@master] core - client side preferences inline script

https://gerrit.wikimedia.org/r/932819

Jdlrobson moved this task from Blocked on Others to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 8 2023, 1:25 AM
Jdlrobson removed Catrope as the assignee of this task.Aug 8 2023, 6:05 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.
Jdlrobson added a comment.Aug 8 2023, 6:21 PM

The new method has been documented on https://www.mediawiki.org/wiki/ResourceLoader/Core_modules#mw.user.clientPrefs

Jdlrobson updated the task description. (Show Details)Aug 8 2023, 6:33 PM
gerritbot added a comment.Aug 9 2023, 8:10 PM

Change 946614 had a related patch set uploaded (by Krinkle; author: Mabualruz):

[mediawiki/core@master] ResourceLoader: Simplify clientpref storage

https://gerrit.wikimedia.org/r/946614

gerritbot added a comment.Aug 9 2023, 8:10 PM

Change 947428 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Add unit test for clientprefs

https://gerrit.wikimedia.org/r/947428

gerritbot added a comment.Aug 9 2023, 10:46 PM

Change 947480 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Document the clientPrefs system and make Skin option

https://gerrit.wikimedia.org/r/947480

Jdlrobson claimed this task.Aug 10 2023, 4:35 PM
Jdlrobson moved this task from Ready for Signoff to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.
gerritbot added a comment.Aug 11 2023, 6:00 PM

Change 946614 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Simplify clientpref storage

https://gerrit.wikimedia.org/r/946614

Jdlrobson mentioned this in T344069: Merge follow up work to client preferences.Aug 11 2023, 6:32 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.
Jdlrobson closed this task as Resolved.Aug 11 2023, 6:34 PM
Jdlrobson updated the task description. (Show Details)

I've marked this as a risky change for next deploy: T343724#9087299 (cc @Jdrewniak

After talking to @Catrope we agreed to postpone several of the follow up changes from @Krinkle to the next deploy to make reverting easier. This is tracked in T344069. All code there is ready to be merged minus some rebasing.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 11 2023, 7:00 PM
Mhurd closed subtask T341641: Migrate Vector's limited width to new client preference API as Resolved.Aug 18 2023, 6:42 AM
Restricted Repository Identity mentioned this in rPSMT25a23436ab0a: Run a synthetic test for client side preferences.Apr 8 2024, 3:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits