Page MenuHomePhabricator

Deploy to beta cluster
Closed, ResolvedPublic2 Estimated Story Points

Description

Steps outlined here: https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment#Deploy_to_Beta_Cluster

  • Add the new extension submodule to the git mediawiki/extensions repo if it's not already in it. See example. This will result in the code being deployed (unused) to the Beta Cluster.
  • Move your extension's CI config to the "Wikimedia production" section, add the "in-wikimedia-production" job template, and make sure it has and passes all the expected jobs for production code. (MR)
  • Add your extension to the json make-wmf-branch release tool at least two weeks prior to your target date for enabling on the Beta Cluster. It will add the extension as a submodule of mediawiki/core when the weekly deploy branch is cut, and the code will be deployed (unused) to production
  • Add your extension to extension-list. This requires that the code be present on every branch running in production, since extension-list is used to build the CDB database for i18n files in both Beta and production. (patch)
  • Add your extension config variable to InitialiseSettings.php and set it to be default false. See example. (patch)
  • Add your extension config variable (same as in previous step) to InitialiseSettings-labs.php and set it to be true on Beta Cluster wikis you want it to be on. You may want to turn it off for loginwiki (which doesn't have most extensions). (patch)
  • Load your extension in CommonSettings-labs.php (patch)

We will initially enable only on kowiki for beta cluster.

Acceptance criteria:

Event Timeline

In the interim, we can use https://patchdemo.wmflabs.org to test ReportIncident in the main branch, or for a patch, by selecting "Custom" and checking the box for "ReportIncident".

@Madalina I think it would make sense to pick a single beta wiki to deploy to for now, for QA purposes. Do you have any idea about which beta wiki you'd like that to be? (Probably not enwiki yet, as that is most commonly used.)

Madalina set the point value for this task to 2.Aug 30 2023, 1:25 PM

Change 953998 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] Add ReportIncident extension

https://gerrit.wikimedia.org/r/953998

Change 953999 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] ReportIncident: Default deployment to false

https://gerrit.wikimedia.org/r/953999

@kostajh maybe we do one of our possible pilots beta wiki? kowiki?

Change 955732 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] [beta] ReportIncident: Enable on kowiki beta

https://gerrit.wikimedia.org/r/955732

Change 955735 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] [beta] Enable ReportIncident for configured beta wikis

https://gerrit.wikimedia.org/r/955735

Change 953998 merged by jenkins-bot:

[operations/mediawiki-config@master] Add ReportIncident extension

https://gerrit.wikimedia.org/r/953998

Mentioned in SAL (#wikimedia-operations) [2023-09-11T07:11:17Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:953998|Add ReportIncident extension (T339275)]]

Mentioned in SAL (#wikimedia-operations) [2023-09-11T07:23:57Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:953998|Add ReportIncident extension (T339275)]]

Mentioned in SAL (#wikimedia-operations) [2023-09-11T07:33:35Z] <kharlan@deploy1002> kharlan: Backport for [[gerrit:953998|Add ReportIncident extension (T339275)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-09-11T07:46:41Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:953998|Add ReportIncident extension (T339275)]] (duration: 22m 44s)

Change 953999 merged by jenkins-bot:

[operations/mediawiki-config@master] ReportIncident: Default deployment to false

https://gerrit.wikimedia.org/r/953999

Mentioned in SAL (#wikimedia-operations) [2023-09-11T07:49:08Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:953999|ReportIncident: Default deployment to false (T339275)]]

Mentioned in SAL (#wikimedia-operations) [2023-09-11T07:50:43Z] <kharlan@deploy1002> kharlan: Backport for [[gerrit:953999|ReportIncident: Default deployment to false (T339275)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-09-11T08:00:28Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:953999|ReportIncident: Default deployment to false (T339275)]] (duration: 11m 15s)

Change 955732 merged by jenkins-bot:

[operations/mediawiki-config@master] [beta] ReportIncident: Enable on kowiki beta

https://gerrit.wikimedia.org/r/955732

Change 955735 merged by jenkins-bot:

[operations/mediawiki-config@master] [beta] Enable ReportIncident for configured beta wikis

https://gerrit.wikimedia.org/r/955735

Mentioned in SAL (#wikimedia-operations) [2023-09-11T08:03:46Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:955732|[beta] ReportIncident: Enable on kowiki beta (T339275)]], [[gerrit:955735|[beta] Enable ReportIncident for configured beta wikis (T339275)]], [[gerrit:955821|ReportIncident: Set default help page (T343382)]]

Mentioned in SAL (#wikimedia-operations) [2023-09-11T08:05:15Z] <kharlan@deploy1002> kharlan: Backport for [[gerrit:955732|[beta] ReportIncident: Enable on kowiki beta (T339275)]], [[gerrit:955735|[beta] Enable ReportIncident for configured beta wikis (T339275)]], [[gerrit:955821|ReportIncident: Set default help page (T343382)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, and mw-debug kubernetes deplo

Mentioned in SAL (#wikimedia-operations) [2023-09-11T08:13:31Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:955732|[beta] ReportIncident: Enable on kowiki beta (T339275)]], [[gerrit:955735|[beta] Enable ReportIncident for configured beta wikis (T339275)]], [[gerrit:955821|ReportIncident: Set default help page (T343382)]] (duration: 09m 44s)

I've deployed patches (linked in the task description) that:

  • disable ReportIncident everywhere by default
  • enable ReportIncident only for kowiki on beta cluster
  • set Wikipedia:Administrators as the default title for the help text in step one of the form

You can see the "Report" button in action on https://ko.wikipedia.beta.wmflabs.org/wiki/%EC%82%AC%EC%9A%A9%EC%9E%90%ED%86%A0%EB%A1%A0:Bluedot?uselang=en. Note the uselang=en parameter, the button doesn't appear otherwise. We'll be reworking the entrypoint for the form in T339247: [Sub-epic] Create entry points for the Incident Report dialog with DiscussionTools and T341261: Add report menu item to Minerva and Vector 2022 tools.

@Madalina I think this task is done, and I created T346018: Deploy to all beta wikis for when we're ready to enable on English beta wiki.

kostajh updated the task description. (Show Details)

I have verified this ticket meets the Acceptance Criteria listed in the ticket Description, and therefore is functioning as expected.

image.png (860×413 px, 206 KB)
image.png (860×1 px, 231 KB)
image.png (861×1 px, 267 KB)

It looks like several steps on https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment were ignored. For example, I cannot find an entry on https://www.mediawiki.org/wiki/Developers/Maintainers and no on-wiki documentation (T345330).

It looks like several steps on https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment were ignored. For example, I cannot find an entry on https://www.mediawiki.org/wiki/Developers/Maintainers and no on-wiki documentation (T345330).

Thanks for raising this, @Aklapper. I'll review these steps and make sure we handle the missing ones. We had a few missteps here with a departing tech lead, and a naming collision with an existing extension (not on Gerrit, only on GitHub), which contributed to the situation.

It looks like several steps on https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment were ignored. For example, I cannot find an entry on https://www.mediawiki.org/wiki/Developers/Maintainers and no on-wiki documentation (T345330).

Thanks for raising this, @Aklapper. I'll review these steps and make sure we handle the missing ones. We had a few missteps here with a departing tech lead, and a naming collision with an existing extension (not on Gerrit, only on GitHub), which contributed to the situation.

As for deploying to beta before filing the production deployment task and obtaining security review, I asked RelEng about it and got confirmation to proceed, and I also asked Security team, who said it was OK with them.

When we are closer to deploying to testwiki, we will file the production deployment task, request security team review, etc.

kostajh updated the task description. (Show Details)

@Madalina can you create a Google Group for e.g. incident-report-system-beta@wikimedia.org that we can add emails to, and then we can set this as the address for ReportIncident on beta?

Request has been filed this week, we're waiting for IT to create the group.

Email has been created, we can now use: incident-report-system-beta@wikimedia.org.

Change 962028 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] [betacluster] ReportIncident: Set up email recipients

https://gerrit.wikimedia.org/r/962028

Change 962028 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] [betacluster] ReportIncident: Set up email recipients

https://gerrit.wikimedia.org/r/962028

Change 962028 merged by jenkins-bot:

[operations/mediawiki-config@master] [betacluster] ReportIncident: Set up email recipients

https://gerrit.wikimedia.org/r/962028

Change 962623 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Define wgReportIncidentEmailFromAddress on beta wikis

https://gerrit.wikimedia.org/r/962623

Change 962623 merged by jenkins-bot:

[operations/mediawiki-config@master] Define wgReportIncidentEmailFromAddress on beta wikis

https://gerrit.wikimedia.org/r/962623