Page MenuHomePhabricator
Create Task
Maniphest T339323

Make use of ES6 in WMDE-TechWish projects
Closed, ResolvedPublic
Actions

Description

The support for ES5 only browsers has been dropped with T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015) we can upgrade the code used in our projects to ES6,

This can mainly be done by bumping the eslint rule set applied on the source from wikimedia/client-es5 to wikimedia/client-es6 in the .eslintrc.json file. Then the linters can run with autofixes.
It's also advisable to bump the core requirement in the extensions.json to at least "MediaWiki": ">= 1.41.0" if the code changes are user facing.

Optional bonus (because we're invested in these extensions):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Port jsduck -> jsdocmediawiki/extensions/Kartographermaster+601 -45
Convert wikivoyage module(s) to ES6mediawiki/extensions/Kartographermaster+66 -61
Convert ve-maps module(s) to ES6mediawiki/extensions/Kartographermaster+138 -139
Convert TwoColConflict extension to ES6mediawiki/extensions/TwoColConflictmaster+101 -101
ES6 conversion of Move-Files-To-Commons -> FileImporter Extensionmediawiki/extensions/FileImportermaster+3 -3
ES6 conversion of Move-Files-To-Commons -> FileExporter Extensionmediawiki/extensions/FileExportermaster+2 -2
Migrate JS to ES6mediawiki/extensions/RevisionSlidermaster+724 -710
Basic ES6 conversionmediawiki/extensions/AdvancedSearchmaster+351 -361
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Jun 16 2023, 6:22 AM
WMDE-Fisch moved this task from Backlog to Watching / Epic on the WMDE-TechWish-Maintenance-2023 board.
gerritbot added a comment.Jun 20 2023, 2:49 PM

Change 930759 had a related patch set uploaded (by WMDE-Fisch; author: Awight):

[mediawiki/extensions/AdvancedSearch@master] Basic ES6 conversion

https://gerrit.wikimedia.org/r/930759

gerritbot added a project: Patch-For-Review.Jun 20 2023, 2:49 PM
gerritbot added a comment.Jun 20 2023, 3:14 PM

Change 930759 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Basic ES6 conversion

https://gerrit.wikimedia.org/r/930759

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2023, 3:30 PM
gerritbot added a comment.Jun 22 2023, 9:43 AM

Change 932186 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/RevisionSlider@master] Migrate JS to ES6

https://gerrit.wikimedia.org/r/932186

gerritbot added a project: Patch-For-Review.Jun 22 2023, 9:43 AM
awight updated the task description. (Show Details)Jun 22 2023, 9:44 AM
gerritbot added a comment.Jun 23 2023, 10:01 AM

Change 932186 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Migrate JS to ES6

https://gerrit.wikimedia.org/r/932186

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2023, 10:10 AM
gerritbot added a comment.Jul 11 2023, 9:30 AM

Change 937053 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/TwoColConflict@master] Convert TwoColConflict extension to ES6

https://gerrit.wikimedia.org/r/937053

gerritbot added a project: Patch-For-Review.Jul 11 2023, 9:30 AM
gerritbot added a comment.Jul 13 2023, 11:43 AM

Change 937936 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/FileExporter@master] ES6 conversion of Move-Files-To-Commons -> FileExporter Extension

https://gerrit.wikimedia.org/r/937936

gerritbot added a comment.Jul 13 2023, 12:08 PM

Change 937940 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/FileImporter@master] ES6 conversion of Move-Files-To-Commons -> FileImporter Extension

https://gerrit.wikimedia.org/r/937940

MareikeHeuerWMDE claimed this task.Jul 13 2023, 12:40 PM
MareikeHeuerWMDE moved this task from Watching / Epic to Doing on the WMDE-TechWish-Maintenance-2023 board.
gerritbot added a comment.Jul 14 2023, 7:04 AM

Change 937936 merged by jenkins-bot:

[mediawiki/extensions/FileExporter@master] ES6 conversion of Move-Files-To-Commons -> FileExporter Extension

https://gerrit.wikimedia.org/r/937936

gerritbot added a comment.Jul 14 2023, 7:07 AM

Change 937940 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] ES6 conversion of Move-Files-To-Commons -> FileImporter Extension

https://gerrit.wikimedia.org/r/937940

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 14 2023, 8:01 AM
WMDE-Fisch moved this task from Doing to Review on the WMDE-TechWish-Maintenance-2023 board.Jul 14 2023, 8:17 AM
MareikeHeuerWMDE mentioned this in rEFILEEXPORT309e7bd471f4: ES6 conversion of Move-Files-To-Commons -> FileExporter Extension.Jul 14 2023, 8:19 AM
WMDE-Fisch updated the task description. (Show Details)Jul 14 2023, 8:31 AM
WMDE-Fisch moved this task from Review to Doing on the WMDE-TechWish-Maintenance-2023 board.Jul 18 2023, 8:22 AM
gerritbot added a comment.Jul 18 2023, 1:08 PM

Change 937053 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Convert TwoColConflict extension to ES6

https://gerrit.wikimedia.org/r/937053

Maintenance_bot removed a project: Patch-For-Review.Jul 18 2023, 1:10 PM
MareikeHeuerWMDE mentioned this in rESCCeaef2056139e: Convert TwoColConflict extension to ES6.Jul 18 2023, 1:11 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 18 2023, 2:00 PM
gerritbot added a comment.Jul 20 2023, 3:17 PM

Change 940185 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/Kartographer@master] Convert Maps(Kartographer) extension to ES6

https://gerrit.wikimedia.org/r/940185

gerritbot added a project: Patch-For-Review.Jul 20 2023, 3:17 PM
MareikeHeuerWMDE updated the task description. (Show Details)Jul 21 2023, 11:58 AM
gerritbot added a comment.Jul 27 2023, 11:03 AM

Change 942390 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Convert wikivoyage module(s) to ES6

https://gerrit.wikimedia.org/r/942390

gerritbot added a comment.Jul 27 2023, 11:05 AM

Change 942391 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Convert ve-maps module(s) to ES6

https://gerrit.wikimedia.org/r/942391

thiemowmde added a subtask: T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.Jul 27 2023, 12:36 PM
thiemowmde moved this task from Doing to Done on the WMDE-TechWish-Maintenance-2023 board.EditedJul 27 2023, 12:40 PM
thiemowmde added subscribers: thiemowmde, MareikeHeuerWMDE.

I think this is simply blocked on T138401. JSDuck apparently just can't understand ES6 (see https://github.com/senchalabs/jsduck/issues/630, which appears to be a significant part of the reason we want to get rid of it), and crashes instead.

Since we said Maps (Kartographer) is optional I suggest to move this to done and work on the JSDuck update via a separate subtask: T342864.

gerritbot added a comment.Jul 27 2023, 12:40 PM

Change 942391 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] Convert ve-maps module(s) to ES6

Reason:

See T339323#9047757.

https://gerrit.wikimedia.org/r/942391

gerritbot added a comment.Jul 27 2023, 12:40 PM

Change 942390 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] Convert wikivoyage module(s) to ES6

Reason:

See T339323#9047757.

https://gerrit.wikimedia.org/r/942390

thiemowmde edited subtasks, added: T342864: Replace jsduck with JSDoc3 in Kartographer; removed: T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.Jul 27 2023, 12:48 PM
gerritbot added a comment.Jul 27 2023, 12:55 PM

Change 942004 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Revert "Revert "Port jsduck -> jsdoc""

https://gerrit.wikimedia.org/r/942004

MareikeHeuerWMDE closed this task as Resolved.Aug 1 2023, 2:58 PM
MareikeHeuerWMDE updated the task description. (Show Details)
WMDE-Fisch updated the task description. (Show Details)Aug 7 2023, 10:12 AM
WMDE-Fisch removed a subtask: T342864: Replace jsduck with JSDoc3 in Kartographer.
gerritbot added a comment.Aug 15 2023, 4:58 AM

Change 942004 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Port jsduck -> jsdoc

https://gerrit.wikimedia.org/r/942004

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits