Page MenuHomePhabricator
Create Task
Maniphest T339352

Create MySQL container in CI for integration tests
Closed, ResolvedPublic
Actions

Description

Following up from T308789: Determine CI best practices for service which connects to MySQL and T337714: Migrate mediawiki/services/ipoid to GitLab, in this task we'll add support for starting a MySQL container using the services config in GitLab CI. We can then make use of that for integration tests for iPoid.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
common/gitlab_runner: Allow mariadb:* images for allowed_docker_servicesoperations/puppetproduction+3 -0
gitlab runner: Allow mariadb:* imagesoperations/puppetproduction+2 -0
gitlab runner: Allow mariadb:* images for allowed_docker_servicesoperations/puppetproduction+2 -0
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Jun 16 2023, 11:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2023, 11:38 AM
kostajh changed the task status from Open to In Progress.Jun 16 2023, 12:27 PM
CodeReviewBot added a comment.Jun 16 2023, 12:33 PM

kharlan opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/12

gitlab: Add mariadb services

CodeReviewBot added a project: Patch-For-Review.Jun 16 2023, 12:33 PM
kostajh mentioned this in T238925: MySQL/MariaDB images for development environments.Jun 16 2023, 3:28 PM
kostajh mentioned this in T339846: Write integration tests for data import and updates.Jun 19 2023, 10:33 AM
Tchanders added a project: Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap).Jun 20 2023, 5:49 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap) board.Jun 21 2023, 11:55 AM
Tchanders moved this task from Code Review 🔍 to Blocked/Stalled 🚧 on the Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap) board.Jun 21 2023, 12:37 PM
gerritbot added a comment.Jun 22 2023, 8:21 PM

Change 932328 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/puppet@production] gitlab runner: Allow mariadb:* images

https://gerrit.wikimedia.org/r/932328

gerritbot added a comment.Jun 23 2023, 1:12 PM

Change 932328 merged by Jelto:

[operations/puppet@production] gitlab runner: Allow mariadb:* images

https://gerrit.wikimedia.org/r/932328

gerritbot added a comment.Jun 26 2023, 7:05 PM

Change 933175 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/puppet@production] gitlab runner: Allow mariadb:* images for allowed_docker_services

https://gerrit.wikimedia.org/r/933175

gerritbot added a comment.Jun 29 2023, 4:49 PM

Change 933175 merged by RLazarus:

[operations/puppet@production] gitlab runner: Allow mariadb:* images for allowed_docker_services

https://gerrit.wikimedia.org/r/933175

CodeReviewBot added a comment.Jul 3 2023, 8:03 PM

tchanders merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/12

gitlab: Add mariadb services

Maintenance_bot removed a project: Patch-For-Review.Jul 3 2023, 8:10 PM
kostajh moved this task from Backlog to Done on the iPoid-Service board.Jul 4 2023, 8:27 AM
kostajh added subscribers: Jelto, dancy.Jul 5 2023, 10:08 AM

Not sure why, in https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/jobs/115413 I see permission errors again, after merging this MR. cc @dancy @Jelto

kostajh added a comment.Jul 5 2023, 10:14 AM
In T339352#8990023, @kostajh wrote:

Not sure why, in https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/jobs/115413 I see permission errors again, after merging this MR. cc @dancy @Jelto

I guess it is happening because we don't allow the image in https://gerrit.wikimedia.org/g/operations/puppet/+/b2259957d3aea5d12bcfc56b90f401e9d336b62e/hieradata/role/common/gitlab_runner.yaml#96.

gerritbot added a comment.Jul 5 2023, 10:17 AM

Change 935703 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/puppet@production] common/gitlab_runner: Allow mariadb:* images for allowed_docker_services

https://gerrit.wikimedia.org/r/935703

gerritbot added a project: Patch-For-Review.Jul 5 2023, 10:17 AM
CodeReviewBot added a comment.Jul 5 2023, 10:24 AM

kharlan opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/23

Revert "gitlab: Add mariadb services"

CodeReviewBot added a comment.Jul 5 2023, 10:25 AM

kharlan merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/23

Revert "gitlab: Add mariadb services"

CodeReviewBot added a comment.Jul 6 2023, 11:26 AM

kharlan opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/26

docker: Specify MariaDB 10.4

gerritbot added a comment.Jul 6 2023, 12:33 PM

Change 935703 abandoned by Kosta Harlan:

[operations/puppet@production] common/gitlab_runner: Allow mariadb:* images for allowed_docker_services

Reason:

https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/26

https://gerrit.wikimedia.org/r/935703

CodeReviewBot added a comment.Jul 7 2023, 1:39 AM

stran merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/26

gitlab-ci: Add mariadb in services for test stage

Maintenance_bot removed a project: Patch-For-Review.Jul 7 2023, 2:10 AM
kostajh moved this task from Blocked/Stalled 🚧 to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap) board.Aug 23 2023, 10:23 AM
In T339352#8996305, @CodeReviewBot wrote:

stran merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/26

gitlab-ci: Add mariadb in services for test stage

I believe this is done with the merge request above. In CI, tests can access a MariaDB instance with the username root and no password.

CodeReviewBot added a project: Patch-For-Review.Aug 23 2023, 10:31 AM

kharlan opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/44

Draft: [WIP] Run init-db in CI tests

kostajh mentioned this in T344818: Allow GitLab CI containers to connect to services.Aug 23 2023, 12:52 PM
kostajh moved this task from QA/Testing 🐞 to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap) board.Aug 28 2023, 8:02 PM
kostajh added subscribers: STran, Tchanders.
In T339352#9112899, @CodeReviewBot wrote:

kharlan opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/44

Draft: [WIP] Run init-db in CI tests

This is ready for review now, cc @STran @Tchanders

CodeReviewBot added a comment.Aug 31 2023, 6:16 PM

stran merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/44

gitlab: Build image to connect to mariadb service

Maintenance_bot removed a project: Patch-For-Review.Aug 31 2023, 6:30 PM
Tchanders moved this task from Code Review 🔍 to Done Q1 2023-2024 on the Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap) board.Sep 6 2023, 4:22 PM
kostajh closed this task as Resolved.Nov 10 2023, 10:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits