| • bzimport | |
| Oct 25 2011, 12:56 PM |
| F8189: inherited.patch | |
| Nov 21 2014, 11:53 PM |
Author: cillimonber
Description:
Add wg variable to inherit group permissions, i. e. follow code:
$wgInheritGroupPermissions['sysop'] = array('editor');
And in Special:ListGroupRights MediaWiki displays simple "Inherit user rights of groups: Editors" instead of duplicate rights of "editor" group.
Version: unspecified
Severity: enhancement
This is something that could ideally do with some unittests. Would you be able to write some for this cryptocoryne?
And I don't think it should be committed before 1.19 is branched, as it has the potential to have numerous unwanted side effects
Oh, also!
'listgrouprights-inherited' needs to be added to messages.inc and it'd be nice to have qqq documentation for it also
A quick browse over the patch suggests it's reasonably sane
John: Would you be able to write unittests?
Also, you are welcome to use Developer access
https://www.mediawiki.org/wiki/Developer_access
to submit an updated patch as a Git branch directly into Gerrit:
https://www.mediawiki.org/wiki/Git/Tutorial
Putting your branch in Git makes it easier to review it quickly.
If I understand this request correctly, this is something that has already been done. Group's permissions can be inherited by assigning
$wgGroupPermissions['sysop']= $wgGroupPermissions['editor']
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/710134/ introduced $wgGroupInheritsPermissions, though Special:ListGroupRights does not display such information (it only displays all rights a group has). Should this task continue to be open for this part?