Page MenuHomePhabricator

QA IP masking feature in Web team products
Closed, ResolvedPublic0 Estimated Story Points


Once the work on IP masking is complete, we'd like to QA the feature. For QA purposes we'll need to setup an instance of MediaWIki with IP masking enabled making sure Vector 2022 is the default skin.

QA steps

  • To become an IP masked user, first edit a page anonymously and save.

Check the tasks implemented last sprint are fixed per spec

  1. Perform exploratory testing. Do any features shown not work.

Sign off

  • Track follow up work.
  • Close T335440 if necessary.

QA Results - Patch demo

Event Timeline

Jdlrobson added a subscriber: Edtadros.

Hi @Edtadros this should be ready to QA on the following URL:

Goal here is to document any issues on the tasks we've done e.g. misalignment with the specification in addition to new problems we may have missed.

Test Result - Beta (Patchdemo)

Status: ✅ PASS
Environment: Patchdemo
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

To become an IP masked user, first edit a page ( anonymously and save.
Check the tasks implemented last sprint are fixed per spec

❓ AC1: T330510 IP masking: Make temporary account status and create account actions more prominent via a separate temp account status bar
Create a status bar at the top of the page content clearly indicating the temp account status, with clear call-to-actions to Create account or Log in.
Same for Desktop and Mobile

Screenshot 2023-06-20 at 4.30.57 PM.png (825×391 px, 45 KB)
Screenshot 2023-06-20 at 4.30.31 PM.png (895×1 px, 135 KB)

In mobile, the text on the button is cut off. I'm not sure if styling is in scope. What seems to be in scope based on the original task is the information icon/popup. That is missing here.

❓ AC2: T339379 Follow up work: Iterate on IP masking banner
See screenshots above. The solutions in this task are meant to fix the issues in AC1, but I'm not seeing the fix. Additionally, the behavior of the popup icon isn't clear.

✅ AC3: T330517 IP masking: IP masked users cannot disable page previews
Become an IP masked user (see T326911)
Hover over a page preview
Click the settings cog
What happens?:
We should store the preference like we do for anonymous users.

Screen Recording 2023-06-20 at 4.33.03 (928×1 px, 383 KB)
Screen Recording 2023-06-20 at 4.32.37 (928×1 px, 472 KB)

❌ AC4: T330518 [IP masking] The watchstar shows in the Minerva skin
Visit any article page
Click watchstar
It should trigger the login workflow (Drawer) when clicked.
The login drawer doesn't appear. Additionally when watching/unwatching, the state of the watchstar doesn't change unless you reload the page.

Screen Recording 2023-06-20 at 4.38.54 (822×390 px, 226 KB)
Screen Recording 2023-06-20 at 4.42.23 (922×1 px, 844 KB)
Screen Recording 2023-06-20 at 4.41.52 (922×1 px, 725 KB)

❓ AC5: T335546 IP masking: Temp account user menu options

These look good

Screenshot 2023-06-20 at 4.50.48 PM.png (903×1 px, 149 KB)

Screenshot 2023-06-20 at 4.51.49 PM.png (631×1 px, 129 KB)

The user menu item looks like a clickable menu item so you expect it to go somewhere, but it doesn't

Screenshot 2023-06-20 at 4.54.15 PM.png (667×1 px, 89 KB)

Are these correct?

Screenshot 2023-06-20 at 4.54.44 PM.png (731×1 px, 72 KB)

Screenshot 2023-06-20 at 4.54.25 PM.png (722×1 px, 82 KB)

❌ AC6: Perform exploratory testing. Do any features shown not work.
When in mobile view and you make a change to settings, a drawer notifies the user that the settings have been saved, but they do not appear to be saved.

Screen Recording 2023-06-20 at 4.47.06 (922×1 px, 531 KB)

Edtadros updated the task description. (Show Details)

@Jdlrobson Please see some of the questions/issues above (T339380#8951475) and let me know if you have any questions.

AC1 and AC2 is blocked for T339379
AC4: Can replicate. I've reopened T330518.
AC5: This can be called a pass for now. Seems to be working per spec but i'll let @RHo weigh in if we need to follow up.
AC6 : I've opened T339994

Let's move this to sign off and QA on the other tickets after we hear back about AC5.

Hi there, regarding AC5, the user menu option showing up but not clickable, I believe this is because we never made a firm decision yet on whether to show the Username in the personal tools or not in T335546#8883050.
@Jdlrobson - it sounds like from Growth's perspective the username should be not shown at all as a link to avoid people, then it should definitely not show in either the personal tools as a link, nor as an option in the menu dropdown.

Incidentally, not sure if I understand AC6 correctly, but the expectation is that the mobile side menu should look like a logged out user's, so there should no access to Preferences or enabling Advanced mode at all.

I've opened T340152 for AC5. The other issues are reflected in other tickets on the board. Thanks @Edtadros !