Page MenuHomePhabricator

Hard-deprecate PageArchive::listRevisions/getRevisionRecordByTimestamp/getArchivedRevisionRecord/getPreviousRevisionRecord/getLastRevisionId/isDeleted/undeleteAsUser/getFileStatus/getRevisionStatus (and remove in 1.44)
Closed, ResolvedPublic

Description

The following functions are deprecated and should be replaced

  • PageArchive::listRevisions
  • PageArchive::getRevisionRecordByTimestamp
  • PageArchive::getArchivedRevisionRecord
  • PageArchive::getPreviousRevisionRecord
  • PageArchive::getLastRevisionId
  • PageArchive::isDeleted
  • PageArchive::undeleteAsUser
  • PageArchive::getFileStatus
  • PageArchive::getRevisionStatus

After that the function should be hard-deprecated and removed

CodeSearch: https://codesearch.wmcloud.org/search/?q=-%3E%5Cs*%28listRevisions%7CgetRevisionRecordByTimestamp%7CgetArchivedRevisionRecord%7CgetPreviousRevisionRecord%7CgetLastRevisionId%7CundeleteAsUser%7CgetFileStatus%7CgetRevisionStatus%29%5Cs*%5C%28&files=&excludeFiles=&repos=
(search without isDeleted, gives many false positives)

Event Timeline

Change 930879 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CirrusSearch@master] Replace deprecated PageArchive::getPreviousRevisionRecord/listRevisions

https://gerrit.wikimedia.org/r/930879

Change 930881 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] page: Replace deprecated PageArchive::getArchivedRevisionRecord

https://gerrit.wikimedia.org/r/930881

Change 930881 merged by jenkins-bot:

[mediawiki/core@master] page: Replace deprecated PageArchive::getArchivedRevisionRecord

https://gerrit.wikimedia.org/r/930881

Change 930879 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Replace deprecated PageArchive::getPreviousRevisionRecord/listRevisions

https://gerrit.wikimedia.org/r/930879

Change #1055564 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Cognate@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055564

Change #1055566 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CreatedPagesList@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055566

Change #1055567 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PhpTagsStorage@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055567

Change #1055569 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] maintenance: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055569

Change #1055567 merged by Umherirrender:

[mediawiki/extensions/PhpTagsStorage@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055567

Change #1055566 merged by Umherirrender:

[mediawiki/extensions/CreatedPagesList@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055566

Change #1055571 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] page: Hard-deprecate PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055571

Change #1055564 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055564

Change #1055569 merged by jenkins-bot:

[mediawiki/core@master] maintenance: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055569

Change #1055571 merged by jenkins-bot:

[mediawiki/core@master] page: Hard-deprecate PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055571

Umherirrender renamed this task from Hard-deprecate PageArchive::listRevisions/getRevisionRecordByTimestamp/getArchivedRevisionRecord/getPreviousRevisionRecord/getLastRevisionId/isDeleted/undeleteAsUser/getFileStatus/getRevisionStatus (and remove a release later) to Hard-deprecate PageArchive::listRevisions/getRevisionRecordByTimestamp/getArchivedRevisionRecord/getPreviousRevisionRecord/getLastRevisionId/isDeleted/undeleteAsUser/getFileStatus/getRevisionStatus (and remove in 1.44).Jul 26 2024, 8:33 PM
Umherirrender changed the task status from Open to Stalled.
Umherirrender removed Umherirrender as the assignee of this task.
Umherirrender added a project: MW-1.44-release.
Umherirrender moved this task from Blocker to Deprecate or remove on the MW-1.44-release board.
Umherirrender changed the task status from Stalled to Open.Oct 22 2024, 5:55 PM

Change #1131424 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] page: Remove deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1131424

Change #1131424 merged by jenkins-bot:

[mediawiki/core@master] page: Remove deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1131424