Page MenuHomePhabricator
Create Task
Maniphest T339394

Hard-deprecate PageArchive::listRevisions/getRevisionRecordByTimestamp/getArchivedRevisionRecord/getPreviousRevisionRecord/getLastRevisionId/isDeleted/undeleteAsUser/getFileStatus/getRevisionStatus (and remove in 1.44)
Closed, ResolvedPublic
Actions

Description

The following functions are deprecated and should be replaced

  • PageArchive::listRevisions
  • PageArchive::getRevisionRecordByTimestamp
  • PageArchive::getArchivedRevisionRecord
  • PageArchive::getPreviousRevisionRecord
  • PageArchive::getLastRevisionId
  • PageArchive::isDeleted
  • PageArchive::undeleteAsUser
  • PageArchive::getFileStatus
  • PageArchive::getRevisionStatus

After that the function should be hard-deprecated and removed

CodeSearch: https://codesearch.wmcloud.org/search/?q=-%3E%5Cs*%28listRevisions%7CgetRevisionRecordByTimestamp%7CgetArchivedRevisionRecord%7CgetPreviousRevisionRecord%7CgetLastRevisionId%7CundeleteAsUser%7CgetFileStatus%7CgetRevisionStatus%29%5Cs*%5C%28&files=&excludeFiles=&repos=
(search without isDeleted, gives many false positives)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
page: Remove deprecated PageArchive::undeleteAsUsermediawiki/coremaster+1 -114
page: Hard-deprecate PageArchive::undeleteAsUsermediawiki/coremaster+6 -1
maintenance: Replace deprecated PageArchive::undeleteAsUsermediawiki/coremaster+9 -5
tests: Replace deprecated PageArchive::undeleteAsUsermediawiki/extensions/Cognatemaster+3 -3
tests: Replace deprecated PageArchive::undeleteAsUsermediawiki/extensions/CreatedPagesListmaster+3 -7
tests: Replace deprecated PageArchive::undeleteAsUsermediawiki/extensions/PhpTagsStoragemaster+12 -5
Replace deprecated PageArchive::getPreviousRevisionRecord/listRevisionsmediawiki/extensions/CirrusSearchmaster+7 -5
page: Replace deprecated PageArchive::getArchivedRevisionRecordmediawiki/coremaster+6 -2
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Jun 16 2023, 9:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2023, 9:57 PM
gerritbot added a comment.Jun 16 2023, 9:58 PM

Change 930879 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CirrusSearch@master] Replace deprecated PageArchive::getPreviousRevisionRecord/listRevisions

https://gerrit.wikimedia.org/r/930879

gerritbot added a project: Patch-For-Review.Jun 16 2023, 9:58 PM
gerritbot added a comment.Jun 16 2023, 10:07 PM

Change 930881 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] page: Replace deprecated PageArchive::getArchivedRevisionRecord

https://gerrit.wikimedia.org/r/930881

gerritbot added a comment.Jun 20 2023, 11:48 AM

Change 930881 merged by jenkins-bot:

[mediawiki/core@master] page: Replace deprecated PageArchive::getArchivedRevisionRecord

https://gerrit.wikimedia.org/r/930881

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 20 2023, 12:00 PM
gerritbot added a comment.Jun 20 2023, 4:49 PM

Change 930879 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Replace deprecated PageArchive::getPreviousRevisionRecord/listRevisions

https://gerrit.wikimedia.org/r/930879

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2023, 5:10 PM
Krinkle moved this task from Untriaged to 2023+ | MW 1.40+ on the Technical-Debt (Deprecation process) board.Mar 27 2024, 6:46 PM
gerritbot added a comment.Jul 21 2024, 7:41 AM

Change #1055564 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Cognate@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055564

gerritbot added a project: Patch-For-Review.Jul 21 2024, 7:41 AM
gerritbot added a comment.Jul 21 2024, 7:45 AM

Change #1055566 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CreatedPagesList@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055566

gerritbot added a comment.Jul 21 2024, 7:48 AM

Change #1055567 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PhpTagsStorage@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055567

gerritbot added a comment.Jul 21 2024, 7:59 AM

Change #1055569 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] maintenance: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055569

gerritbot added a comment.Jul 21 2024, 8:01 AM

Change #1055567 merged by Umherirrender:

[mediawiki/extensions/PhpTagsStorage@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055567

gerritbot added a comment.Jul 21 2024, 8:02 AM

Change #1055566 merged by Umherirrender:

[mediawiki/extensions/CreatedPagesList@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055566

Umherirrender added a comment.Jul 21 2024, 8:04 AM

Some functions removed with 84154b0ea61c1aea6a2ccb5cc6ef7af3fc6eeb0f

gerritbot added a comment.Jul 21 2024, 8:09 AM

Change #1055571 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] page: Hard-deprecate PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055571

Umherirrender claimed this task.Jul 21 2024, 8:54 AM
gerritbot added a comment.Jul 26 2024, 6:29 PM

Change #1055564 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] tests: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055564

gerritbot added a comment.Jul 26 2024, 6:29 PM

Change #1055569 merged by jenkins-bot:

[mediawiki/core@master] maintenance: Replace deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055569

gerritbot added a comment.Jul 26 2024, 6:42 PM

Change #1055571 merged by jenkins-bot:

[mediawiki/core@master] page: Hard-deprecate PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1055571

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 26 2024, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 26 2024, 7:34 PM
Umherirrender renamed this task from Hard-deprecate PageArchive::listRevisions/getRevisionRecordByTimestamp/getArchivedRevisionRecord/getPreviousRevisionRecord/getLastRevisionId/isDeleted/undeleteAsUser/getFileStatus/getRevisionStatus (and remove a release later) to Hard-deprecate PageArchive::listRevisions/getRevisionRecordByTimestamp/getArchivedRevisionRecord/getPreviousRevisionRecord/getLastRevisionId/isDeleted/undeleteAsUser/getFileStatus/getRevisionStatus (and remove in 1.44).Jul 26 2024, 8:33 PM
Umherirrender changed the task status from Open to Stalled.
Umherirrender removed Umherirrender as the assignee of this task.
Umherirrender added a project: MW-1.44-release.
Umherirrender moved this task from Blocker to Deprecate or remove on the MW-1.44-release board.
Umherirrender changed the task status from Stalled to Open.Oct 22 2024, 5:55 PM
Umherirrender claimed this task.Mar 26 2025, 7:44 PM
gerritbot added a comment.Mar 26 2025, 7:44 PM

Change #1131424 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] page: Remove deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1131424

gerritbot added a project: Patch-For-Review.Mar 26 2025, 7:44 PM
gerritbot added a comment.Mar 26 2025, 8:25 PM

Change #1131424 merged by jenkins-bot:

[mediawiki/core@master] page: Remove deprecated PageArchive::undeleteAsUser

https://gerrit.wikimedia.org/r/1131424

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2025, 8:30 PM
Umherirrender closed this task as Resolved.Mar 26 2025, 8:38 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 26 2025, 9:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits