Page MenuHomePhabricator

ULS should return focus to element it was triggered by if it's closed with Esc
Closed, DuplicatePublicBUG REPORT

Description

Currently, ULS gets focus to its search field upon opening the language selector. If you close the language selector with Esc button, like it allows to, the focus gets removed from a page entirely. This should not happen: it should return back to the element ULS was triggered by. This is especially needed in new Vector.

Also, ULS search field does not have a proper label, which also is an accessibility violation that should be fixed. It does have a placeholder, but that is not a proper label.

Page to test this on: https://en.wikipedia.org/wiki/Russia

Event Timeline

@Jdlrobson what tasks related to ULS are within your team’s remit? If the answer is ‘none’, that is extremely poor given that your skin makes using ULS a requirement.

This is an issue with all skins, right? Not just Vector 2022 - so this needs to be fixed in the UniversalLanguageSelector extension. No team has picked this up but typically web team or/and language team work on UniversalLanguageSelector tasks (with language team the owner and point of first call).

Nikerabbit moved this task from Backlog to Accessibility on the UniversalLanguageSelector board.
Nikerabbit removed a project: Language-Team.

I added this ticket to consider for the future re-implementation of the language selector with new frontend standards (T287860).
For this kind of issue where the main workflow is not affected (selecting a language leads to a page refresh), efforts seem better spent on the new version. But feel free to share other perspectives.

Well, it is an accessibility issue in the component that is currently forced on readers and editors on the default skin on most wikis, so I don’t think this should be fixed as some sort of medium-term goal. Same as T282024: ULS language list should use `column-width` CSS property instead of splitting the lists btw. (I should really collect the blockers to new Vector deployment somewhere already...)

Actually, this was already filed in T325009: Improper focus when closing Language menu. As you can see, it is a WCAG AA violation, which is pretty important to fix as it is the most basic level of accessibility support for websites in most of jurisdictions.