Page MenuHomePhabricator

Prevent deprecation warnings about IPInfo not being available on mobile
Closed, ResolvedPublic

Description

IPInfo is causing deprecation warnings. This message is visible in the console when loading a page with $wgResourceLoaderDebug = true:

<b>Deprecated</b>:  Use of Modules must target desktop and mobile. Module name:ext.ipInfo was deprecated in MediaWiki 1.41. [Called from MediaWiki\ResourceLoader\StartUpModule::getScript in /var/www/html/mediawiki/core/includes/ResourceLoader/StartUpModule.php at line 420] in <b>/var/www/html/mediawiki/core/includes/debug/MWDebug.php</b> on line <b>382</b>

This is due to the specification for ext.ipInfo to be available only on desktop, and not mobile, via: "targets: ["desktop"] in extension.json. We are moving away from desktop-only features, as summarized in T328498: Remove desktop / mobile only targeted code from MediaWiki skins and extensions.

We plan to make IPInfo available on mobile: T268177: Make IPInfo available on mobile, but until then, we should remove the "targets" from the module definition, and only load ext.ipInfo if we're not in a mobile context (the last resort option described in this migration guide).

Event Timeline

Change 931288 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] Prevent deprecation warnings about IPInfo not being available on mobile

https://gerrit.wikimedia.org/r/931288

Change 931288 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Prevent deprecation warnings about IPInfo not being available on mobile

https://gerrit.wikimedia.org/r/931288