Page MenuHomePhabricator
Create Task
Maniphest T339871

Remove reference to $wgVisualEditorAllowLossySwitching
Closed, ResolvedPublic
Actions

Description

This configuration option is removed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/853921.
Places to remove (see https://codesearch.wmcloud.org/search/?q=AllowLossySwitching):

  • VisualEditor
  • MobileFrontend
  • WMF CommonSettings.php

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove remains of lossy-switching and discard-switchingmediawiki/extensions/MobileFrontendmaster+16 -51
Remove remains of lossy-switching and discard-switchingmediawiki/extensions/VisualEditormaster+15 -162
Remove unused config $wgVisualEditorAllowLossySwitchingoperations/mediawiki-configmaster+0 -4
Customize query in gerrit

Related Objects

Event Timeline

Bugreporter created this task.Jun 19 2023, 5:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2023, 5:03 PM
Bugreporter mentioned this in T339872: Remove allowSwitchingToVisualMode.Jun 19 2023, 5:07 PM
matmarex claimed this task.Jun 24 2023, 10:49 AM
gerritbot added a comment.Jun 25 2023, 8:25 AM

Change 932658 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Remove remains of lossy-switching and discard-switching

https://gerrit.wikimedia.org/r/932658

gerritbot added a project: Patch-For-Review.Jun 25 2023, 8:25 AM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 27 2023, 1:35 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jun 27 2023, 1:41 PM

Change 933460 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Remove unused config $wgVisualEditorAllowLossySwitching

https://gerrit.wikimedia.org/r/933460

gerritbot added a comment.Jun 27 2023, 8:02 PM

Change 933460 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove unused config $wgVisualEditorAllowLossySwitching

https://gerrit.wikimedia.org/r/933460

Stashbot added a comment.Jun 27 2023, 8:03 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T20:03:09Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:933460|Remove unused config $wgVisualEditorAllowLossySwitching (T339871)]], [[gerrit:927632|Remove wgDiscussionToolsEnable config (T322497)]]

Stashbot mentioned this in T322497: Remove config settings for individual DiscussionTools features.Jun 27 2023, 8:03 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T20:04:54Z] <samtar@deploy1002> esanders and samtar and matmarex: Backport for [[gerrit:933460|Remove unused config $wgVisualEditorAllowLossySwitching (T339871)]], [[gerrit:927632|Remove wgDiscussionToolsEnable config (T322497)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Jun 27 2023, 8:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T20:10:45Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:933460|Remove unused config $wgVisualEditorAllowLossySwitching (T339871)]], [[gerrit:927632|Remove wgDiscussionToolsEnable config (T322497)]] (duration: 07m 35s)

gerritbot added a comment.Jul 11 2023, 3:34 PM

Change 932658 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove remains of lossy-switching and discard-switching

https://gerrit.wikimedia.org/r/932658

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2023, 4:11 PM
matmarex added a project: Skipped QA.Jul 11 2023, 4:40 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.
matmarex removed a project: Skipped QA.Jul 11 2023, 4:44 PM
matmarex moved this task from Ready for Sign Off to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jul 11 2023, 4:56 PM

Change 937154 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Remove remains of lossy-switching and discard-switching

https://gerrit.wikimedia.org/r/937154

gerritbot added a project: Patch-For-Review.Jul 11 2023, 4:56 PM
gerritbot added a comment.Jul 22 2023, 2:59 AM

Change 937154 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Remove remains of lossy-switching and discard-switching

https://gerrit.wikimedia.org/r/937154

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 22 2023, 3:04 AM
matmarex edited projects, added: Skipped QA; removed: Patch-For-Review.
matmarex mentioned this in T342490: Unable to switch to Visual Editor with changes on mobile .Jul 24 2023, 9:21 PM
ppelberg closed this task as Resolved.Aug 17 2023, 10:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits