Page MenuHomePhabricator

Uncaught TypeError: can't access property "then", ve.scrollIntoView(...) is undefined
Closed, ResolvedPublic

Description

Seen on section-level image tasks on beta wikis:

Uncaught TypeError: can't access property "then", ve.scrollIntoView(...) is undefined
    scrollSelectionIntoView https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:43952
    later https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=oojs-ui-core&skin=vector-2022&version=ztntf:253
    setTimeout handler*OO.ui.debounce/< https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=oojs-ui-core&skin=vector-2022&version=ztntf:261
    onModelSelect https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:43876
    emit https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=oojs&skin=vector-2022&version=ztntf:859
    setSelection https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:14031
    setLinearSelection https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:13821
    selectFirstVisibleStartContentOffset https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:36468
    focus https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:32401
    afterActivate https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:463
    activate https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:422
    jQuery 6
    surfaceReady https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:768
    surfaceReady https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.growthExperiments.StructuredTask&skin=vector-2022&version=ztntf:998
    addSurface https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1232
    setTimeout handler*ve.init.mw.Target.prototype.addSurface https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1222
    addSurface https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:199
    setupSurface https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1194
    setTimeout handler*ve.init.mw.Target.prototype.setupSurface/< https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1193
    setTimeout handler*ve.init.mw.Target.prototype.setupSurface https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1182
    documentReady https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1087
    documentReady https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.articleTarget&skin=vector-2022&version=ztntf:482
    loadSuccess https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.articleTarget&skin=vector-2022&version=ztntf:372
    loadSuccess https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:331
    jQuery 2
    load https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.articleTarget&skin=vector-2022&version=ztntf:1170
    activate https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:438
    activateTarget https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget.init&skin=vector-2022&version=ztntf:608
    jQuery 8
    activateTarget https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget.init&skin=vector-2022&version=ztntf:607
    jQuery 7
load.php:43952:5
    scrollSelectionIntoView https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:43952
    later https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=oojs-ui-core&skin=vector-2022&version=ztntf:253
    (Async: setTimeout handler)
    debounce https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=oojs-ui-core&skin=vector-2022&version=ztntf:261
    onModelSelect https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:43876
    emit https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=oojs&skin=vector-2022&version=ztntf:859
    setSelection https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:14031
    setLinearSelection https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:13821
    selectFirstVisibleStartContentOffset https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:36468
    focus https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.core&skin=vector-2022&version=ztntf:32401
    afterActivate https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:463
    activate https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:422
    jQuery 6
    surfaceReady https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:768
    surfaceReady https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.growthExperiments.StructuredTask&skin=vector-2022&version=ztntf:998
    addSurface https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1232
    (Async: setTimeout handler)
    addSurface https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1222
    addSurface https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:199
    setupSurface https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1194
    (Async: setTimeout handler)
    setupSurface https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1193
    (Async: setTimeout handler)
    setupSurface https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1182
    documentReady https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.mediawiki&skin=vector-2022&version=ztntf:1087
    documentReady https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.articleTarget&skin=vector-2022&version=ztntf:482
    loadSuccess https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.articleTarget&skin=vector-2022&version=ztntf:372
    loadSuccess https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:331
    jQuery 2
    load https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.articleTarget&skin=vector-2022&version=ztntf:1170
    activate https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget&skin=vector-2022&version=ztntf:438
    activateTarget https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget.init&skin=vector-2022&version=ztntf:608
    jQuery 8
    activateTarget https://es.wikipedia.beta.wmflabs.org/w/load.php?debug=2&lang=es&modules=ext.visualEditor.desktopArticleTarget.init&skin=vector-2022&version=ztntf:607
    jQuery 7

Event Timeline

Change 931608 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Section images: Fix ve.scrollIntoView override

https://gerrit.wikimedia.org/r/931608

The fix is trivial, but when testing it I sometimes get the kind of scrolling issues that rEGREf67fb47c87e6: Section images: Fix scrolling to placeholder was supposed to fix. I'm not sure it's related to the patch or that fix just didn't catch all pathways in the first place.

Change 931608 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Section images: Fix ve.scrollIntoView override

https://gerrit.wikimedia.org/r/931608

Change 931084 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.13] Section images: Fix ve.scrollIntoView override

https://gerrit.wikimedia.org/r/931084

Change 931084 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.13] Section images: Fix ve.scrollIntoView override

https://gerrit.wikimedia.org/r/931084

Mentioned in SAL (#wikimedia-operations) [2023-06-20T21:49:29Z] <tgr@deploy1002> Started scap: Backport for [[gerrit:931084|Section images: Fix ve.scrollIntoView override (T339900 T335209)]], [[gerrit:931685|Backport translations from master (T339225)]]

Mentioned in SAL (#wikimedia-operations) [2023-06-20T22:01:35Z] <tgr@deploy1002> tgr and kharlan: Backport for [[gerrit:931084|Section images: Fix ve.scrollIntoView override (T339900 T335209)]], [[gerrit:931685|Backport translations from master (T339225)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-06-20T22:11:59Z] <tgr@deploy1002> Finished scap: Backport for [[gerrit:931084|Section images: Fix ve.scrollIntoView override (T339900 T335209)]], [[gerrit:931685|Backport translations from master (T339225)]] (duration: 22m 30s)