Addition of PPFrame::getTitle
Closed, ResolvedPublic



Let us make frame title available through method getTitle. It allows parser functions to access title of current frame. It makes possible magic words or parser functions which know the name of current frame, like {{SRCNAME}} (discussed in 24284). In turn, {{SRCNAME}} makes possible "template-scope" variables, e. g. {{ #vardefine: {{SRCNAME}}:i }}, {{ #var: {{SRCNAME}}:i }}. It also makes possible extensions which does the same even more gracefully: {{ #localdefine: i }}, {{ #local: i }}. (localdefine, local are parser function which set/get "template-scope" variables; I wrote "template-scope" in parentheses because these variables are available outside by using "full" name: {{ #var: Templatename:i }}.)

Version: unspecified
Severity: enhancement


bzimport set Reference to bz31995.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Oct 27 2011, 6:47 PM wrote:

Trivial getTitle implementation.

Attached: MediaWiki-parser-getTitle.patch

sumanah wrote:

Adding the "need-review" and "patch" keywords, for patches that need review by developers. Van de Bugger, thank you for your patch.

Reedy added a comment.Nov 9 2011, 8:53 PM

Reviewed, and applied in r102571

Also did Preprocessor_HipHop as it exists in trunk (and 1.18?)

Technically wasn't needed, because $title is var (so public), but certainly the better way to do it than direct member variable access!

Thanks wrote:

Verified on r102853.

Danwe added a comment.Dec 6 2011, 7:23 PM

Great, it once took me a while to get the idea that there was a public $mTitle. For additions like this I would really appreciate to see the '@since' in the function documentation. Would make it a lot easier to keep backwards compatibility in extensions.

Add Comment