Page MenuHomePhabricator
Create Task
Maniphest T340031

[buildservice] Create GET /build/{id} endpoint in the buildservice API
Closed, ResolvedPublic
Actions

Description

The code at https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-api can be extended to present a GET /build/{id} endpoint.

This can be later used by the CLI client.

Currently the client show this info:

tools.sample-php-buildpack-app@tools-sgebastion-10:~$ toolforge build show
Name: sample-php-buildpack-app-buildpacks-pipelinerun-8jzx7
Start time: 2023-06-21T11:41:13Z
End time: 2023-06-21T11:42:10Z
Status: ok (Succeeded)
Message: Tasks Completed: 1 (Failed: 0, Cancelled 0), Skipped: 0
Parameters:
    source_url: https://gitlab.wikimedia.org/toolforge-repos/sample-php-buildpack-app
    ref: first_commit
    image_name: sample-php-buildpack-app
    image_tag: latest
    repo_url: tools-harbor.wmcloud.org/tool-sample-php-buildpack-app
    builder_image: tools-harbor.wmcloud.org/toolforge/heroku-builder-classic:22

Details

ReferenceSource BranchDest BranchAuthorTitle
repos/cloud/toolforge/builds-api!25arturo-wip-builds-api-add-getmainaborrerobuilds-api: add GET /build/{id} endpoint
Customize query in GitLab

Related Objects
Search...

Event Timeline

aborrero created this task.Jun 21 2023, 12:46 PM
dcaro updated the task description. (Show Details)Jun 21 2023, 12:47 PM
Raymond_Ndibe mentioned this in T340076: build_logs makes calls to both kubernetes and toolforge-weld.Jun 21 2023, 10:36 PM
Raymond_Ndibe added a subscriber: Raymond_Ndibe.Jun 21 2023, 10:38 PM
CodeReviewBot added a comment.Jun 28 2023, 1:06 PM

aborrero opened https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-api/-/merge_requests/25

Draft: WIP: builds-api: add GET /build/{id} endpoint

CodeReviewBot added a project: Patch-For-Review.Jun 28 2023, 1:06 PM
aborrero moved this task from Backlog to Doing on the User-aborrero board.Jun 29 2023, 8:22 AM
dcaro changed the task status from Open to In Progress.Jul 3 2023, 8:44 AM
dcaro moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 16) board.
aborrero changed the task status from In Progress to Stalled.Jul 4 2023, 9:51 AM
aborrero triaged this task as Low priority.
aborrero moved this task from Doing to Blocked on the User-aborrero board.

The initial patch was created. I'm waiting for the latest toolforge-deploy & lima-kilo changes to land so I can test it locally.

dcaro changed the task status from Stalled to In Progress.Jul 4 2023, 3:19 PM
dcaro moved this task from Iteration 16 to Iteration 17 on the Toolforge Build Service board.
dcaro edited projects, added Toolforge Build Service (Iteration 17); removed Toolforge Build Service (Iteration 16).
dcaro moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 17) board.
dcaro removed projects: Goal, Epic.
Raymond_Ndibe moved this task from In Progress to In Review on the Toolforge Build Service (Iteration 17) board.Jul 5 2023, 2:53 AM
aborrero moved this task from Blocked to Doing on the User-aborrero board.Jul 12 2023, 9:47 AM
dcaro added a comment.Jul 12 2023, 4:13 PM

@aborrero, @Raymond_Ndibe I have started a more specific definition of the output and the datastructures to sync here:
https://etherpad.wikimedia.org/p/new_build_info

let me know what do you think, as we were starting to diverge on the MRs

aborrero moved this task from Doing to Next on the User-aborrero board.Jul 14 2023, 12:28 PM
aborrero moved this task from Next to Doing on the User-aborrero board.Jul 18 2023, 12:04 PM
aborrero moved this task from Doing to Next on the User-aborrero board.Jul 20 2023, 3:55 PM
fnegri moved this task from FY2022/2023-Q4 to FY2023/2024-Q1-Q2 on the cloud-services-team board.Jul 26 2023, 5:47 PM
fnegri edited projects, added cloud-services-team (FY2023/2024-Q1-Q2); removed cloud-services-team (FY2022/2023-Q4).
fnegri moved this task from Backlog to In progress on the cloud-services-team (FY2023/2024-Q1-Q2) board.
aborrero added a comment.Jul 28 2023, 11:13 AM
In T340031#9009587, @dcaro wrote:

@aborrero, @Raymond_Ndibe I have started a more specific definition of the output and the datastructures to sync here:
https://etherpad.wikimedia.org/p/new_build_info

let me know what do you think, as we were starting to diverge on the MRs

I agree with the proposal. I'll follow it!

dcaro mentioned this in T343505: [builds-cli] Use the API to retrieve a single build.Aug 4 2023, 7:58 AM
dcaro moved this task from In Review to In Progress on the Toolforge Build Service (Iteration 17) board.Aug 8 2023, 12:51 PM
dcaro edited projects, added Toolforge Build Service (Iteration 18); removed Toolforge Build Service (Iteration 17).Aug 8 2023, 1:50 PM
dcaro moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 18) board.
dcaro edited projects, added Toolforge Build Service (Iteration 19); removed Toolforge Build Service (Iteration 18).Aug 30 2023, 7:40 AM
dcaro moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 19) board.
Raymond_Ndibe mentioned this in T345675: [buildservice] Create GET /build/latest endpoint in the buildservice API.Sep 5 2023, 11:44 PM
aborrero moved this task from Next to Doing on the User-aborrero board.Sep 6 2023, 8:45 AM
aborrero added a comment.Sep 8 2023, 12:43 PM

Patch https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-api/-/merge_requests/25 should be ready for merge/review.

CodeReviewBot added a comment.Sep 11 2023, 11:38 AM

aborrero merged https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-api/-/merge_requests/25

builds-api: add GET /build/{id} endpoint

aborrero closed this task as Resolved.Sep 11 2023, 11:40 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2023, 12:11 PM
fnegri moved this task from In progress to Done on the cloud-services-team (FY2023/2024-Q1-Q2) board.Sep 20 2023, 9:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL