Page MenuHomePhabricator
Create Task
Maniphest T340063

[REQUEST] Design systems code review for Vue3 new page patrol
Closed, InvalidPublic8 Estimated Story Points
Actions

Description

What teams or group is this for?
moderator tools

Who is your main point of contact and contact preference?
@jsn.sherman slack, gerrit, and phabricator are all good modes of communication

What are the details of your request? Include relevant timelines or deadlines
I've been working on a vue3 new page patrol feed (T324914) here:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/910519
and I figure it's far enough along that it would benefit from a design systems review.
How does the request fit within departmental or foundation priorities?
Like a glove. This is part of our work with the English Wikipedia New Pages Patrol community.

Is this request urgent or time-sensitive?
Let's call it time sensitive, but not urgent.

Related Objects

Event Timeline

jsn.sherman created this task.Jun 21 2023, 8:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 21 2023, 8:20 PM
jsn.sherman renamed this task from [REQUEST] to [REQUEST] Design systems code review.Jun 21 2023, 8:20 PM
jsn.sherman renamed this task from [REQUEST] Design systems code review to [REQUEST] Design systems code review for Vue3 new page patrol.
CCiufo-WMF moved this task from Inbox to Needs Refinement on the Design-System-Team board.Jun 22 2023, 2:14 PM
lwatson subscribed.Jun 22 2023, 4:40 PM
lwatson unsubscribed.
ldelench_wmf set the point value for this task to 8.Jun 22 2023, 4:54 PM
CCiufo-WMF moved this task from Needs Refinement to Up Next on the Design-System-Team board.Jun 22 2023, 4:55 PM
Samwalton9-WMF updated the task description. (Show Details)Jun 23 2023, 2:46 PM
Samwalton9-WMF updated the task description. (Show Details)
Samwalton9-WMF subscribed.
CCiufo-WMF triaged this task as Medium priority.Jun 26 2023, 2:30 PM
CCiufo-WMF closed this task as Invalid.Jul 21 2023, 2:30 PM
CCiufo-WMF subscribed.

Closing as Invalid since the patch has already been merged, but I do still think there's an opportunity to sync between Moderator Tools and Design Systems on the experience of migrating to Vue and using Codex. I'll capture that elsewhere.

Samwalton9-WMF added a comment.Jul 21 2023, 2:32 PM
In T340063#9034403, @CCiufo-WMF wrote:

Closing as Invalid since the patch has already been merged

Just to clarify, it's been merged for testing but is hidden behind a URL parameter, so there's still scope for feedback and iteration.

CCiufo-WMF added a comment.Jul 21 2023, 2:38 PM
In T340063#9034413, @Samwalton9 wrote:
In T340063#9034403, @CCiufo-WMF wrote:

Closing as Invalid since the patch has already been merged

Just to clarify, it's been merged for testing but is hidden behind a URL parameter, so there's still scope for feedback and iteration.

Hmm, so maybe we can still do some sort of review / walkthrough of the changes and provide feedback. Is there an timeline for the feedback/iteration window?

Samwalton9-WMF added a comment.Jul 21 2023, 2:41 PM
In T340063#9034441, @CCiufo-WMF wrote:
In T340063#9034413, @Samwalton9 wrote:
In T340063#9034403, @CCiufo-WMF wrote:

Closing as Invalid since the patch has already been merged

Just to clarify, it's been merged for testing but is hidden behind a URL parameter, so there's still scope for feedback and iteration.

Hmm, so maybe we can still do some sort of review / walkthrough of the changes and provide feedback. Is there an timeline for the feedback/iteration window?

We'd like to move ahead with this being the default experience in the next 2-3 weeks.

CCiufo-WMF added a comment.Jul 21 2023, 2:49 PM
In T340063#9034461, @Samwalton9 wrote:
In T340063#9034441, @CCiufo-WMF wrote:
In T340063#9034413, @Samwalton9 wrote:
In T340063#9034403, @CCiufo-WMF wrote:

Closing as Invalid since the patch has already been merged

Just to clarify, it's been merged for testing but is hidden behind a URL parameter, so there's still scope for feedback and iteration.

Hmm, so maybe we can still do some sort of review / walkthrough of the changes and provide feedback. Is there an timeline for the feedback/iteration window?

We'd like to move ahead with this being the default experience in the next 2-3 weeks.

Ok thanks! We should be able to make that work. I'm going to create a new task for this.

CCiufo-WMF mentioned this in T343591: [Audit] Review of new Vue+Codex New Pages Feed.Aug 4 2023, 7:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits