As a first step towards migrating the Curation Toolbar to Vue.js, we need to build the container, which the other features will live inside.
The Curation Toolbar should be able to:
We can use the same ui_version parameter as the NewPagesFeed to access this version.
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/PageTriage | master | +793 -19 | Vue.js Curation Toolbar container |
Change 938956 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):
[mediawiki/extensions/PageTriage@master] WIP Vue.js Curation Toolbar container
Contining some discussion from T343332#9120049:
Note that we're not planning on renaming the feature flag until after all testing is complete.
[...]
Rough draft idea:
- &pagetriage_ui unset - Backbone everything
Makes sense, and is the current behavior.
- &pagetriage_ui=1 - Special:NewPagesFeed vue rewrite
- &pagetriage_ui=2 - Special:NewPagesFeed vue rewrite, AND page curation toolbar vue rewrite, AND links in Special:NewPagesFeed get appended with &ui_version=2
The current patch for the new toolbar can't work this way. vue feed can only share state with vue toolbar, and backbone feed only can share state with backbone toolbar.
I actually have a followup patch in T342434: Special:NewPagesFeed and Page Curation toolbar must share and persist state in progress to make the new feed and toolbar use the same state as the old one in order to maintain per-account persistence of settings. The original vue local storage implementation only kept settings per device. I would still recommend sticking with a single flag to toggle between vue and backbone everywhere, but this would be an option after the followup patch.
Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/bda3f73aef/w
Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted: