Page MenuHomePhabricator

consider moving aphlict admin port to https / envoy
Open, MediumPublic

Description

An aphlict server has 2 ports, a client port and an admin port.

Currently the client port, 22280, uses https even behind the caching layer, so TLS is terminated at the backend by envoy.

The admin port, 22281, though still uses http between ATS and backend.

The last time we checked this was an issue of adding 2 envoy services on the same machine. This may or may not be true anymore.

Question is if we care and still want everything to be https-only even internally.

This could be a security risk when running Phabricator in one DC and Aphlict in another.

patch https://gerrit.wikimedia.org/r/c/operations/puppet/+/616917 was once uploaded for this.

Event Timeline

Change 616917 had a related patch set uploaded (by Dzahn; author: Dzahn):

[operations/puppet@production] aphlict: add second envoy TLS terminator for admin port

https://gerrit.wikimedia.org/r/616917

Change 616917 abandoned by Dzahn:

[operations/puppet@production] aphlict: add second envoy TLS terminator for admin port

Reason:

to be considered in the future

https://gerrit.wikimedia.org/r/616917

LSobanski triaged this task as Medium priority.Jul 5 2023, 4:40 PM
LSobanski updated the task description. (Show Details)
LSobanski moved this task from Incoming to Backlog on the Collaboration-Services board.
LSobanski subscribed.

Let's confirm what the admin port is used for and decide on the priority afterwards.

secure.phabricator.com is currently serving 503

I wrote in a code comment in the past that phabricator NEEDS to talk to the admin port, not the client port.

Also the defaults look like admin port should only listen on 127.0.0.1 ..but in fact both client port and admin port listen on IPv6 server IP...

That last part is something to check on.

While the upstream docs say "each server runs a "client" service and an "admin" service" I don't see an explanation yet what the "admin service" actually does.

The only thing that seems clear is that it needs both ports to function.

18:16 < andre> https://we.phorge.it/rP9a7ad972cd2637e566ac7598357b88364d6f2b64 might not be the greatest read at the fireplace but that's when code got split into admin vs client

Dzahn removed Dzahn as the assignee of this task.Nov 25 2025, 4:58 PM

un-licking the cookie before Andre takes it from me :)