Page MenuHomePhabricator
Create Task
Maniphest T340179

Mouse wheel clicking a notification/ping should refresh the notification tray (so that user can see that the notification is marked as read)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Install Echo
  • Log in
  • Get a notification (or ping) to show up in Echo
    • the issue also happens if you actively mark a notification as unread by clicking its "mark as unread"-button (the little circle)
  • Open the tray
  • Hove your mouse over the unread notification and click on it with your mouse wheel

What happens?:

  • Page opens in new tab
  • Notification is marked as read, but there is no GUI update. You have to reload the page or close and open the notification tray (forcing a notification tray refresh) to see this

What should have happened instead?:

  • Page opens in new tab
  • Notification is marked as read, and the notification tray updates in real time to reflect that the notification is read

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Immediately show middle-clicked notifications as readmediawiki/extensions/Echomaster+20 -1
Customize query in gerrit

Event Timeline

Novem_Linguae created this task.Jun 23 2023, 8:34 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 23 2023, 8:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova moved this task from Inbox to Needs Discussion on the Growth-Team board.Jun 30 2023, 7:15 PM
Michael added projects: good first task, patch-welcome.Jul 25 2024, 7:11 PM
Michael moved this task from Needs Discussion to Triaged on the Growth-Team board.
Michael subscribed.

Not sure if it really is a bug, but it is self-contained, reasonably straight forward to reproduce, and not urgent but clearly valuable.

Restricted Application added a comment. · View Herald TranscriptJul 25 2024, 7:11 PM

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Michael updated the task description. (Show Details)Jul 25 2024, 7:12 PM
Michael updated the task description. (Show Details)Jul 25 2024, 7:17 PM
Rummskartoffel claimed this task.Aug 4 2024, 2:53 PM
Rummskartoffel subscribed.

Taking a shot at this one.

gerritbot added a comment.Aug 4 2024, 8:45 PM

Change #1059503 had a related patch set uploaded (by Rummskartoffel; author: Rummskartoffel):

[mediawiki/extensions/Echo@master] Immediately show middle-clicked notifications as read

https://gerrit.wikimedia.org/r/1059503

gerritbot added a project: Patch-For-Review.Aug 4 2024, 8:45 PM
gerritbot added a comment.Aug 5 2024, 6:56 PM

Change #1059503 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Immediately show middle-clicked notifications as read

https://gerrit.wikimedia.org/r/1059503

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 5 2024, 7:00 PM
Michael edited projects, added: User-notice; removed: Patch-For-Review, patch-welcome.EditedAug 5 2024, 7:12 PM

Thank you @Rummskartoffel implementing this!

I'm tagging this with User-notice, because it is a nice little improvement done by a volunteer developer, @Rummskartoffel , and maybe we want to tell the community about it. I expect it to roll out to the wikis with this week's train. With this change, when opening a notification in a new tab by clicking it with the mouse wheel, it will be marked as read immediately. ✨

(I'm not fully sure if this is something that actually should be included in Tech News, but I'm adding the tag regardless, so that the Editorial Committee can decide if and when to include it 🙂 ).

Pppery closed this task as Resolved.Aug 7 2024, 4:39 PM
Pppery subscribed.Aug 7 2024, 5:11 PM

I don't think this warrants a tech news entry, but I'm not a Tech News writer so my opinion isn't really worth anything.

Novem_Linguae added a comment.Aug 8 2024, 2:11 PM

I agree with Pppery that this might not be the best fit for tech news. Thank you very much for the +2 though!

Quiddity removed a project: User-notice.Aug 8 2024, 8:18 PM
Quiddity subscribed.

This is a lovely micro-improvement, that I will benefit from almost daily! Thank you, all!
(I'm removing the notice tag, per comments above, but the suggestion is appreciated. Better to suggest too much, than to miss something!)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits