Page MenuHomePhabricator

Form: Convert checkboxes to use Codex fieldset
Closed, ResolvedPublic

Description

As @CCiufo-WMF mentioned in T340119#9124776, we should be using isFieldset=true for the checkboxes in the application.

Event Timeline

As @CCiufo-WMF mentioned in T340119#9124776, we should be using isFieldset=true for the checkboxes in the application.

kostajh renamed this task from Add an error state to codex checkboxes to Form: Convert checkboxes to use Codex fieldset.Aug 28 2023, 6:13 PM
kostajh removed a subscriber: JKieserman.

@Madalina now that I am re-reading the original task title (Add an error state to codex checkboxes) I think this task is about more than just the technical change of using isFieldset property. My guess is that Julia intended this task to be about highlighting the "type of behavior" checkboxes if none of them are selected?

image.png (1×2 px, 482 KB)

What is the desired behavior here? I can think of some options:

  1. Users don't have to pick any of the checkboxes in order to submit the form
  2. Submit button is disabled until the user checks one of the "types of behavior" boxes
  3. Submit button is enabled, but we show an error to the user if they have pressed Submit without also having checked one of the boxes
    • in that case, should all checkboxes have a red highlight / error state? Where should we display the error message which prompts the user to select a checkbox?

Change 953568 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/ReportIncident@master] form: Use fieldset for Codex checkboxes

https://gerrit.wikimedia.org/r/953568

@Madalina now that I am re-reading the original task title (Add an error state to codex checkboxes) I think this task is about more than just the technical change of using isFieldset property. My guess is that Julia intended this task to be about highlighting the "type of behavior" checkboxes if none of them are selected?

image.png (1×2 px, 482 KB)

What is the desired behavior here? I can think of some options:

  1. Users don't have to pick any of the checkboxes in order to submit the form
  2. Submit button is disabled until the user checks one of the "types of behavior" boxes
  3. Submit button is enabled, but we show an error to the user if they have pressed Submit without also having checked one of the boxes
    • in that case, should all checkboxes have a red highlight / error state? Where should we display the error message which prompts the user to select a checkbox?

Related: T338818: Implement rules for form validation

Change 953568 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] form: Use fieldset for Codex checkboxes

https://gerrit.wikimedia.org/r/953568

Djackson-ctr subscribed.

@kostajh:
Not for sure why you pushed this to QA since there is nothing for me to test with this ticket, from your comments it would seem that this ticket will actually correlate and be resolved with T338818 so at this at this point we can close this ticket.

Does selecting a checkbox routes the message to different department/admins? If not in that case having a checkbox is an extra click (potential error states etc) and I would convert that into more of an informative section.

If however, selecting a checkbox does handle the form differently, then we can go for option 3 i.e. showing an error if the user doesn't select anything. We can include one error message for the whole checkbox section "Please select type of behaviour" and individual checkboxes don't need to be highlighted red.

Does selecting a checkbox routes the message to different department/admins? If not in that case having a checkbox is an extra click (potential error states etc) and I would convert that into more of an informative section.

Good point – at the moment, all reports are routed to the same place. So my proposal for the MTP (T337566: [EPIC]: Incident Reporting System - Minimal Testable Product (MTP)) is that we should not make the checkboxes required. In a future iteration, when the checkboxes impact how the reports get processed/routed (or we see from analytics data that reports with no checkboxes are problematic) we could revisit this. Does that sound ok, @Madalina?

Sounds good to me. Let's not make the checkboxes required for the MTP and we will revisit this in future iterations when we will need to deal with multiple exit points.

Cool. In that case, I think we can mark this task as resolved.

I would change the checkboxes to informative bullet points in that case.
Shouldn’t be an interactive component if users can’t interact with them.

I would change the checkboxes to informative bullet points in that case.
Shouldn’t be an interactive component if users can’t interact with them.

We would still include information about which checkboxes the user has selected in the report that we email (T345256: Send email based on form submission), so I think it is useful to keep them--it helps the responder understand what type of report they are receiving.

Change 955684 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/ReportIncident@master] form: Use label slot for checkbox field

https://gerrit.wikimedia.org/r/955684

kostajh added a subscriber: AnneT.

Re-opening for an issue that @AnneT spotted.

Change 955684 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] form: Use label slot for checkbox field

https://gerrit.wikimedia.org/r/955684

Looks like this is done.