Page MenuHomePhabricator

ContentTranslation shouldn't use mediawiki.ui modules
Closed, ResolvedPublicBUG REPORT

Description

Please help us migrate from mediawiki ui to Codex.

Checklist

Track progress: https://codesearch.wmcloud.org/search/?q=mediawiki%5C.ui&files=&excludeFiles=&repos=Extension%3AContentTranslation

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki/extensions/ContentTranslationmaster+3 K -3 K
mediawiki/extensions/ContentTranslationmaster+59 -65
mediawiki/extensions/ContentTranslationmaster+34 -49
mediawiki/extensions/ContentTranslationmaster+11 -23
mediawiki/extensions/ContentTranslationmaster+12 -9
mediawiki/extensions/ContentTranslationmaster+4 K -3 K
mediawiki/extensions/ContentTranslationmaster+35 -16
mediawiki/extensions/ContentTranslationmaster+22 -15
mediawiki/extensions/ContentTranslationmaster+12 -8
mediawiki/extensions/ContentTranslationmaster+36 -29
mediawiki/extensions/ContentTranslationmaster+81 -94
mediawiki/extensions/ContentTranslationmaster+8 -8
mediawiki/extensions/ContentTranslationmaster+15 -11
mediawiki/extensions/ContentTranslationmaster+16 -6
mediawiki/extensions/ContentTranslationmaster+30 -26
mediawiki/extensions/ContentTranslationmaster+45 -46
mediawiki/extensions/ContentTranslationmaster+19 -10
mediawiki/extensions/ContentTranslationmaster+14 -12
mediawiki/extensions/ContentTranslationmaster+10 -14
mediawiki/extensions/ContentTranslationmaster+43 -48
mediawiki/extensions/ContentTranslationmaster+84 -114
mediawiki/extensions/ContentTranslationmaster+20 -16
mediawiki/extensions/ContentTranslationmaster+9 -12
mediawiki/extensions/ContentTranslationmaster+6 K -12 K
mediawiki/extensions/ContentTranslationmaster+11 -15
mediawiki/extensions/ContentTranslationmaster+25 -33
mediawiki/extensions/ContentTranslationmaster+105 -124
mediawiki/extensions/ContentTranslationmaster+39 -35
mediawiki/extensions/ContentTranslationmaster+25 -30
mediawiki/extensions/ContentTranslationmaster+13 -16
mediawiki/extensions/ContentTranslationmaster+60 -87
mediawiki/extensions/ContentTranslationmaster+625 -128
mediawiki/extensions/ContentTranslationmaster+0 -3
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ngkountas changed the task status from Open to In Progress.Jan 18 2024, 8:14 AM
ngkountas claimed this task.

Change 991754 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Stop loading "mediawiki.ui.icon" and "mediawiki.ui.button" modules

https://gerrit.wikimedia.org/r/991754

Change 991754 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Stop loading "mediawiki.ui.icon" and "mediawiki.ui.button" modules

https://gerrit.wikimedia.org/r/991754

Change 1002977 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Add @wikimedia/codex package

https://gerrit.wikimedia.org/r/1002977

Change 1002979 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX BlockTemplateAdaptationCard: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1002979

Change 1002987 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX ProposedTranslationActionButtons: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1002987

Change 1002990 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX ProposedTranslationCard: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1002990

Change 1003016 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX ProposedTranslationHeader: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003016

Change 1003055 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX RetryMtCard: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003055

Change 1003065 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXArticleSearch: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003065

Change 1003066 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXConfirmBackNavigationDialog: Use CdxButton component

https://gerrit.wikimedia.org/r/1003066

Change 1003787 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXSectionSelectorSectionList: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003787

Change 1003788 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXPublishOptionSelector: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003788

Change 1003789 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXPublisherReviewInfo: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003789

Change 1002977 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Add @wikimedia/codex package

https://gerrit.wikimedia.org/r/1002977

Change 1002987 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX ProposedTranslationActionButtons: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1002987

Change 1002979 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX BlockTemplateAdaptationCard: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1002979

Change 1002990 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX ProposedTranslationCard: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1002990

Change 1003016 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX ProposedTranslationHeader: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003016

Change 1003055 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX RetryMtCard: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003055

Change 1004124 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240216

https://gerrit.wikimedia.org/r/1004124

Change 1003065 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXArticleSearch: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003065

Change 1003066 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXConfirmBackNavigationDialog: Use CdxButton component

https://gerrit.wikimedia.org/r/1003066

Change 1004124 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240216

https://gerrit.wikimedia.org/r/1004124

Change 1004629 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXPublisherHeader: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1004629

Change 1004632 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXPublisher: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1004632

Change 1004636 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXConfirmTranslationStartDialog: Use CdxButton component

https://gerrit.wikimedia.org/r/1004636

Change 1004657 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXSectionSelectorSectionListMissing: Use CdxButton component

https://gerrit.wikimedia.org/r/1004657

Change 1004664 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXSectionSelectorViewArticleItem: Use CdxIcon component

https://gerrit.wikimedia.org/r/1004664

Change 1004667 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXSectionSelectorViewArticleItem: Use CdxIcon component

https://gerrit.wikimedia.org/r/1004667

Change 1004685 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmerActionPanel: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1004685

Change 1004632 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXPublisher: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1004632

Change 1004657 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXSectionSelectorSectionListMissing: Use CdxButton component

https://gerrit.wikimedia.org/r/1004657

Change 1003787 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXSectionSelectorSectionList: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003787

Change 1003788 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXPublishOptionSelector: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003788

Change 1004664 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXSectionSelectorViewArticleItem: Use CdxIcon component

https://gerrit.wikimedia.org/r/1004664

Change 1004667 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Use CdxIcon component

https://gerrit.wikimedia.org/r/1004667

Change 1004752 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] TranslatedSegmentCard: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1004752

Change 1004756 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] TranslatedSegmentCardActionButtons: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1004756

Change 1004629 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXPublisherHeader: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1004629

Change 1003789 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXPublisherReviewInfo: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1003789

Change 1004752 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] TranslatedSegmentCard: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1004752

Change 1004636 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXConfirmTranslationStartDialog: Use CdxButton component

https://gerrit.wikimedia.org/r/1004636

Change 1005135 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXQuickTutorial: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005135

Change 1005137 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXLoginDialog: Replace MwButton with regular <a> element

https://gerrit.wikimedia.org/r/1005137

Change 1005145 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXSectionSelectorHeader: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005145

Change 1005145 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXSectionSelectorHeader: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005145

Change 1005137 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXLoginDialog: Replace MwButton with regular <a> element

https://gerrit.wikimedia.org/r/1005137

Change 1004685 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmerActionPanel: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1004685

Change 1005453 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CXDashboard: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005453

Change 1005465 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CXDashboard: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005465

Change 1005494 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CXTranslationWorkPublished: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005494

Change 1005494 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXTranslationWorkPublished: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005494

Change 1005465 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXSuggestionList: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005465

Change 1005135 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXQuickTutorial: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005135

Change 1004756 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] TranslatedSegmentCardActionButtons: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1004756

Change 1005956 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXPublisherCaptchaDialog: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005956

Change 1005958 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240223

https://gerrit.wikimedia.org/r/1005958

Change 1005958 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240223

https://gerrit.wikimedia.org/r/1005958

Change 1005453 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXDashboard: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005453

Change 1005956 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXPublisherCaptchaDialog: Use CdxButton and CdxIcon components

https://gerrit.wikimedia.org/r/1005956

Change 1008417 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Recent translation entrypoint: Use codex CSS buttons and icons

https://gerrit.wikimedia.org/r/1008417

Change 1008417 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Recent translation entrypoint: Use codex CSS buttons and icons

https://gerrit.wikimedia.org/r/1008417

Change 1009491 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmerArticleInformation: Use codex components

https://gerrit.wikimedia.org/r/1009491

Change 1009491 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmerArticleInformation: Use codex components

https://gerrit.wikimedia.org/r/1009491

Change 1010162 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240311

https://gerrit.wikimedia.org/r/1010162

Change 1010162 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240311

https://gerrit.wikimedia.org/r/1010162

The module codex-search-styles should be loaded instead

This module is about to be deprecated, see T356675. I've filed T360223 as a subtask of that task for migrating away from codex-search-styles in CX in favor of CodexModule.

@Pginer-WMF regarding this task, all subtasks listed in the task description have been completed. Only a few buttons are remaining to be replaced with Codex buttons inside Section Translation, but this is a very small portion of the effort required for this task, and can be tracked in another small task, once we decide to work on this again (which won't be too soon). I'm suggesting to close this task as done. Replacing the deprecated codex-search-styles module can be tracked in T360223, as Roan suggests above.