Description

Please help us migrate from mediawiki ui to Codex.

After switching to Codex for our buttons for Vector, we should update the markup
See example for ULS @ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/932470

Checklist

The module mediawiki.ui.button should not be loaded
The module codex-search-styles should be loaded instead
Change markup of buttons to match Codex. Details on input markup can be found here: https://doc.wikimedia.org/codex/latest/components/demos/button.html#css-only-version

QA

Buttons on https://en.wikipedia.org/wiki/Special:Nearby when inspected in developer console should use cdx-button markup e.g. cdx-button class

QA Results - Prod

AC	Status	Details
1	✅	T340260#9237034

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Drop unused mediawiki ui button styles	mediawiki/extensions/NearbyPages	master	+1 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		Jdlrobson	T182050 Remove all mediawiki.ui components and libraries in favor of Codex
		Resolved	BUG REPORT	Jdlrobson	T340260 NearbyPages should be updated to use Codex markup

Event Timeline

Jdlrobson created this task.Jun 23 2023, 8:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2023, 8:57 PM

Jdlrobson added a parent task: T182050: Remove all mediawiki.ui components and libraries in favor of Codex.Jun 23 2023, 8:58 PM

Jdlrobson triaged this task as Medium priority.Jun 23 2023, 9:00 PM

Jdlrobson moved this task from Backlog to Adopt Codex in Vector 2022 and Minerva on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.

Change 958996 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/NearbyPages@master] Drop unused mediawiki ui button styles

https://gerrit.wikimedia.org/r/958996

gerritbot added a project: Patch-For-Review.Sep 19 2023, 4:29 PM

Jdlrobson moved this task from Adopt Codex in Vector 2022 and Minerva to Using Codex in web team products / Skin unification on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Sep 19 2023, 4:44 PM

Change 958996 merged by jenkins-bot:

[mediawiki/extensions/NearbyPages@master] Drop unused mediawiki ui button styles

https://gerrit.wikimedia.org/r/958996

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2023, 7:32 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.29; 2023-10-03).Sep 26 2023, 8:00 PM

Jdlrobson closed this task as Resolved.Sep 26 2023, 10:07 PM

Jdlrobson claimed this task.

Jdlrobson edited projects, added: Web-Team-Backlog-Archived (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)); removed: Web-Team-Backlog-Archived (Needs Prioritization (Tech)).

Jdlrobson updated the task description. (Show Details)Oct 6 2023, 9:08 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Buttons on https://en.wikipedia.org/wiki/Special:Nearby when inspected in developer console should use cdx-button markup e.g. cdx-button class

screenshot 116.png (978×1,160 px, 309 KB)

Edtadros added a project: Verified.Oct 9 2023, 9:49 PM

Edtadros updated the task description. (Show Details)

Jdlrobson moved this task from Incoming to Ready for Signoff on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.Oct 10 2023, 5:05 PM

	F38171508: screenshot 116.png
	Oct 9 2023, 9:48 PM

NearbyPages should be updated to use Codex markupClosed, ResolvedPublicBUG REPORTActions