Failing to create a newsletter should not add a row to the database
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Pppery
	Jun 24 2023, 6:17 PM

Description

Per @taavi on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Newsletter/+/446642/

If a newsletter page fails to be created (due to an abuse filter or for some other reason), it still inserts a row to the nw_newsletters table with nl_active = 0. That table has an unique key on nl_name, which means the name can't be re-used again.

Details

	Subject	Repo	Branch	Lines +/-
	Remove database changes from UI layer	mediawiki/extensions/Newsletter	master	+26 -80

Customize query in gerrit

Related Objects

Mentioned In: T132022: Add AbuseFilter integration to Extension:Newsletter

Event Timeline

Pppery created this task.Jun 24 2023, 6:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2023, 6:17 PM

Pppery mentioned this in T132022: Add AbuseFilter integration to Extension:Newsletter.Jun 24 2023, 6:18 PM

Pppery claimed this task.Jun 24 2023, 6:26 PM

Change 932538 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/Newsletter@master] Remove database changes from UI layer

https://gerrit.wikimedia.org/r/932538

gerritbot added a project: Patch-For-Review.Jun 24 2023, 6:52 PM

Change 932538 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Remove database changes from UI layer

https://gerrit.wikimedia.org/r/932538

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2023, 9:10 PM

Pppery closed this task as Resolved.Jun 25 2023, 9:22 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 25 2023, 10:00 PM

Failing to create a newsletter should not add a row to the databaseClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Failing to create a newsletter should not add a row to the database
Closed, ResolvedPublicBUG REPORT
Actions