The customization in T196835 regressed at some point. modules/gerrit/files/site/etc/GerritSiteFooter.html exists but seems to be ignored.
Upstream docs at https://gerrit-review.googlesource.com/Documentation/config-themes.html
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Fix wm-custom-links to show links in footer again | Paladox | operations/software/gerrit | deploy/wmf/stable-3.5 | +14 -17 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 932641 had a related patch set uploaded (by Paladox; author: Paladox):
[operations/software/gerrit@deploy/wmf/stable-3.5] Fix wm-custom-links to show links in footer again
Comment Actions
Change 932641 merged by jenkins-bot:
[operations/software/gerrit@deploy/wmf/stable-3.5] Fix wm-custom-links to show links in footer again
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2023-06-28T13:42:21Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@1ae182f]: Fix wm-custom-links to show links in footer again - T340372
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2023-06-28T13:42:29Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@1ae182f]: Fix wm-custom-links to show links in footer again - T340372 (duration: 00m 08s)
Comment Actions
I am not sure why it broke, it either comes from:
- the split of the old javascript file to multiple files (plugins/wm-custom-links). Although I am pretty sure I tested it, I might forgot to ensure the new files were properly loaded
- the script ceased to work at some point during one of the Gerrit upgrade.
I haven't investigated further, @Paladox patch fixes it and is one the recommended to inject HTML elements :]