Page MenuHomePhabricator

Can't recreate deleted newsletter
Open, Needs TriagePublicBUG REPORT


Steps to replicate the issue (include links if applicable):

  • Delete a newsletter
  • Try to recreate another newsletter with the same name
  • (after that fails) Try to move an already existing newsletter to that name

What happens?:

The creation fails with "A newsletter with the name "H" already exists. Please try again with another name."

The move spews a warning and appears to succeed but leaves the newsletter database in an inconsistent state

What should have happened instead?:

Both creation attempts succeeded

Other information (browser name/version, screenshots, etc.):

This is due to the nl_name key being unique, which doesn't quite match the conceptual model

Event Timeline

Note: Once the schema-change part of this is done we need to decide how to handle attempted history merges (multiple deleted newsletters with the same name). Ideally we would use page ids to determine which page is associated with the latest revision, but I'm not sure that's actually practical.

Change 977269 had a related patch set uploaded (by Pppery; author: olumpatwit):

[mediawiki/extensions/Newsletter@master] Schema change to drop unique bit from indexes that aren't quite unique