Maniphest T340461

'Add image' claims '1 image' was added, only dummy change saved
Closed, DuplicatePublicBUG REPORT
Actions

Assigned To

None

Authored By

	matej_suchanek
	Jun 26 2023, 4:38 PM

Project Tags

Referenced Files

None

Subscribers

Description

https://cs.wikipedia.org/w/index.php?title=Neutronov%C3%A1_bomba&diff=prev&oldid=22918378
The edit summary says "Added 1 image.", but no image was actually added.

Not sure what happened:

User chose to add an image, but it was not added - bug.
User chose not to add an image - bug (the edit summary is wrong).

Similar to T333673: 'Add links' saves 0 links, makes a dummy edit.

Related Objects

Mentioned In: T340532: Structured tasks should never make an edit when the user rejects the recommendation
T340530: Image recommendation structured tasks should use an appropriate edit summary on rejection
Mentioned Here: T340530: Image recommendation structured tasks should use an appropriate edit summary on rejection
T340532: Structured tasks should never make an edit when the user rejects the recommendation
T340235: Section-level images: Check for dirty diffs
T333673: 'Add links' saves 0 links, makes a dummy edit

Event Timeline

matej_suchanek created this task.Jun 26 2023, 4:38 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 26 2023, 4:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

kostajh triaged this task as High priority.Jun 26 2023, 4:41 PM

kostajh edited projects, added: Growth-Team (Sprint 0 (Growth Team)), Section-Level-Image-Suggestions; removed: Growth-Team.

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Tgr updated the task description. (Show Details)Jun 26 2023, 5:11 PM

User chose not to add an image - bug (the edit summary is wrong).

Very likely that. The wrong edit summary is a known bug (since it's not supposed to save the page when the user doesn't add an image, we didn't bother to set the edit summary appropriately - we should probably fix that).

T340235: Section-level images: Check for dirty diffs is about the same issue for section-level images.

Tgr mentioned this in T340530: Image recommendation structured tasks should use an appropriate edit summary on rejection.Jun 27 2023, 9:13 AM

Tgr mentioned this in T340532: Structured tasks should never make an edit when the user rejects the recommendation.Jun 27 2023, 9:26 AM

Tgr closed this task as a duplicate of T340532: Structured tasks should never make an edit when the user rejects the recommendation.Jun 27 2023, 9:29 AM

Filed T340532: Structured tasks should never make an edit when the user rejects the recommendation and T340530: Image recommendation structured tasks should use an appropriate edit summary on rejection.