Page MenuHomePhabricator

Update MultimediaViewer for IP Masking
Closed, ResolvedPublic

Description

IP Masking means that we create a temporary account for any user that's editing without being logged in. More details on how temporary account work here, and more details on what to look for when adapting an extension to handle temporary accounts is here

A quick search for relevant code in the MultiMediaViewer extension is here

We'll need to consider whether to change isAnon and isRegistered, and test everything to make sure it still works when logged in as a temp user or a regular user or not logged in at all.

To enable temporary accounts in your local dev env, add this to LocalSettings.php

$wgAutoCreateTempUser['enabled'] = true;

Details

Related Changes in Gerrit:

Event Timeline

@Cparle: Assuming this task is about the MediaViewer code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks!

Change 935392 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/MultimediaViewer@master] IP masking update

https://gerrit.wikimedia.org/r/935392

The patch above uses localstorage to store MMV preference for anon and temp users, and uses the regular user preference for non-temp accounts only

For embed default to wikitext for temp and regular users, html for anon users

Change 935392 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] IP masking update

https://gerrit.wikimedia.org/r/935392

Etonkovidova subscribed.

QA notes: temporary accounts are enabled on beta dewiki

Thanks, @Cparle! Tested MultimediaViewer on dewiki betawmflabs - no changes in functionality comparing to anon user.

Testing notes for post-deployment testing

@Etonkovidova ... so, is this as "done" as it's possible to get for now?

@Etonkovidova ... so, is this as "done" as it's possible to get for now?

@Cparle - I moved this task to Verify on Production basically to have a reminder to check MultimediaViewer for temp users. After IP masking deployment, I'll do a quick check according to the task spec:

We'll need to consider whether to change isAnon and isRegistered, and test everything to make sure it still works when logged in as a temp user or a regular user or not logged in at all.

I reviewed this task testing scope (and T329459: [L] IP Masking Considerations: MachineVision ) and I agree now with @Cparle - both tasks could be marked as resolved. IP-masking related testing in production will be done as part of T341839: [QA task] IP masking - temp users testing in production.