Page MenuHomePhabricator
Create Task
Maniphest T340552

Implement and wire-up minimal OpenTelemetry tracing client compatible with OTEL data model
Open, MediumPublic
Actions

Description

At the Hackathon, @TK-999 wrote a proof-of-concept patch integrating Mediawiki with the OTel library, including creation of Spans for database queries. We're requesting a few passes of code review on this patch, beginning with any architectural issues and an estimate of how much more work is needed.

Some docs on what features & extra data you can get by linking against instrumentation: https://opentelemetry.io/docs/concepts/instrumentation/libraries/

Docs on the PHP library: https://opentelemetry.io/docs/instrumentation/php/

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[DNM] proof-of-concept of Telemetry/TracerStatemediawiki/coremaster+65 -3
Telemetry: allow mutation of trace contextmediawiki/coremaster+40 -3
Implement fake-able hrtime(), deprecate microtime()mediawiki/libs/Timestampmaster+89 -34
doc: SpanInterface: more dev-friendly commentsmediawiki/coremaster+48 -24
Trace only on k8s. operations/mediawiki-configmaster+9 -8
doc: add warning re: telemetry headersmediawiki/coremaster+7 -1
WANObjectCache: trace basic operationsmediawiki/coremaster+80 -1
objectcache: Require a TracerInterface in ObjectCacheFactorymediawiki/coremaster+16 -3
ObjectCacheFactory: use Tracer telemetrymediawiki/coremaster+11 -12
telemetry: Factor out context propagationmediawiki/coremaster+317 -48
urldownloader: scrub outbound privacy-sensitive hdrsoperations/puppetproduction+6 -0
telemetry: Add propagator testsmediawiki/coremaster+199 -0
HttpRequestFactory: use Tracer telemetrymediawiki/coremaster+4 -3
OpenTelemetry tracing to all wikisoperations/mediawiki-configmaster+1 -7
group1: enable OpenTelemetry exportsoperations/mediawiki-configmaster+5 -0
Database: tracing: emit row respose statsmediawiki/coremaster+7 -0
tracing: Disable tracing in CLI modemediawiki/corewmf/1.44.0-wmf.11+1 -1
tracing: Disable tracing in CLI modemediawiki/coremaster+1 -1
group0: enable OpenTelemetry exportsoperations/mediawiki-configmaster+9 -0
Tracing: span statuses for root spansmediawiki/coremaster+16 -3
Tracing: add span statusesmediawiki/coremaster+54 -0
Database: tracing: query errors => span errormediawiki/coremaster+3 -1
Span: fluentize activate()/deactivate()mediawiki/coremaster+13 -10
Setup: tracing: tweak the root span namemediawiki/coremaster+1 -1
Database: prefix tracing operation namesmediawiki/coremaster+2 -2
ParserOutputAccess: add tracing spansmediawiki/coremaster+40 -4
PoolCounter: holding-the-lock otel spansmediawiki/coremaster+36 -2
NoopSpan: optionally activatemediawiki/coremaster+14 -7
Setup: parse incoming traceparent headermediawiki/coremaster+102 -3
rdbms: Inject a Tracer into the DatabaseFactory servicemediawiki/coremaster+4 -1
Rdbms\Database: export OTel spans for db operationsmediawiki/coremaster+63 -4
Add request-level OpenTelemetry instrumentationmediawiki/coremaster+87 -0
Introduce minimal OTEL tracing librarymediawiki/coremaster+2 K -0
[DNM] Add basic OpenTelemetry instrumentationmediawiki/coremaster+643 -5
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
• larissagaulia moved this task from Inbox, needs triage to Waiting on the MediaWiki-Platform-Team board.Aug 26 2024, 2:54 PM
Krinkle moved this task from Inbox, needs triage to MW Platform Team on the MediaWiki-Engineering board.Aug 28 2024, 9:33 AM
Dringsim subscribed.Sep 13 2024, 2:21 PM
gerritbot added a comment.Sep 23 2024, 6:12 PM

Change #1062104 merged by jenkins-bot:

[mediawiki/libs/Timestamp@master] Implement fake-able hrtime(), deprecate microtime()

https://gerrit.wikimedia.org/r/1062104

gerritbot added a comment.Sep 30 2024, 11:46 AM

Change #1027519 abandoned by Máté Szabó:

[mediawiki/core@master] [DNM] Add basic OpenTelemetry instrumentation

Reason:

Superseded by Ibc3910058cd7ed064cad293a3cdc091344e66b86.

https://gerrit.wikimedia.org/r/1027519

gerritbot added a comment.Oct 10 2024, 5:33 PM

Change #1061573 merged by jenkins-bot:

[mediawiki/core@master] Introduce minimal OTEL tracing library

https://gerrit.wikimedia.org/r/1061573

pmiazga renamed this task from MediaWiki imports OpenTelemetry client instrumentation library for enhanced trace metadata to Implement and wire-up minimal OpenTelemetry tracing client compatible with OTEL data model.Oct 11 2024, 2:53 PM
pmiazga added a comment.Oct 11 2024, 3:14 PM

Updated ticket title to match the current state of things. yesterday we merged the minimal OTEL tracing library. Thank you @mszabo for great work!.

The remaining steps are:

  1. Decide whether we need to discuss the RAII implications more (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1061573/comments/6d9c0d1e_23dcce5b?tab=comments).

@mszabo found an issue when we have multiple spans inside same function. The spans are auto-ended when PHP gets out of function, not out of the scope where span was created. IMHO we | should treat RAII as syntax sugar/fallback and expect engineers to start/end spans manually. The RAII would be a prevention mechanism when PHP jumps out of scope (because of exception) to make sure we auto deactivate and end open spans.

  1. implement logic to skip sampling and respect traceparent header. When the header is present the sampling logic shouldn't trigger, instead it should trace the request.
  2. wire up the library with MediaWiki logic, eg start a root span.
  3. instrument database calls
  4. update places where Telemetry::getRequestHeaders is used and instrument it with (Http factories/MWRequest/etc)
  5. update wmf-configs - set sampling rate to 0% as we shouldn't sample by our own, only depend on header existence.

@CDanis @Krinkle - what do you think would be the best areas to instrument? IMHO we should wrap entire request with a root span and instrument Database calls and the HTTPFactory. We could instrument the Parser too. For the first run we should keep it small.

@mszabo when testing the library I noticed that it may be tricky to find a good place where to start root span and call the shutdown/export. Initially, I followed the POC and started instrumentation in the MediaWikiEntryPoint, but might seem bit late. I tried to instrument all hooks and discovered that when we get to MediaWikiEntryPoint::setup - some hooks are already called.

CDanis added a comment.Oct 15 2024, 3:33 PM
In T340552#10221676, @pmiazga wrote:

@CDanis @Krinkle - what do you think would be the best areas to instrument? IMHO we should wrap entire request with a root span and instrument Database calls and the HTTPFactory. We could instrument the Parser too. For the first run we should keep it small.

+1 to all.

If you wanted something even smaller to instrument as a starting point, PoolCounter locks wouldn't be bad either.

CDanis added a comment.Oct 18 2024, 5:45 PM

@pmiazga @mszabo will either one of you have some time soon to at least do #3 above? That's the one I know the least about.

• mszabo added a comment.Oct 21 2024, 5:53 AM
In T340552#10242985, @CDanis wrote:

@pmiazga @mszabo will either one of you have some time soon to at least do #3 above? That's the one I know the least about.

Sure thing, I'll polish https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1061574 and that should do the trick

Krinkle removed a project: MediaWiki-Engineering.Nov 13 2024, 2:37 PM
gerritbot added a comment.Nov 26 2024, 10:51 AM

Change #1061574 merged by jenkins-bot:

[mediawiki/core@master] Add request-level OpenTelemetry instrumentation

https://gerrit.wikimedia.org/r/1061574

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.6; 2024-12-03).Nov 26 2024, 11:00 AM
gerritbot added a comment.Dec 19 2024, 8:01 PM

Change #1105792 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] Rdbms\Database: export OTel spans for db operations

https://gerrit.wikimedia.org/r/1105792

gerritbot added a comment.Dec 20 2024, 4:38 PM

Change #1105816 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] Setup: parse incoming traceparent header

https://gerrit.wikimedia.org/r/1105816

gerritbot added a comment.Dec 20 2024, 6:24 PM

Change #1105940 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] rdbms: Inject a Tracer into the DatabaseFactory service

https://gerrit.wikimedia.org/r/1105940

gerritbot added a comment.Dec 20 2024, 6:38 PM

Change #1105792 merged by jenkins-bot:

[mediawiki/core@master] Rdbms\Database: export OTel spans for db operations

https://gerrit.wikimedia.org/r/1105792

gerritbot added a comment.Dec 20 2024, 7:00 PM

Change #1105940 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Inject a Tracer into the DatabaseFactory service

https://gerrit.wikimedia.org/r/1105940

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.12; 2025-01-14); removed MW-1.44-notes (1.44.0-wmf.6; 2024-12-03).Dec 20 2024, 7:00 PM
gerritbot added a comment.Dec 20 2024, 10:34 PM

Change #1105955 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] telemetry: Factor out context propagation

https://gerrit.wikimedia.org/r/1105955

gerritbot added a comment.Dec 23 2024, 9:44 AM

Change #1105816 merged by jenkins-bot:

[mediawiki/core@master] Setup: parse incoming traceparent header

https://gerrit.wikimedia.org/r/1105816

gerritbot added a comment.Jan 3 2025, 3:40 PM

Change #1108083 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] draft: holding-the-lock spans for PoolCounters

https://gerrit.wikimedia.org/r/1108083

gerritbot added a comment.Jan 3 2025, 8:15 PM

Change #1108117 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] NoopSpan: optionally activate

https://gerrit.wikimedia.org/r/1108117

gerritbot added a comment.Jan 3 2025, 9:56 PM

Change #1108117 merged by jenkins-bot:

[mediawiki/core@master] NoopSpan: optionally activate

https://gerrit.wikimedia.org/r/1108117

Marostegui subscribed.Jan 6 2025, 4:08 PM
gerritbot added a comment.Jan 6 2025, 4:42 PM

Change #1108083 merged by jenkins-bot:

[mediawiki/core@master] PoolCounter: holding-the-lock otel spans

https://gerrit.wikimedia.org/r/1108083

gerritbot added a comment.Jan 6 2025, 6:55 PM

Change #1108463 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] ParserOutputAccess: add tracing spans

https://gerrit.wikimedia.org/r/1108463

gerritbot added a comment.Jan 6 2025, 7:07 PM

Change #1108467 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] Database: prefix tracing operation names

https://gerrit.wikimedia.org/r/1108467

gerritbot added a comment.Jan 6 2025, 7:57 PM

Change #1108463 merged by jenkins-bot:

[mediawiki/core@master] ParserOutputAccess: add tracing spans

https://gerrit.wikimedia.org/r/1108463

gerritbot added a comment.Jan 6 2025, 8:00 PM

Change #1108467 merged by jenkins-bot:

[mediawiki/core@master] Database: prefix tracing operation names

https://gerrit.wikimedia.org/r/1108467

gerritbot added a comment.Jan 6 2025, 8:54 PM

Change #1108481 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] Setup: tracing: tweak the root span name

https://gerrit.wikimedia.org/r/1108481

gerritbot added a comment.Jan 6 2025, 9:53 PM

Change #1108481 merged by jenkins-bot:

[mediawiki/core@master] Setup: tracing: tweak the root span name

https://gerrit.wikimedia.org/r/1108481

gerritbot added a comment.Jan 7 2025, 3:20 PM

Change #1108766 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] Tracing: add span statuses

https://gerrit.wikimedia.org/r/1108766

gerritbot added a comment.Jan 7 2025, 3:27 PM

Change #1108767 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] Span: fluentize activate()/deactivate()

https://gerrit.wikimedia.org/r/1108767

gerritbot added a comment.Jan 7 2025, 3:32 PM

Change #1108771 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] Database: tracing: query errors => span error

https://gerrit.wikimedia.org/r/1108771

gerritbot added a comment.Jan 7 2025, 4:17 PM

Change #1108767 merged by jenkins-bot:

[mediawiki/core@master] Span: fluentize activate()/deactivate()

https://gerrit.wikimedia.org/r/1108767

gerritbot added a comment.Jan 7 2025, 4:18 PM

Change #1108766 merged by jenkins-bot:

[mediawiki/core@master] Tracing: add span statuses

https://gerrit.wikimedia.org/r/1108766

gerritbot added a comment.Jan 7 2025, 4:23 PM

Change #1108771 merged by jenkins-bot:

[mediawiki/core@master] Database: tracing: query errors => span error

https://gerrit.wikimedia.org/r/1108771

gerritbot added a comment.Jan 7 2025, 4:32 PM

Change #1108783 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] Tracing: span statuses for root spans

https://gerrit.wikimedia.org/r/1108783

gerritbot added a comment.Jan 7 2025, 5:35 PM

Change #1108783 merged by jenkins-bot:

[mediawiki/core@master] Tracing: span statuses for root spans

https://gerrit.wikimedia.org/r/1108783

gerritbot added a comment.Jan 7 2025, 6:07 PM

Change #1108802 had a related patch set uploaded (by CDanis; author: CDanis):

[operations/mediawiki-config@master] group0: enable OpenTelemetry exports

https://gerrit.wikimedia.org/r/1108802

gerritbot added a comment.Jan 7 2025, 7:59 PM

Change #1108802 merged by jenkins-bot:

[operations/mediawiki-config@master] group0: enable OpenTelemetry exports

https://gerrit.wikimedia.org/r/1108802

Stashbot added a comment.Jan 7 2025, 8:00 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-07T20:00:38Z] <cdanis@deploy2002> Started scap sync-world: Backport for [[gerrit:1108802|group0: enable OpenTelemetry exports (T340552)]]

Stashbot added a comment.Jan 7 2025, 8:07 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-07T20:07:35Z] <cdanis@deploy2002> cdanis: Backport for [[gerrit:1108802|group0: enable OpenTelemetry exports (T340552)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 7 2025, 8:16 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-07T20:16:45Z] <cdanis@deploy2002> Finished scap sync-world: Backport for [[gerrit:1108802|group0: enable OpenTelemetry exports (T340552)]] (duration: 16m 06s)

gerritbot added a comment.Jan 7 2025, 9:40 PM

Change #1105949 had a related patch set uploaded (by CDanis; author: Máté Szabó):

[mediawiki/core@master] tracing: Disable tracing in CLI mode

https://gerrit.wikimedia.org/r/1105949

gerritbot added a comment.Jan 7 2025, 10:27 PM

Change #1105949 merged by jenkins-bot:

[mediawiki/core@master] tracing: Disable tracing in CLI mode

https://gerrit.wikimedia.org/r/1105949

gerritbot added a comment.Jan 7 2025, 10:59 PM

Change #1108850 had a related patch set uploaded (by CDanis; author: Máté Szabó):

[mediawiki/core@wmf/1.44.0-wmf.11] tracing: Disable tracing in CLI mode

https://gerrit.wikimedia.org/r/1108850

gerritbot added a comment.Jan 7 2025, 11:20 PM

Change #1108850 merged by jenkins-bot:

[mediawiki/core@wmf/1.44.0-wmf.11] tracing: Disable tracing in CLI mode

https://gerrit.wikimedia.org/r/1108850

Stashbot added a comment.Jan 7 2025, 11:20 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-07T23:20:48Z] <cdanis@deploy2002> Started scap sync-world: Backport for [[gerrit:1108850|tracing: Disable tracing in CLI mode (T340552)]]

Stashbot added a comment.Jan 7 2025, 11:27 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-07T23:27:02Z] <cdanis@deploy2002> cdanis: Backport for [[gerrit:1108850|tracing: Disable tracing in CLI mode (T340552)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 7 2025, 11:35 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-07T23:35:12Z] <cdanis@deploy2002> Finished scap sync-world: Backport for [[gerrit:1108850|tracing: Disable tracing in CLI mode (T340552)]] (duration: 14m 23s)

gerritbot added a comment.Jan 8 2025, 2:38 AM

Change #1108869 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] Database: tracing: emit row respose stats

https://gerrit.wikimedia.org/r/1108869

gerritbot added a comment.Jan 8 2025, 2:18 PM

Change #1108869 merged by jenkins-bot:

[mediawiki/core@master] Database: tracing: emit row respose stats

https://gerrit.wikimedia.org/r/1108869

gerritbot added a comment.Jan 8 2025, 7:27 PM

Change #1109133 had a related patch set uploaded (by CDanis; author: CDanis):

[operations/mediawiki-config@master] group1: enable OpenTelemetry exports

https://gerrit.wikimedia.org/r/1109133

gerritbot added a comment.Jan 9 2025, 3:39 PM

Change #1109442 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] Telemetry: allow mutation of trace context

https://gerrit.wikimedia.org/r/1109442

gerritbot added a comment.Jan 9 2025, 4:48 PM

Change #1109133 merged by jenkins-bot:

[operations/mediawiki-config@master] group1: enable OpenTelemetry exports

https://gerrit.wikimedia.org/r/1109133

Stashbot added a comment.Jan 9 2025, 4:48 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-09T16:48:33Z] <cdanis@deploy2002> Started scap sync-world: Backport for [[gerrit:1109133|group1: enable OpenTelemetry exports (T340552)]]

Stashbot added a comment.Jan 9 2025, 4:53 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-09T16:53:42Z] <cdanis@deploy2002> cdanis: Backport for [[gerrit:1109133|group1: enable OpenTelemetry exports (T340552)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 9 2025, 5:02 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-09T17:02:56Z] <cdanis@deploy2002> Finished scap sync-world: Backport for [[gerrit:1109133|group1: enable OpenTelemetry exports (T340552)]] (duration: 14m 22s)

gerritbot added a comment.Jan 10 2025, 2:00 PM

Change #1109706 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] [DNM] proof-of-concept of Telemetry/TracerState

https://gerrit.wikimedia.org/r/1109706

gerritbot added a comment.Jan 10 2025, 3:07 PM

Change #1109717 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] HttpRequestFactory: use Tracer telemetry

https://gerrit.wikimedia.org/r/1109717

gerritbot added a comment.Jan 10 2025, 3:52 PM

Change #1107971 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] WANObjectCache: trace basic operations

https://gerrit.wikimedia.org/r/1107971

gerritbot added a comment.Jan 10 2025, 4:40 PM

Change #1105955 merged by jenkins-bot:

[mediawiki/core@master] telemetry: Factor out context propagation

https://gerrit.wikimedia.org/r/1105955

gerritbot added a comment.Jan 10 2025, 6:02 PM

Change #1109754 had a related patch set uploaded (by CDanis; author: CDanis):

[operations/mediawiki-config@master] OpenTelemetry tracing to all wikis

https://gerrit.wikimedia.org/r/1109754

gerritbot added a comment.Jan 13 2025, 5:10 PM

Change #1109754 merged by jenkins-bot:

[operations/mediawiki-config@master] OpenTelemetry tracing to all wikis

https://gerrit.wikimedia.org/r/1109754

Stashbot added a comment.Jan 13 2025, 5:11 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-13T17:11:03Z] <cdanis@deploy2002> Started scap sync-world: Backport for [[gerrit:1109754|OpenTelemetry tracing to all wikis (T340552)]]

Stashbot added a comment.Jan 13 2025, 5:15 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-13T17:15:51Z] <cdanis@deploy2002> cdanis: Backport for [[gerrit:1109754|OpenTelemetry tracing to all wikis (T340552)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 13 2025, 5:25 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-13T17:25:04Z] <cdanis@deploy2002> Finished scap sync-world: Backport for [[gerrit:1109754|OpenTelemetry tracing to all wikis (T340552)]] (duration: 14m 00s)

gerritbot added a comment.Jan 14 2025, 2:20 AM

Change #1109717 merged by jenkins-bot:

[mediawiki/core@master] HttpRequestFactory: use Tracer telemetry

https://gerrit.wikimedia.org/r/1109717

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.13; 2025-01-21); removed MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Jan 14 2025, 3:00 AM
gerritbot added a comment.Jan 14 2025, 3:43 PM

Change #1111265 had a related patch set uploaded (by CDanis; author: CDanis):

[operations/puppet@production] urldownloader: scrub outbound privacy-sensitive hdrs

https://gerrit.wikimedia.org/r/1111265

gerritbot added a comment.Jan 15 2025, 7:07 PM

Change #1111687 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] telemetry: Add propagator tests

https://gerrit.wikimedia.org/r/1111687

gerritbot added a comment.Jan 16 2025, 2:58 PM

Change #1111687 merged by jenkins-bot:

[mediawiki/core@master] telemetry: Add propagator tests

https://gerrit.wikimedia.org/r/1111687

gerritbot added a comment.Jan 16 2025, 6:50 PM

Change #1111265 merged by CDanis:

[operations/puppet@production] urldownloader: scrub outbound privacy-sensitive hdrs

https://gerrit.wikimedia.org/r/1111265

gerritbot added a comment.Jan 27 2025, 5:16 PM

Change #1114424 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] ObjectCacheFactory: use Tracer telemetry

https://gerrit.wikimedia.org/r/1114424

gerritbot added a comment.Jan 28 2025, 1:44 AM

Change #1114479 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] objectcache: Require a TracerInterface in ObjectCacheFactory

https://gerrit.wikimedia.org/r/1114479

gerritbot added a comment.Jan 28 2025, 2:06 AM

Change #1114424 merged by jenkins-bot:

[mediawiki/core@master] ObjectCacheFactory: use Tracer telemetry

https://gerrit.wikimedia.org/r/1114424

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.15; 2025-02-04); removed MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).Jan 28 2025, 3:00 AM
gerritbot added a comment.Jan 28 2025, 12:41 PM

Change #1114479 merged by jenkins-bot:

[mediawiki/core@master] objectcache: Require a TracerInterface in ObjectCacheFactory

https://gerrit.wikimedia.org/r/1114479

gerritbot added a comment.Jan 30 2025, 2:08 PM

Change #1115390 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] doc: SpanInterface: more dev-friendly comments

https://gerrit.wikimedia.org/r/1115390

gerritbot added a comment.Jan 30 2025, 2:23 PM

Change #1115398 had a related patch set uploaded (by CDanis; author: CDanis):

[mediawiki/core@master] doc: add warning re: telemetry headers

https://gerrit.wikimedia.org/r/1115398

gerritbot added a comment.Jan 30 2025, 2:41 PM

Change #1107971 merged by jenkins-bot:

[mediawiki/core@master] WANObjectCache: trace basic operations

https://gerrit.wikimedia.org/r/1107971

gerritbot added a comment.Jan 30 2025, 3:01 PM

Change #1115398 merged by jenkins-bot:

[mediawiki/core@master] doc: add warning re: telemetry headers

https://gerrit.wikimedia.org/r/1115398

gerritbot added a comment.Jan 30 2025, 3:37 PM

Change #1115436 had a related patch set uploaded (by CDanis; author: CDanis):

[operations/mediawiki-config@master] Trace only on k8s. Not (yet?) available on bare metal

https://gerrit.wikimedia.org/r/1115436

gerritbot added a comment.Jan 30 2025, 4:05 PM

Change #1115436 merged by jenkins-bot:

[operations/mediawiki-config@master] Trace only on k8s.

https://gerrit.wikimedia.org/r/1115436

Stashbot added a comment.Jan 30 2025, 4:06 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-30T16:06:01Z] <cdanis@deploy2002> Started scap sync-world: Backport for [[gerrit:1115436|Trace only on k8s. (T321211 T340552 T385037)]]

Stashbot mentioned this in T385037: mwdebug dashboard on logstash is full of "Failed to connect to exporter" messages (tracing channel) since 7 January.Jan 30 2025, 4:06 PM
Stashbot mentioned this in T321211: distributed tracing v1: tech debt blockers.
Stashbot added a comment.Jan 30 2025, 4:09 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-30T16:09:45Z] <cdanis@deploy2002> cdanis: Backport for [[gerrit:1115436|Trace only on k8s. (T321211 T340552 T385037)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 30 2025, 4:17 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-30T16:17:57Z] <cdanis@deploy2002> Finished scap sync-world: Backport for [[gerrit:1115436|Trace only on k8s. (T321211 T340552 T385037)]] (duration: 11m 55s)

gerritbot added a comment.Feb 4 2025, 11:40 AM

Change #1115390 merged by jenkins-bot:

[mediawiki/core@master] doc: SpanInterface: more dev-friendly comments

https://gerrit.wikimedia.org/r/1115390

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.16; 2025-02-11); removed MW-1.44-notes (1.44.0-wmf.15; 2025-02-04).Feb 4 2025, 12:00 PM
Krinkle reassigned this task from Krinkle to CDanis.EditedMay 26 2025, 12:56 AM
Krinkle edited projects, added MediaWiki-Platform-Team (Radar); removed MW-1.44-notes (1.44.0-wmf.16; 2025-02-11), MediaWiki-Platform-Team.

The assignment in T340552#10038643 was to review the intial core lib, which is done, and I haven't looked at it much since. The expanded instrumention added since is great, and I've seen it work in Jaeger. Un-assiginging to reflect reality. Feel free to tag MediaWiki-Engineering back if you need anything!

gerritbot added a comment.Oct 15 2025, 7:20 PM

Change #1109442 abandoned by CDanis:

[mediawiki/core@master] Telemetry: allow mutation of trace context

Reason:

Ib1cf361dd800c81a7943231441d58c790191ef5a

https://gerrit.wikimedia.org/r/1109442

gerritbot added a comment.Oct 15 2025, 7:21 PM

Change #1109706 abandoned by CDanis:

[mediawiki/core@master] [DNM] proof-of-concept of Telemetry/TracerState

Reason:

Ib1cf361dd800c81a7943231441d58c790191ef5a

https://gerrit.wikimedia.org/r/1109706

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits