Page MenuHomePhabricator

Ensure UserGroupManager::addUserToGroup is not called on temporary users from AbuseFilter extension
Closed, ResolvedPublic2 Estimated Story Points

Description

Following T340470, Ensure that UserGroupManager::addUserToGroup is not called on temporary users in AbuseFilter extension
Link to code search where calls are made can be found here

Related Objects

StatusSubtypeAssignedTask
In ProgressNiharika
OpenNone
OpenTchanders
OpenNone
ResolvedSTran
ResolvedUmherirrender
Resolved AGueyte
Duplicate AGueyte
ResolvedSTran
ResolvedDreamy_Jazz
OpenSTran
OpenSTran
OpenSTran
OpenSTran
OpenSTran
OpenNone
OpenNone
OpenNone
OpenSTran
ResolvedSTran
ResolvedBUG REPORTDreamy_Jazz
OpenNone
Resolved TThoabala
Resolved TThoabala
Resolved TThoabala
Resolved AGueyte
ResolvedBUG REPORT AGueyte
ResolvedBUG REPORT AGueyte
Resolved AGueyte
Resolved AGueyte
ResolvedCyndymediawiksim
DuplicateNone
OpenNone
ResolvedTchanders
Resolved TThoabala
Resolved AGueyte

Event Timeline

Consequences/Consequence/Degroup.php
Already clears out temp users from the function. Therefore, there is no need to verify if the user is temp in Revert() function.

Hooks/Handlers/SchemaChangesHandler.php
This one updates the user table after a schema change for system users

includes/FilterUser.php
Upgrades system users to Sysop if they are not already

The extension isn't adding or removing groups to Temporary Users
https://codesearch.wmcloud.org/deployed/?q=addUserToGroup&files=&excludeFiles=&repos=#mediawiki/extensions/AbuseFilter