Page MenuHomePhabricator

Ensure UserGroupManager::addUserToGroup is not called on temporary users from Translate extension
Closed, ResolvedPublic2 Estimated Story Points

Description

Following T340470, Ensure that UserGroupManager::addUserToGroup is not called on temporary users in Translate extension
Link to code search where calls are made can be found here

Related Objects

StatusSubtypeAssignedTask
In ProgressNiharika
OpenNone
OpenTchanders
OpenNone
ResolvedSTran
ResolvedUmherirrender
Resolved AGueyte
Duplicate AGueyte
ResolvedSTran
Resolved Dreamy_Jazz
OpenSTran
OpenSTran
OpenSTran
OpenSTran
OpenSTran
OpenNone
OpenNone
OpenNone
OpenSTran
ResolvedSTran
ResolvedBUG REPORT Dreamy_Jazz
OpenNone
Resolved TThoabala
Resolved TThoabala
Resolved TThoabala
Resolved AGueyte
ResolvedBUG REPORT AGueyte
ResolvedBUG REPORT AGueyte
Resolved AGueyte
Resolved AGueyte
ResolvedCyndymediawiksim
DuplicateNone
ResolvedNikerabbit
OpenNone
ResolvedTchanders
ResolvedTchanders
ResolvedTchanders
ResolvedTchanders
ResolvedCyndymediawiksim
Resolved AGueyte
ResolvedTchanders
Resolved TThoabala
Resolvedabi_
ResolvedFeatureEtonkovidova
ResolvedTchanders
ResolvedTchanders
OpenTchanders
ResolvedTchanders
ResolvedTchanders
OpenNone
OpenNone
ResolvedTchanders
ResolvedTchanders
OpenTchanders
ResolvedBUG REPORT Dreamy_Jazz
ResolvedTchanders
DeclinedTchanders
ResolvedTchanders
OpenNone
Resolved Dreamy_Jazz
ResolvedSTran
DeclinedNone
ResolvedSTran
Resolved Dreamy_Jazz
Resolved Dreamy_Jazz
ResolvedTchanders
ResolvedTchanders
ResolvedTchanders
Resolved Dreamy_Jazz

Event Timeline

Nikerabbit set the point value for this task to 2.Jul 10 2023, 8:30 AM

@TThoabala Looking at the code in UserGroupManager::addUserToGroup (GitHub link), I see that the code already throws an InvalidArgumentException if it's called with a temporary user.

Either way, the code here is called on users that have registered with an username and email so I don't think these can be temporary users.

abi_ changed the task status from Open to In Progress.Jul 20 2023, 4:18 PM
abi_ claimed this task.

Similar to what's mentioned in T337779, and mentioned in the previous comment, the code here is called on users that have registered with an username and email so I don't think these can be temporary users.