Page MenuHomePhabricator

Ensure User::addGroup is not called on temporary users from WikiLambda extension
Closed, InvalidPublic

Description

Following T340470, Ensure that User::addGroup is not called on temporary users in WikiLambda extension
Link to code search where calls are made can be found here

Related Objects

StatusSubtypeAssignedTask
In ProgressNiharika
OpenNone
OpenTchanders
OpenNone
ResolvedSTran
ResolvedUmherirrender
Resolved AGueyte
Duplicate AGueyte
ResolvedSTran
Resolved Dreamy_Jazz
OpenSTran
OpenSTran
OpenSTran
OpenSTran
OpenSTran
OpenNone
OpenNone
OpenNone
OpenSTran
ResolvedSTran
ResolvedBUG REPORT Dreamy_Jazz
OpenNone
Resolved TThoabala
Resolved TThoabala
Resolved TThoabala
Resolved AGueyte
ResolvedBUG REPORT AGueyte
ResolvedBUG REPORT AGueyte
Resolved AGueyte
Resolved AGueyte
ResolvedCyndymediawiksim
DuplicateNone
OpenNone
ResolvedTchanders
Resolved TThoabala
Invalid TThoabala

Event Timeline

Jdforrester-WMF subscribed.

This is inside a function that's only ever called from a maintenance script, on User::newSystemUser, so I think everything's fine?

There's wider work we should probably do, but I think we can call this Invalid.

DVrandecic subscribed.

Assigning back to @TThoabala for review based on @Jdforrester-WMF 's answer.