When uploading a file by copy-paste, the filename field within Media settings dialog is focused, but it can't be focused later
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Jun 28 2023, 7:02 PM

Description

Environment

Browser: Chrome
OS: MacOS

Behavior

Copy an image to your device's clipboard
Open VE
Paste the image you copied in "Step 1." into/onto the page you visited in "Step 2."

Expected

✅ Notice the Media settings dialog appears, but the filename field is not editable (as the user can only choose the filename at the next step in the upload process)

Actual

❌ Notice the Media settings dialog appears, with your cursor focused within the filename field, which is editable: https://www.youtube.com/watch?v=VPqC6yyp1Kw (even though its value will be ignored at the next step in the upload process)

Details

	Project	Branch	Lines +/-	Subject
	oojs/ui	master	+8 -1	Make the search input of a SelectFileInputWidget un-focusable

Customize query in gerrit

Event Timeline

ppelberg created this task.Jun 28 2023, 7:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2023, 7:02 PM

ppelberg updated the task description. (Show Details)Jun 28 2023, 7:03 PM

VPuffetMichel moved this task from To Triage to Triaged on the VisualEditor board.Jun 29 2023, 3:26 PM

The field is not supposed to be focusable in the first place… (it just displays the select file's name as a confirmation, but you can only edit it in the next step while uploading).

In T340686#8977591, @matmarex wrote:

The field is not supposed to be focusable in the first place… (it just displays the select file's name as a confirmation, but you can only edit it in the next step while uploading).

I see; can we revise the scope of this task then to ensure the field is not focusable?

matmarex renamed this task from Unable able to refocus into the filename field within Media settings dialog to When uploading a file by copy-paste, the filename field within Media settings dialog is focused, but it can't be focused later.Jul 4 2023, 11:29 PM

matmarex updated the task description. (Show Details)

Done.

By the way, I can reproduce on Wikipedia, but not locally – something must be different about the configuration in production, and this might be why we haven't noticed this bug before.

In T340686#8989340, @matmarex wrote:

Done.

Wonderful – thank you, @matmarex.

Btw: in asking, "...can we revise the scope of this task then to ensure the field is not focusable?" in T340686#8978826 I was wondering whether it'd be technically feasible. I didn't mean to indirectly suggest you do the work of updating the task description. Next time, I"ll be more clear ^ _ ^

ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Jul 26 2023, 12:33 AM

Change 954949 had a related patch set uploaded (by Esanders; author: Esanders):

[oojs/ui@master] Make the search input of a SelectFileInputWidget un-focusable

https://gerrit.wikimedia.org/r/954949

gerritbot added a project: Patch-For-Review.Tue, Sep 5, 2:29 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/857d05f412/wiki/Douglas Adams?veaction=edit

Also created an OOUI Demos page:
https://patchdemo.wmflabs.org/wikis/857d05f412/w/build/ooui/demos

Esanders claimed this task.Fri, Sep 8, 4:04 PM

Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.

Change 954949 merged by jenkins-bot:

[oojs/ui@master] Make the search input of a SelectFileInputWidget un-focusable

https://gerrit.wikimedia.org/r/954949