Page MenuHomePhabricator

Remove overrides for 'visualeditor-enable' and 'visualeditor-betatempdisable' from WMF config
Closed, ResolvedPublic

Description

If we are to unify these preferences (T335056), then we should first remove the need for overrides for them in WMF config.

The config for whether VE is a beta feature or not is currently coming from too many sources, and it's difficult to figure out the consequences of any changes. It should be just controlled by the $wgVisualEditorEnableBetaFeature config and nothing else.

Event Timeline

I've done this for 'visualeditor-betatempdisable' a while ago in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/663701 / https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/659300 – just noting here for reference, the context might be helpful in reviewing the patches for 'visualeditor-enable'.

Change 933997 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Fix conditions for 'visualeditor-autodisable' that depended on WMF config

https://gerrit.wikimedia.org/r/933997

Change 933998 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Remove unneeded $wgDefaultUserOptions['visualeditor-enable'] settings

https://gerrit.wikimedia.org/r/933998

Change 933997 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix conditions for 'visualeditor-autodisable' that depended on WMF config

https://gerrit.wikimedia.org/r/933997

Change 933998 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove unneeded $wgDefaultUserOptions['visualeditor-enable'] settings

https://gerrit.wikimedia.org/r/933998

Mentioned in SAL (#wikimedia-operations) [2023-08-22T13:03:51Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:933998|Remove unneeded $wgDefaultUserOptions['visualeditor-enable'] settings (T340696)]], [[gerrit:947015|Move visual editor out of Beta Features (without changing prefs) (T335056)]], [[gerrit:949588|Clarify 2017 wikitext editor's Beta Feature status (T344158)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-22T13:05:34Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:933998|Remove unneeded $wgDefaultUserOptions['visualeditor-enable'] settings (T340696)]], [[gerrit:947015|Move visual editor out of Beta Features (without changing prefs) (T335056)]], [[gerrit:949588|Clarify 2017 wikitext editor's Beta Feature status (T344158)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codf

Mentioned in SAL (#wikimedia-operations) [2023-08-22T13:19:35Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:933998|Remove unneeded $wgDefaultUserOptions['visualeditor-enable'] settings (T340696)]], [[gerrit:947015|Move visual editor out of Beta Features (without changing prefs) (T335056)]], [[gerrit:949588|Clarify 2017 wikitext editor's Beta Feature status (T344158)]] (duration: 15m 43s)