Page MenuHomePhabricator

Modernize code under util/ directory
Closed, ResolvedPublic16 Estimated Story Points

Description

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/CentralNoticewmf_deploy+2 -1
mediawiki/extensions/CentralNoticewmf_deploy+0 -0
mediawiki/extensions/Translatemaster+58 -85
mediawiki/extensions/TwnMainPagemaster+2 -0
mediawiki/extensions/Translatemaster+0 -1
mediawiki/extensions/Translatemaster+46 -39
mediawiki/extensions/Translatemaster+133 -207
mediawiki/extensions/Translatemaster+32 -27
mediawiki/extensions/Translatemaster+49 -50
mediawiki/extensions/Translatemaster+35 -36
mediawiki/extensions/Translatemaster+132 -161
mediawiki/extensions/Translatemaster+105 -134
mediawiki/extensions/Translatemaster+267 -264
mediawiki/extensions/Translatemaster+15 -12
mediawiki/extensions/Translatemaster+186 -244
mediawiki/extensions/Translatemaster+3 -0
translatewikimaster+38 -1
mediawiki/extensions/CentralNoticemaster+1 -0
mediawiki/extensions/Translatemaster+14 -14
mediawiki/extensions/TwnMainPagemaster+1 -1
mediawiki/extensions/Translatemaster+117 -109
mediawiki/extensions/Translatemaster+52 -44
mediawiki/extensions/Translatemaster+1 -1
mediawiki/extensions/Translatemaster+101 -101
mediawiki/extensions/Translatemaster+38 -42
mediawiki/extensions/Translatemaster+54 -44
mediawiki/extensions/Translatemaster+1 -0
mediawiki/extensions/Translatemaster+30 -39
mediawiki/extensions/Translatemaster+7 -7
mediawiki/extensions/Translatemaster+51 -71
mediawiki/extensions/Translatemaster+43 -38
mediawiki/extensions/Translatemaster+47 -72
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 989486 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move MessageGroupCache to MessageGroupProcessing namespace

https://gerrit.wikimedia.org/r/989486

Change 989639 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move MessageGroupStates to MessageGroupProcessing namespace

https://gerrit.wikimedia.org/r/989639

Change 989641 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move PHPVariableLoader to Utilities namespace

https://gerrit.wikimedia.org/r/989641

Change 989644 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move MessageGroupStatsRebuildJob::class to Statistics namespace

https://gerrit.wikimedia.org/r/989644

Change 990793 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/CentralNotice@master] Update reference to newly namesapaced MessageGroupStates::class

https://gerrit.wikimedia.org/r/990793

Change 989441 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move ExternalMessageSourceStateComparator to Synchronisation namespace.

https://gerrit.wikimedia.org/r/989441

Change 989486 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move MessageGroupCache to MessageGroupProcessing namespace

https://gerrit.wikimedia.org/r/989486

Change 989639 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move MessageGroupStates to MessageGroupProcessing namespace

https://gerrit.wikimedia.org/r/989639

Change 989641 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move PHPVariableLoader to Utilities namespace

https://gerrit.wikimedia.org/r/989641

Change 989644 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move MessageGroupStatsRebuildJob::class to Statistics namespace

https://gerrit.wikimedia.org/r/989644

Change 992076 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add RebuildMessageGroupStatsJob to $wgJobClasses

https://gerrit.wikimedia.org/r/992076

Change 992076 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add RebuildMessageGroupStatsJob to $wgJobClasses

https://gerrit.wikimedia.org/r/992076

Change 992844 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move SerializedMessageIndex::class to MessageLoading namespace.

https://gerrit.wikimedia.org/r/992844

Change rEMFR1002371ee270 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move HashMessageIndex::class to MessageLoading namespace

https://gerrit.wikimedia.org/r/1002371

Change 992844 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move SerializedMessageIndex::class to MessageLoading namespace.

https://gerrit.wikimedia.org/r/992844

Change rEMFR1002371ee270 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move HashMessageIndex::class to MessageLoading namespace

https://gerrit.wikimedia.org/r/1002371

Change 1003588 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move CBDMessageIndex:class to MessageLoading namespace

https://gerrit.wikimedia.org/r/1003588

Change 1003588 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move CBDMessageIndex::class to MessageLoading namespace

https://gerrit.wikimedia.org/r/1003588

Change 1003045 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] ServiceWiring: Fix fully-qualified namespace when loading MessageIndex

https://gerrit.wikimedia.org/r/1003045

Change 1003045 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ServiceWiring: Fix fully-qualified namespace when loading MessageIndex

https://gerrit.wikimedia.org/r/1003045

Change 1004610 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Remove unused CachedMessageIndex::class

https://gerrit.wikimedia.org/r/1004610

Change 1005647 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move DatabaseMessageIndex::class to MessageLoading namespace

https://gerrit.wikimedia.org/r/1005647

Change 1004610 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Namespace but deprecate unused CachedMessageIndex::class

https://gerrit.wikimedia.org/r/1004610

Change 1005647 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move DatabaseMessageIndex::class to MessageLoading namespace

https://gerrit.wikimedia.org/r/1005647

Change 1006837 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] DatabaseMessageIndex: Initialize MediaWikiServices in contructor

https://gerrit.wikimedia.org/r/1006837

Change 1007478 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] MessageIndex: add to MessageLoading namespace

https://gerrit.wikimedia.org/r/1007478

Change 1007480 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/TwnMainPage@master] Remove use of deprecated MessageIndex::singeton()

https://gerrit.wikimedia.org/r/1007480

Change 1007482 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] MessageIndexExcpetion: Add to MessageLoading namespace

https://gerrit.wikimedia.org/r/1007482

Change 1007480 merged by jenkins-bot:

[mediawiki/extensions/TwnMainPage@master] Remove use of deprecated MessageIndex::singeton()

https://gerrit.wikimedia.org/r/1007480

Change 1006837 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] DatabaseMessageIndex: cleanup code and store ILoadBalancer in property

https://gerrit.wikimedia.org/r/1006837

Change 990793 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Update reference to newly namespaced MessageGroupStates::class

https://gerrit.wikimedia.org/r/990793

Change 1009353 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] lc.php: move to TranslatewikiSettings.php from the Translate extension

https://gerrit.wikimedia.org/r/1009353

Change 1009354 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] lc.php: Deprecate lc.php script. Move contents to TranslatewikiSettings.php

https://gerrit.wikimedia.org/r/1009354

Change 1009353 merged by jenkins-bot:

[translatewiki@master] lc.php: move to TranslatewikiSettings.php from the Translate extension

https://gerrit.wikimedia.org/r/1009353

Change 1009354 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] lc.php: Deprecate script, move code to TranslatewikiSettings.php

https://gerrit.wikimedia.org/r/1009354

Change 1007478 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageIndex: Add to MessageLoading namespace

https://gerrit.wikimedia.org/r/1007478

Change 1007482 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageIndexException: Add to MessageLoading namespace

https://gerrit.wikimedia.org/r/1007482

Change 1011183 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] MessageGroupWANCache::class: Move to MessageGroupProcessing namespace

https://gerrit.wikimedia.org/r/1011183

Change #1015068 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] MessageHandle: Move to MessageLoading namespace

https://gerrit.wikimedia.org/r/1015068

Change #1011183 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageGroupWANCache::class: Move to MessageGroupProcessing namespace

https://gerrit.wikimedia.org/r/1011183

Change #1015068 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageHandle: Move to MessageLoading namespace

https://gerrit.wikimedia.org/r/1015068

Change #1024331 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move MessageChangeStorage::Class to Synchronization namespace

https://gerrit.wikimedia.org/r/1024331

Change #1024331 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageChangeStorage: move to Synchronization namespace

https://gerrit.wikimedia.org/r/1024331

Change #1026383 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] MessageIndexRebuildJob: Move to MessageLoading namespace

https://gerrit.wikimedia.org/r/1026383

Change #1029486 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/CentralNotice@wmf_deploy] Update reference to MessageIndexRebuildJob

https://gerrit.wikimedia.org/r/1029486

Change #1030745 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] MessageGroupStatesUpdaterJob: Move to MessageGroupProcessing namespace

https://gerrit.wikimedia.org/r/1030745

Change #1030745 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageGroupStatesUpdaterJob: Move to MessageGroupProcessing namespace

https://gerrit.wikimedia.org/r/1030745

Change #1026383 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageIndexRebuildJob: Move to MessageLoading namespace

https://gerrit.wikimedia.org/r/1026383

Change #1031940 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] MessageUpdateJob: Move to Synchronization namespace.

https://gerrit.wikimedia.org/r/1031940

Change #1033887 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] MessageGroupsStats: Move to Statistics namespace.

https://gerrit.wikimedia.org/r/1033887

Change #1034076 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] MessageGroupsStats: Add strict types to functions

https://gerrit.wikimedia.org/r/1034076

Change #1035318 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] UpdateMessageJob:Remove use of deprecated methods.

https://gerrit.wikimedia.org/r/1035318

abi_ changed the task status from Open to In Progress.May 28 2024, 9:19 AM
abi_ assigned this task to Wangombe.
abi_ set the point value for this task to 16.

Change #1036786 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] config.php: Remove reference to utils directory

https://gerrit.wikimedia.org/r/1036786

Change #1031940 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageUpdateJob: Move to Synchronization namespace

https://gerrit.wikimedia.org/r/1031940

Change #1033887 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageGroupsStats: Move to Statistics namespace

https://gerrit.wikimedia.org/r/1033887

Change #1034076 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageGroupsStats: Code improvements under Statistics namespace

https://gerrit.wikimedia.org/r/1034076

Change #1035318 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] UpdateMessageJob: Remove use of deprecated methods

https://gerrit.wikimedia.org/r/1035318

Change #1036786 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] config.php: Remove reference to utils directory

https://gerrit.wikimedia.org/r/1036786

Change #1037093 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/TwnMainPage@master] Use namespaced version of MessageGroupStats class

https://gerrit.wikimedia.org/r/1037093

Change #1037093 merged by jenkins-bot:

[mediawiki/extensions/TwnMainPage@master] Use namespaced version of MessageGroupStats class

https://gerrit.wikimedia.org/r/1037093

abi_ subscribed.

All classes under util/ folder have been migrated to namespaces and code improvements have been done. Changes are deployed on translatewiki.net. Moving to done column, but keeping open for observation.

Things look stable on translatewiki.net. Will create follow up tasks if any issues crop up.

Change #1052668 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/1052668

Change #1052668 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/1052668

Change #1029486 abandoned by Wangombe:

[mediawiki/extensions/CentralNotice@wmf_deploy] Update reference to MessageIndexRebuildJob

Reason:

Done in I60c80b35edaebf4a0daae8fd765d36ac964cfff0

https://gerrit.wikimedia.org/r/1029486