Page MenuHomePhabricator
Create Task
Maniphest T340728

Minerva namespace tabs does not use standard markup and does not work with gadgets
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Edtadros
Authored By
Nux
Jun 29 2023, 10:48 AM
Project Tags
Referenced Files
F41662363: screenshot 395.png
Jan 10 2024, 2:37 AM
F41662361: screenshot 394.png
Jan 10 2024, 2:37 AM
Restricted File
Jan 4 2024, 12:37 AM
F37123022: obraz.png
Jun 29 2023, 10:48 AM
Subscribers
Aklapper
Edtadros
Jdlrobson
Masumrezarock100
Nux
SToyofuku-WMF

Description

Steps to replicate the issue (include links if applicable):

  • Enable gadget that is using mw.util.addPortletLink.
  • Open mobile page.
  • No tab present.

What happens?:

This returns null:

...
var id = 'ca-example';
var nextEditUrl = '#example';
var parentId = 'p-namespaces';
var item = mw.util.addPortletLink( parentId, nextEditUrl, ">ᵉ", id, 'Edytuj następną', 'd', '#ca-nstab-page' );

See real code: https://pl.wikisource.org/wiki/MediaWiki:Gadget-EditNext.js

What should have happened instead?:

Add a portlet link with proper structure.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

The tab on desktop:

obraz.png (1,350×266 px, 30 KB)

QA

in beta cluster on mobile, make sure you are logged in and run

var id = 'ca-example';
var nextEditUrl = '#example';
var parentId = 'p-associated-pages';
var item = mw.util.addPortletLink( parentId, nextEditUrl, ">ᵉ", id, 'Edytuj następną', 'd', '#ca-nstab-page' );

and confirm a tab gets added

QA in production

QA Results - Beta

ACStatusDetails
1✅T340728#9434004

QA Results - Prod

ACStatusDetails
1✅T340728#9448710
1✅T340728#9448710

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove old styles for unnested tabsStoyofuku-wmfmediawiki/skins/MinervaNeuemaster+9 -30
Allow addPortletLink to target tabs/associated pagesStoyofuku-wmfmediawiki/skins/MinervaNeuemaster+23 -5
[WIP] Use data-associated-pages for tab rendering, and fix portlet linksStoyofuku-wmfmediawiki/skins/MinervaNeuemaster+30 -11
Rework tabs to use unordered listStoyofuku-wmfmediawiki/skins/MinervaNeuemaster+35 -9
Customize query in gerrit

Related Objects

Event Timeline

Nux created this task.Jun 29 2023, 10:48 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJun 29 2023, 10:48 AM
Nux mentioned this in T328610: Default gadgets to run on mobile.Jun 29 2023, 10:51 AM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived, patch-welcome, good first task; removed: MediaWiki-extensions-Gadgets.Jul 19 2023, 4:56 PM
Jdlrobson subscribed.

This is a bug in Minerva. This API exists, so this gadget should just work.

Minerva's tabs should have the id p-associated-pages

I think this can be fixed by replacing the following:

{{#data-minerva-tabs}}
					<div class="minerva__tab-container">
						{{#items}}
							<a href="{{href}}" rel="{{rel}}" class="minerva__tab {{class}}" data-event-name="tabs.{{context}}">{{text}}</a>
						{{/items}}
					</div>
				{{/data-minerva-tabs}}

with:

{{#data-minerva-tabs}}
					{{#data-portlets.data-associated-pages}}
					<div class="minerva__tab-container" id="{{id}}">
						{{#items}}
							<a href="{{href}}" rel="{{rel}}" class="minerva__tab {{class}}" data-event-name="tabs.{{context}}">{{text}}</a>
						{{/items}}
					</div>
					{{/data-portlets.data-associated-pages}}
				{{/data-minerva-tabs}}
Jdlrobson renamed this task from Portlet or other api to add tabs to minerva (mobile) to Minerva namespace tabs does not use standard markup and does not work with gadgets.Jul 19 2023, 4:56 PM
Jdlrobson moved this task from Backlog to TODO on the MinervaNeue board.
bwang triaged this task as Medium priority.Jul 20 2023, 5:35 PM
bwang raised the priority of this task from Medium to Needs Triage.
bwang moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog-Archived board.
Jdlrobson triaged this task as Medium priority.Jul 20 2023, 5:35 PM
Jdlrobson mentioned this in T340802: Remove the ResourceLoader targets system from MediaWiki core in 1.42.Jul 24 2023, 6:43 PM
SToyofuku-WMF subscribed.Dec 11 2023, 5:04 PM
SToyofuku-WMF claimed this task.Dec 12 2023, 10:54 PM
gerritbot added a comment.Dec 19 2023, 12:27 AM

Change 983960 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/skins/MinervaNeue@master] Rework tabs to use unordered list

https://gerrit.wikimedia.org/r/983960

gerritbot added a project: Patch-For-Review.Dec 19 2023, 12:27 AM
Jdlrobson reassigned this task from SToyofuku-WMF to Edtadros.Dec 20 2023, 9:47 PM
Jdlrobson edited projects, added: Unplanned-Sprint-Work, Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5); removed: Web-Team-Backlog-Archived.
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5) board.

Works perfectly! Nice job @SToyofuku-WMF ! If you could open a new patch to remove the FIXME and mark it as WIP or -2 it we can merge that once the change gets deployed in January. Since it's December, otherwise I worry we might forget!

Jdlrobson reassigned this task from Edtadros to SToyofuku-WMF.Dec 20 2023, 9:48 PM
Jdlrobson moved this task from QA to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5) board.
Jdlrobson added a subscriber: Edtadros.

Oops! I forgot we haven't completely done this yet so moving back to doing :)

gerritbot added a comment.Dec 20 2023, 10:06 PM

Change 983960 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Rework tabs to use unordered list

https://gerrit.wikimedia.org/r/983960

gerritbot added a comment.Dec 20 2023, 10:29 PM

Change 984646 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/skins/MinervaNeue@master] Remove old styles for unnested tabs

https://gerrit.wikimedia.org/r/984646

gerritbot added a comment.Dec 20 2023, 11:36 PM

Change 984649 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/skins/MinervaNeue@master] [WIP] Use data-associated-pages for tab rendering, and fix portlet links

https://gerrit.wikimedia.org/r/984649

gerritbot added a comment.Dec 21 2023, 12:51 AM

Change 984649 abandoned by Stoyofuku-wmf:

[mediawiki/skins/MinervaNeue@master] [WIP] Use data-associated-pages for tab rendering, and fix portlet links

Reason:

Talked with Jon and going to avoid changing quite so much for now - will revisit the associated pages changes when I understand things a little bit better

https://gerrit.wikimedia.org/r/984649

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Dec 21 2023, 2:00 AM
gerritbot added a comment.Dec 21 2023, 8:03 PM

Change 984992 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/skins/MinervaNeue@master] Allow addPortletLink to target tabs/associated pages

https://gerrit.wikimedia.org/r/984992

Jdlrobson reassigned this task from SToyofuku-WMF to Edtadros.Dec 22 2023, 1:12 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5) board.
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5) board.
gerritbot added a comment.Dec 22 2023, 1:23 AM

Change 984992 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Allow addPortletLink to target tabs/associated pages

https://gerrit.wikimedia.org/r/984992

Jdlrobson closed this task as Resolved.Jan 4 2024, 12:36 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (FY2023-24 Q2 Sprint 5) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: in beta cluster on mobile, make sure you are logged in and run the code and confirm a tab gets added

{F41649986}

Jdlrobson updated the task description. (Show Details)Jan 4 2024, 12:39 AM
Jdlrobson mentioned this in T354293: Verify 1.42.0-wmf.12 deployment.Jan 4 2024, 9:58 PM
Edtadros added a project: Verified.Jan 10 2024, 2:37 AM

Test Result - Prod

Status: ✅ PASS
Environment: cawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://ca.wikipedia.org/wiki/Especial:Prefer%C3%A8ncies#mw-prefsection-gadgets and enable DocTabs
✅ AC1: Visit https://ca.wikipedia.org/wiki/Plantilla:Infobox and check a tab adds on desktop

screenshot 394.png (940×602 px, 96 KB)

✅ AC2: Switch to mobile and confirm the same tab is added.

screenshot 395.png (946×751 px, 124 KB)

Edtadros updated the task description. (Show Details)Jan 10 2024, 2:38 AM
gerritbot added a comment.Jan 11 2024, 9:36 PM

Change 984646 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove old styles for unnested tabs

https://gerrit.wikimedia.org/r/984646

ReleaseTaggerBot edited projects, added: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16); removed: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Jan 11 2024, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 11 2024, 10:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits