Page MenuHomePhabricator
Create Task
Maniphest T340747

page preview partially covered by search bar
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To
None
Authored By
Winstondegreef
Jun 29 2023, 2:02 PM
Tags
Referenced Files
F37141554: Screenshot 2023-07-17 at 9.29.11 AM.png
Jul 17 2023, 4:31 PM
F37136490: Screenshot 2023-07-11 at 7.15.54 PM.png
Jul 12 2023, 2:18 AM
F37123164: Screenshot from 2023-06-29 09-59-37.png
Jun 29 2023, 2:02 PM
Subscribers
Aklapper
Christophesque
Edtadros
Jdlrobson
• Mabualruz
TheresNoTime
Winstondegreef

Description

Steps to replicate the issue (include links if applicable):
go to https://en.wikipedia.org/wiki/Independence_Day_(United_States) and hover over the link carnivals, or any other link in that same line, and the page preview (in enabled) will float above the link and be covered by a part of the searchbar

What happens?:
the page preview (in enabled) will float above the link and be covered by a part of the searchbar

What should have happened instead?:
z-level of page preview should be above z-level of searchbar

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
page dimensions (window.innerWidth, window.innerHeight): 1477, 784

Screenshot from 2023-06-29 09-59-37.png (982×1 px, 944 KB)

QA Results - Beta

ACStatusDetails
1✅T340747#9007522

QA Results - Prod

ACStatusDetails
1✅T340747#9020555

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Avoid setting large z-index on headersmediawiki/skins/Vectormaster+2 -8
Page preview partially covered by search barmediawiki/extensions/Popupsmaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

Winstondegreef created this task.Jun 29 2023, 2:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2023, 2:02 PM
Winstondegreef renamed this task from page preview partially covered by search bas to page preview partially covered by search bar.Jun 29 2023, 2:24 PM
TheresNoTime added a project: Page-Previews.Jun 29 2023, 2:26 PM
TheresNoTime added subscribers: Jdlrobson, TheresNoTime.Jun 29 2023, 2:45 PM
  • @zIndexPopup is set to 110
  • Element containing the search bar has a z-index of 200 on Vector-2022 at ~that resolution

Increasing the z-index of the popup to 210 seems reasonable. Noting this comment which requests

// Per https://www.mediawiki.org/wiki/Page_Previews/Design_specifications
// DO NOT CHANGE without consulting a designer.

and the fact this really only seems to affect #desktop_improvements_vector_2022, adding @Jdlrobson for comments.

Jdlrobson triaged this task as High priority.Jun 29 2023, 4:11 PM
Jdlrobson added projects: Design-System-Team, Web-Team-Backlog-Archived (Web Team FY2023-24 Q1 Sprint 1).

Likely fallout from T285592 (https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/898683)

LGoto set the point value for this task to 2.Jun 29 2023, 5:20 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q1 Sprint 1) board.Jun 29 2023, 5:45 PM
CCiufo-WMF moved this task from Inbox to Following on the Design-System-Team board.Jun 30 2023, 2:53 PM
Jdlrobson merged a task: T340891: Popup window appears behind search box instead of on top like other elements.Jun 30 2023, 8:58 PM
Jdlrobson added a subscriber: Christophesque.
gerritbot added a comment.Jul 4 2023, 1:54 PM

Change 935134 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/Popups@master] page preview partially covered by search bar

https://gerrit.wikimedia.org/r/935134

gerritbot added a project: Patch-For-Review.Jul 4 2023, 1:54 PM
• Mabualruz claimed this task.Jul 4 2023, 1:54 PM
• Mabualruz moved this task from Ready for Development to Code Review on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q1 Sprint 1) board.
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q1 Sprint 1) board.Jul 5 2023, 4:58 PM
gerritbot added a comment.Jul 6 2023, 5:19 PM

Change 936078 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Avoid setting large z-index on headers

https://gerrit.wikimedia.org/r/936078

bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q1 Sprint 1) board.Jul 6 2023, 5:27 PM
bwang removed • Mabualruz as the assignee of this task.Jul 6 2023, 5:53 PM
bwang added a subscriber: • Mabualruz.
gerritbot added a comment.Jul 6 2023, 11:31 PM

Change 935134 abandoned by Jdlrobson:

[mediawiki/extensions/Popups@master] Page preview partially covered by search bar

Reason:

We're going to go ahead with https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/936078 instead. Thanks for the attempt at fixing this!

https://gerrit.wikimedia.org/r/935134

gerritbot added a comment.Jul 6 2023, 11:50 PM

Change 936078 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Avoid setting large z-index on headers

https://gerrit.wikimedia.org/r/936078

Jdlrobson assigned this task to Edtadros.Jul 6 2023, 11:53 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q1 Sprint 1) board.
Maintenance_bot removed a project: Patch-For-Review.Jul 7 2023, 12:10 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 7 2023, 1:00 AM
Jdlrobson mentioned this in T340391: Default Reference Tooltips gadget and new Vector search can overlap because of z-index.Jul 7 2023, 10:15 PM
Edtadros removed Edtadros as the assignee of this task.Jul 12 2023, 2:18 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q1 Sprint 1) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

go to https://en.wikipedia.org/wiki/Independence_Day_(United_States) and hover over the link carnivals, or any other link in that same line, and the page preview (in enabled) will float above the link and be covered by a part of the searchbar
✅ AC1: z-level of page preview should be above z-level of searchbar

Screenshot 2023-07-11 at 7.15.54 PM.png (433×1 px, 253 KB)

Edtadros updated the task description. (Show Details)Jul 12 2023, 2:19 AM
• Mabualruz claimed this task.Jul 13 2023, 4:38 PM
Jdlrobson reassigned this task from • Mabualruz to Edtadros.Jul 14 2023, 6:05 PM
Jdlrobson moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q1 Sprint 1) board.
Edtadros closed this task as Resolved.Jul 17 2023, 4:31 PM
Edtadros removed Edtadros as the assignee of this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

go to https://en.wikipedia.org/wiki/Independence_Day_(United_States) and hover over the link carnivals, or any other link in that same line, and the page preview (in enabled) will float above the link and be covered by a part of the searchbar
✅ AC1: z-level of page preview should be above z-level of searchbar

Screenshot 2023-07-17 at 9.29.11 AM.png (481×1 px, 483 KB)

Edtadros updated the task description. (Show Details)Jul 17 2023, 4:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits