Page MenuHomePhabricator
Create Task
Maniphest T340769

Implement the right headers for wikifeeds aggregate endpoints
Closed, ResolvedPublic
Actions

Description

From difftesting:
RESTBase adds the following headers for the wikifeeds endpoints:

  • content-type
  • etag
  • cache-control

We need to implement these headers on wikifeeds service level

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifeeds: Add CSP headers for restbase sunsetoperations/deployment-chartsmaster+1 -6
Add missing cache-control in aggregate endpointsmediawiki/services/wikifeedsmaster+2 -0
Add missing etag in aggregate endpointsmediawiki/services/wikifeedsmaster+3 -0
Add missing content type in aggregate endpointsmediawiki/services/wikifeedsmaster+9 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jgiannelos created this task.Jun 29 2023, 4:31 PM
Jgiannelos updated the task description. (Show Details)
gerritbot added a comment.Jul 3 2023, 9:17 AM

Change 934995 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/services/wikifeeds@master] Add missing content type in aggregate endpoints

https://gerrit.wikimedia.org/r/934995

gerritbot added a project: Patch-For-Review.Jul 3 2023, 9:17 AM
gerritbot added a comment.Jul 3 2023, 10:15 AM

Change 935009 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/services/wikifeeds@master] Add missing etag in aggregate endpoints

https://gerrit.wikimedia.org/r/935009

gerritbot added a comment.Jul 3 2023, 12:42 PM

Change 935051 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[operations/deployment-charts@master] wikifeeds: Add CSP headers for restbase sunset

https://gerrit.wikimedia.org/r/935051

gerritbot added a comment.Jul 3 2023, 2:13 PM

Change 935075 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/services/wikifeeds@master] Add missing cache-control in aggregate endpoints

https://gerrit.wikimedia.org/r/935075

Jgiannelos claimed this task.Jul 3 2023, 2:33 PM
Jgiannelos moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.
gerritbot added a comment.Jul 4 2023, 9:23 AM

Change 934995 merged by jenkins-bot:

[mediawiki/services/wikifeeds@master] Add missing content type in aggregate endpoints

https://gerrit.wikimedia.org/r/934995

Jgiannelos mentioned this in rWSWF6f200702ce06: Add missing content type in aggregate endpoints.Jul 4 2023, 9:37 AM
gerritbot added a comment.Jul 5 2023, 2:00 PM

Change 935009 merged by jenkins-bot:

[mediawiki/services/wikifeeds@master] Add missing etag in aggregate endpoints

https://gerrit.wikimedia.org/r/935009

gerritbot added a comment.Jul 5 2023, 2:00 PM

Change 935075 merged by jenkins-bot:

[mediawiki/services/wikifeeds@master] Add missing cache-control in aggregate endpoints

https://gerrit.wikimedia.org/r/935075

Jgiannelos mentioned this in rWSWF16b398e10ff2: Add missing etag in aggregate endpoints.Jul 5 2023, 2:01 PM
Jgiannelos mentioned this in rWSWF4f609810d9da: Add missing cache-control in aggregate endpoints.
Jgiannelos removed a project: Content-Transform-Team-WIP.Jul 11 2023, 8:17 AM
Jgiannelos closed this task as Resolved.Jul 11 2023, 11:40 AM
gerritbot added a comment.Jul 11 2023, 11:41 AM

Change 935051 merged by jenkins-bot:

[operations/deployment-charts@master] wikifeeds: Add CSP headers for restbase sunset

https://gerrit.wikimedia.org/r/935051

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2023, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits