Page MenuHomePhabricator

mw-indicators is display flex in en.wp to support coordinates; should this be upstreamed?
Closed, ResolvedPublic1 Estimated Story Points

Description

This series of edits was made to support the "title" display of coordinates (T281974) on English Wikipedia. The initial cut of it by @Jdlrobson was basically reasonable, though I did need to add a flex-wrap: wrap for those users who put their article achievements on their user pages in indicators (example can be found at this discussion). It seems to have been a satisfactory solution there, without apparent issues elsewhere on en.wp.

Accordingly, I think it would be desirable to upstream some portion of this specific block to Vector 2022:

.mw-indicators {
    display: flex;
    column-gap: 10px;
    flex-wrap: wrap;
}

(I'm maybe not a fan of the sizing on column-gap; in the inline-block version of the indicators, I'd say the gap is closer to 3-5px than 10px.)

That example case is probably a good one to think about, since indicators typically start from the right of the page, while the wrapping there wraps from the left. May/may not be a big deal to most people, but obviously the user there noticed.

How varying quantities of indicators interact with #siteSub is also worth consideration.

Details

Event Timeline

LGoto set the point value for this task to 1.Jul 6 2023, 5:23 PM

@aliu not sure what you mean but a patch for this is very much welcome and I would happily review it!

Change 1003099 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/skins/Vector@master] Make vector-2022 mw-indicators flex-wrap

https://gerrit.wikimedia.org/r/1003099

Change 1003099 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Make vector-2022 mw-indicators flex-wrap

https://gerrit.wikimedia.org/r/1003099