Trying to delete individual versions in the file namespace (action=delete&oldimage=) deletes all versions
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Novem_Linguae
	Jun 30 2023, 8:49 AM

Description

Steps to replicate the issue (include links if applicable):

Upload a file in the file namespace
Click "Upload a new version of this file", upload a new version
In "File history", in the table, in the bottom row in the left column, click "delete". The URL of the link will be something like https://test.wikipedia.org/w/index.php?title=File:Novems_test_file.png&action=delete&oldimage=20230630083907%21Novems_test_file.png. As opposed to the "delete all" link which is a little higher and has a URL similar to https://test.wikipedia.org/w/index.php?title=File:Novems_test_file.png&action=delete

What happens?:

All page history is deleted
All file history is deleted

What should have happened instead?:

No page history should be deleted
Only that particular old version of the file should be deleted

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Reported by @Explicit at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Deleting_file_revision_results_in_entire_file_being_deleted

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	wmf/1.41.0-wmf.15	+1 -0	DeleteAction: Call setAction for file revision delete
	mediawiki/core	master	+1 -0	DeleteAction: Call setAction for file revision delete

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	brennen	T340243 1.41.0-wmf.15 deployment blockers
		Resolved	BUG REPORT	Func	T340821 Trying to delete individual versions in the file namespace (action=delete&oldimage=) deletes all versions

Event Timeline

Novem_Linguae created this task.Jun 30 2023, 8:49 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2023, 8:49 AM

I think this is a Regression. Might want to do a git bisect to narrow it down.

Caused by c3e43d31874eb874d4132c2caa68b7258d6b9a0b (T337304)

Change 934452 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] DeleteAction: Call setAction for file revision delete

https://gerrit.wikimedia.org/r/934452

gerritbot added a project: Patch-For-Review.Jun 30 2023, 2:33 PM

Major regression that made it to production. I think these usually get UBN. Feel free to lower priority if I'm incorrect. This might need a backport too.

Nardog renamed this task from Trying to delete individual revisions in the file namespace (action=delete&oldimage=) deletes all revisions to Trying to delete individual versions in the file namespace (action=delete&oldimage=) deletes all versions.Jun 30 2023, 7:57 PM

Nardog updated the task description. (Show Details)

Peachey88 added a parent task: T340243: 1.41.0-wmf.15 deployment blockers.Jul 1 2023, 3:58 AM

Peachey88 mentioned this in T340243: 1.41.0-wmf.15 deployment blockers.

Change 934608 had a related patch set uploaded (by Hashar; author: Func):

[mediawiki/core@wmf/1.41.0-wmf.15] DeleteAction: Call setAction for file revision delete

https://gerrit.wikimedia.org/r/934608

Change 934452 merged by jenkins-bot:

[mediawiki/core@master] DeleteAction: Call setAction for file revision delete

https://gerrit.wikimedia.org/r/934452

The fix https://gerrit.wikimedia.org/r/c/mediawiki/core/+/934452 is merged in the master branch and should be testable on https://wikitech.wikimedia.org/wiki/Beta_Cluster.

I have poked the private mediawiki_security IRC channel and our internal ops-l mailling list about it to get an approval by SRE (per Deployments/Emergencies). I gave my point of contact and can do the deployment itself (scap backport 934608).

We are doing the deployment to production.

Change 934608 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.15] DeleteAction: Call setAction for file revision delete

https://gerrit.wikimedia.org/r/934608

Mentioned in SAL (#wikimedia-operations) [2023-07-01T08:11:05Z] <hashar@deploy1002> Started scap: Backport for [[gerrit:934608|DeleteAction: Call setAction for file revision delete (T340821)]]

Mentioned in SAL (#wikimedia-operations) [2023-07-01T08:12:41Z] <hashar@deploy1002> hashar: Backport for [[gerrit:934608|DeleteAction: Call setAction for file revision delete (T340821)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-07-01T08:20:23Z] <hashar@deploy1002> Finished scap: Backport for [[gerrit:934608|DeleteAction: Call setAction for file revision delete (T340821)]] (duration: 09m 17s)

Works on testwiki. Thanks for the emergency backport. Enjoy your weekend :)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jul 1 2023, 9:00 AM

hashar mentioned this in T340244: 1.41.0-wmf.16 deployment blockers.Jul 4 2023, 8:00 AM

Trying to delete individual versions in the file namespace (action=delete&oldimage=) deletes all versionsClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Trying to delete individual versions in the file namespace (action=delete&oldimage=) deletes all versions
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...