PHP Notice: Unexpected clearActionName after getActionName already called
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Reedy
	Jun 30 2023, 3:02 PM

Description

Error

mwversion: 1.41.0-wmf.15
reqId: bace5ab3-6588-408b-81f3-2993bc58f0db
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Unexpected clearActionName after getActionName already called

exception.trace

from /srv/mediawiki/php-1.41.0-wmf.15/includes/context/RequestContext.php(308)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.41.0-wmf.15/includes/context/RequestContext.php(308): trigger_error(string)
#2 /srv/mediawiki/php-1.41.0-wmf.15/includes/context/RequestContext.php(175): RequestContext->clearActionName()
#3 /srv/mediawiki/php-1.41.0-wmf.15/includes/actions/SpecialPageAction.php(93): RequestContext->setTitle(MediaWiki\Title\Title)
#4 /srv/mediawiki/php-1.41.0-wmf.15/includes/MediaWiki.php(561): SpecialPageAction->show()
#5 /srv/mediawiki/php-1.41.0-wmf.15/includes/MediaWiki.php(334): MediaWiki->performAction(Article, MediaWiki\Title\Title)
#6 /srv/mediawiki/php-1.41.0-wmf.15/includes/MediaWiki.php(927): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.41.0-wmf.15/includes/MediaWiki.php(581): MediaWiki->main()
#8 /srv/mediawiki/php-1.41.0-wmf.15/index.php(50): MediaWiki->run()
#9 /srv/mediawiki/php-1.41.0-wmf.15/index.php(46): wfIndexMain()
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}

Impact

Notes

Details

Request URL: https://pt.wikipedia.org/w/index.php?action=historysubmit&editchangetags=*&title=*&type=*

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use special pages instead of actions for revision delete and edit tags	mediawiki/core	master	+14 -28
	SpecialPageAction: Use DerivativeContext for special page execution	mediawiki/core	master	+3 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T302623 FY2022-2023: Improve Backend Pageview Timing
Resolved		matmarex	T314008 Promote dirty RequestContext::clearActionName to runtime warning
Resolved		matmarex	T323338 Resolve revisiondelete/editchangetags debt around fake action/specialpage handling
Resolved	PRODUCTION ERROR	Func	T340853 PHP Notice: Unexpected clearActionName after getActionName already called

Event Timeline

Reedy created this task.Jun 30 2023, 3:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2023, 3:02 PM

Reedy added a project: MediaWiki-General.Jun 30 2023, 3:12 PM

Change 934454 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] SpecialPageAction: Use DerivativeContext for special page execution

https://gerrit.wikimedia.org/r/934454

gerritbot added a project: Patch-For-Review.Jun 30 2023, 5:02 PM

Change 935126 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Use special pages instead of actions for revision delete and edit tags

https://gerrit.wikimedia.org/r/935126

Change 934454 abandoned by Func:

[mediawiki/core@master] SpecialPageAction: Use DerivativeContext for special page execution

Reason:

I submitted https://gerrit.wikimedia.org/r/c/mediawiki/core/+/935126/ instead.

https://gerrit.wikimedia.org/r/934454

matmarex subscribed.Jul 6 2023, 10:12 AM

matmarex added a parent task: T323338: Resolve revisiondelete/editchangetags debt around fake action/specialpage handling.Jul 6 2023, 10:26 AM

Change 935126 merged by jenkins-bot:

[mediawiki/core@master] Use special pages instead of actions for revision delete and edit tags

https://gerrit.wikimedia.org/r/935126

FYI, the error counts looked like this before the change: https://logstash.wikimedia.org/goto/f9dfef78674d1a95764cf8023d9e5c47

Someone should check that they are gone after the change is deployed.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 6 2023, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 6 2023, 11:10 AM

Umherirrender unsubscribed.Jul 12 2023, 8:14 PM

Gone after the group2 deployment earlier today.

Screenshot 2023-07-13 at 23.50.24.png (765×2 px, 191 KB)

matmarex reassigned this task from matmarex to Func.Jul 14 2023, 11:57 PM

	F37138394: Screenshot 2023-07-13 at 23.50.24.png
	Jul 13 2023, 11:07 PM

	F37130404: image.png
	Jul 6 2023, 10:33 AM

PHP Notice: Unexpected clearActionName after getActionName already calledClosed, ResolvedPublicPRODUCTION ERRORActions