Improve 7.3.1 upgrade path launch times
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tsevener
	Jun 30 2023, 7:25 PM

Description

7.3.1 showed a significant slowdown in launch times when upgrading from an app version with saved articles:

https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Engineering_Pre-release_Checklist

We should always try to reduce time spent didFinishLaunching, as well as reduce time tying up the main thread, to prevent watchdog terminations.

QA Testing Notes

On both a high powered device and low powered device, please try to build up a large database of items in the App Store 7.3.0 version, then upgrade to 7.3.1 (2318) via TestFlight. The best way to build up a large database of items is to log into an account with a lot of synced saved articles. Once those articles finish downloading to device, try updating. Confirm app launches without crashing and saved articles still work while offline.

Related Objects

Mentioned In: T340489: Release 7.3.1

Event Timeline

Tsevener created this task.Jun 30 2023, 7:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2023, 7:25 PM

Tsevener claimed this task.Jun 30 2023, 7:25 PM

Tsevener moved this task from Tasks from Product Backlog to Doing on the iOS Release FY2023-24 (Archive) board.

Current 7.3.1 first launch metrics, for a user with a year's worth of Explore feed data populated, and 1000 Saved Articles (iPhone 7).

Total time to initial frame rendering: 8.094 seconds

After PR changes: https://github.com/wikimedia/wikipedia-ios/pull/4553

0.234 seconds*

*It's worth noting that it still takes about 8 seconds before a user sees the Explore feed. The data still takes a while to migrate (unavoidable), but now we are preventing the launch method and main thread from hanging. This migration happens asynchronously, while the user sees our existing "Updating..." animation.