| Esanders | |
| Jul 1 2023, 10:18 AM |
| F37125414: image.png | |
| Jul 1 2023, 10:18 AM |
| F37125417: image.png | |
| Jul 1 2023, 10:18 AM |
Currently Phonos uses the default extension editor, which lets you edit the XML-like tag's attributes but also contents (which Phonos never uses?):
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Polar_bear&action=edit
Context:
Inspector:
Toolbar:
None - A custom tool would allow us to add IPA to the "Insert" menu.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Phonos: don't allow the redundant label= attribute | mediawiki/extensions/Phonos | master | +2 -0 |
Some existing extensions that implement VE tools:
Although custom tools could/should still be created for VE, it's worth noting that the contents can be used
Is there a reason there are 2 identical ways to do the same thing? This seems like it will add an unnecessary maintenance burden going forward. For example VE will need to read both, and Parsoid will need to remember which to use to avoid normalising the wikitext. It will also not be immediately obvious to readers/code implementors which one is used if both are present.
In regards to the point above, if we don want to get rid of one of the duplicate ways of setting the label, we should do this ASAP, as the more the extension is used, the more places there will be to fix.
Seconded! I don't think this was even by design, rather it's a side effect of the current implementation. Patch incoming.
Change 936320 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):
[mediawiki/extensions/Phonos@master] Phonos: don't allow the redundant label= attribute
Change 936320 merged by jenkins-bot:
[mediawiki/extensions/Phonos@master] Phonos: don't allow the redundant label= attribute