Page MenuHomePhabricator

Display client hint data in Special:CheckUser's 'Get users' mode
Closed, ResolvedPublic

Description

Client hint data should be shown in Special:CheckUser's 'Get users' mode. An example of these results is shown below.

image.png (1×1 px, 265 KB)

The format of the 'Get users' results needs UX improvements. T69811 tracks this, but progress on that has been slow. To show client hint data, just adding a new list underneath the user agents is likely to make the results list more confusing.


In T345764 the design for the Client Hints display was decided on and is shown below:

Log-line.png (1×1 px, 261 KB)

Acceptance criteria
  • Client Hints data is displayed in Special:CheckUser 'Get users'

QA Results - Local

Event Timeline

Change 959207 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] clienthints: Implement display on Special:CheckUser 'Get users'

https://gerrit.wikimedia.org/r/959207

Change 959207 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] clienthints: Implement display on Special:CheckUser 'Get users'

https://gerrit.wikimedia.org/r/959207

Suggested QA steps:

  1. Install CheckUser
  2. Create a new account and note the username you used for future steps
  3. Make at least two edits using Google Chrome and one using Edge on this new account
  4. Login to an account with the checkuser right
  5. Load Special:CheckUser, put the username you used in step 2, select 'Get IP Addresses' check subtype, and then run a check.
  6. Click on the IP address shown in the results list
  7. On this new Special:CheckUser tab, select the check type of 'Get users' and then run the check

Expected behaviour to verify the acceptance criteron: Ensure that the user created in step 2 appears in the results list for the second check and that Client Hints data containing "Brand: Google Chrome" appears above the Client Hints data containing "Brand: Edge". The output should look similar to the second design (from the top) in F37657179.

@Dreamy_Jazz the user created in step 2 appears in the results list and client Hints data containing "Brand: Google Chrome" appears above the Client Hints data containing "Brand: Edge". I will move this to Done. Thanks for all your work!

Status: ✅PASS
Environment: Local: 1.41.0-alpha (ac546dd) 15:31, 2 October 2023. Checkuser: 2.5 (99b7a3b) 11:11, 2 October 2023
OS: macOS Sonoma 14.0
Browser: Chrome 117, Edge 117
Device: MBA M2
Emulated Device:: BrowserStack for Edge
Test Links:
http://localhost:8080/wiki/Special:CheckUser
http://localhost:8080/w/index.php?title=Beer
http://localhost:8080/w/index.php?title=Wawa

✅AC1: https://phabricator.wikimedia.org/T340991#9197636

2023-10-02_15-00-19.png (1×3 px, 329 KB)