Page MenuHomePhabricator

Do not expose LDAP users on release Jenkins UI
Closed, DeclinedPublic

Description

Upstream issue https://issues.jenkins.io/browse/JENKINS-18884 , addressed by 2.452.1


Currently, a list of LDAP accounts used by the releases Jenkins can be seen here: https://releases-jenkins.wikimedia.org/asynchPeople/

That URL is open to non-logged users the moment we assign overall read permissions to anonymous users in Jenkins. That was required to be able to provide access to doc publishing jobs in Jenkins.

We didn't consider this a new issue, as this information is also exposed in the CI Jenkins, but reducing the number of places that information is exposed is still an improvement. Besides, this can be achieved very easily by blocking the relevant URL path in the apache proxy that stands in front of Jenkins.

Details

Event Timeline

Restricted Application added a subscriber: • Aklapper. · View Herald Transcript

Change 935453 had a related patch set uploaded (by Jaime Nuche; author: Jaime Nuche):

[operations/puppet@production] releases-jenkins: block LDAP users page

https://gerrit.wikimedia.org/r/935453

but not exposing that information is still an improvement.

Why? you haven't identified a issue this is resolving? at the moment you are just creating some potential debt without documentation is to what its resolving.

@Peachey88 I've improved the explanation in the description

It is pretty much already public. The configuration as code configuration at https://gitlab.wikimedia.org/repos/releng/jenkins-deploy/-/blob/master/conf/releasing/casc/jenkins.yaml has:

jenkins:
    ldap:
      configurations:
        - server: "ldaps://ldap-labs.eqiad.wikimedia.org:636 ldaps://ldap-labs.codfw.wikimedia.org:636"
          rootDN: "dc=wikimedia,dc=org"
          userSearch: "cn={0}"
          groupSearchBase: "ou=groups"
          inhibitInferRootDN: false
...
  authorizationStrategy:
    projectMatrix:
      permissions:
        - "GROUP:Overall/Administer:releng"
        - "USER:Overall/Read:anonymous"
        - "USER:Overall/Administer:Brennen Bearnes"
        - "USER:Overall/Administer:Giuseppe Lavagetto"
        - "USER:Overall/Administer:Jeena Huneidi"
        - "USER:Overall/Administer:Jforrester"
        - "USER:Overall/Administer:catrope"
        - "USER:Overall/Administer:dduvall"
        - "USER:Overall/Administer:hashar"
        - "USER:Overall/Administer:legoktm"
        - "USER:Overall/Administer:reedy"
        - "USER:Overall/Administer:thcipriani"
        - "USER:Overall/Read:Dzahn"
        - "USER:Overall/Read:mstyles"
        - "USER:Overall/Read:sbassett"

The LDAP data are publicly available via https://ldap.toolforge.org/ :

I don't think we should bother :]

https://ldap.toolforge.org does not offer a full listing of LDAP users/groups in its landing page, so it can't be used for discovery, unlike the Jenkins listings.

My current plan is to also add this change to the CI Jenkins as part of https://phabricator.wikimedia.org/T328920. Plus the effort to reduce this exposure is minimal, check out https://gerrit.wikimedia.org/r/935453.

Overall I think the tradeoff of adding this change makes sense.

@Dzahn that's a good point, I hadn't realized we were also exposing LDAP usernames through wikitech. I agree then this change is not worth doing.

Change 935453 abandoned by Jaime Nuche:

[operations/puppet@production] releases-jenkins: block LDAP users page

Reason:

See Phab task

https://gerrit.wikimedia.org/r/935453

hashar updated the task description. (Show Details)

Turns out Upstream had a very old issue mentioning this: https://issues.jenkins.io/browse/JENKINS-18884 . That is addressed by 2.452.1 which removes the view (we will upgrade as per T366008).