Steps to replicate the issue (include links if applicable):
- Run webservice stop for a buildservice on tools and toolsbeta
What happens?:
toolsbeta.test@toolsbeta-sgebastion-05:~$ toolforge webservice stop
Traceback (most recent call last):
File "/usr/bin/webservice", line 536, in <module>
stop(job, "Stopping webservice")
File "/usr/bin/webservice", line 103, in stop
job.request_stop()
File "/usr/lib/python3/dist-packages/toolsws/backends/kubernetes.py", line 592, in request_stop
label_selector="name={name}".format(name=self.tool.name),
File "/usr/lib/python3/dist-packages/toolforge_weld/kubernetes.py", line 149, in delete_objects
params["labelSelector"] = _format_labels(label_selector)
File "/usr/lib/python3/dist-packages/toolforge_weld/kubernetes.py", line 19, in _format_labels
return ",".join([f"{k}={v}" for k, v in labels.items()])
AttributeError: 'str' object has no attribute 'items'What should have happened instead?:
It should have stopped the service
Software version (skip for WMF-hosted wikis like Wikipedia):
toolsbeta.test@toolsbeta-sgebastion-05:~$ apt policy python3-toolforge-weld python3-toolforge-weld: Installed: 1.1.1
@taavi: I think this is related to something you were doing?